test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V3] tests/pmd_bonded: modify script to support ice nic
@ 2023-02-14 18:31 Song Jiale
  2023-03-07  3:25 ` lijuan.tu
  2023-03-07  3:30 ` lijuan.tu
  0 siblings, 2 replies; 3+ messages in thread
From: Song Jiale @ 2023-02-14 18:31 UTC (permalink / raw)
  To: dts; +Cc: Song Jiale

if the link status of the port of the ice nic needs to be
synchronized with the peer, the peer needs to enable 
"link-down-on-close".

Signed-off-by: Song Jiale <songx.jiale@intel.com>
---
 tests/TestSuite_pmd_bonded.py | 29 +++++++++++++++++++++--------
 1 file changed, 21 insertions(+), 8 deletions(-)

v2:
-modify title and description.

v3:
-increase optimization.

diff --git a/tests/TestSuite_pmd_bonded.py b/tests/TestSuite_pmd_bonded.py
index 97f76e93..2421c4ae 100644
--- a/tests/TestSuite_pmd_bonded.py
+++ b/tests/TestSuite_pmd_bonded.py
@@ -885,14 +885,18 @@ UDP(sport=srcport, dport=destport)/Raw(load="\x50"*%s)], iface="%s", count=%d)'
         self.pmdout = PmdOutput(self.dut)
 
         self.tester_bond = "bond0"
-
-        for port in self.dut_ports:
-            tester_port = self.tester.get_local_port(port)
-            intf = self.tester.get_interface(tester_port)
-            driver = self.tester.ports_info[tester_port]["port"].get_nic_driver()
-            if driver == "i40e":
+        tester_port0 = self.tester.get_local_port(self.dut_ports[0])
+        self.tport_iface0 = self.tester.get_interface(tester_port0)
+        self.flag = "link-down-on-close"
+        self.default_stats = self.tester.get_priv_flags_state(
+            self.tport_iface0, self.flag
+        )
+        if self.default_stats:
+            for port in self.dut_ports:
+                tester_port = self.tester.get_local_port(port)
+                intf = self.tester.get_interface(tester_port)
                 self.tester.send_expect(
-                    "ethtool --set-priv-flags %s link-down-on-close on" % intf, "# ", 10
+                    "ethtool --set-priv-flags %s %s on" % (intf, self.flag), "# "
                 )
 
     def set_up(self):
@@ -2349,4 +2353,13 @@ UDP(sport=srcport, dport=destport)/Raw(load="\x50"*%s)], iface="%s", count=%d)'
         """
         Run after each test suite.
         """
-        pass
+        self.dut.kill_all()
+        if self.default_stats:
+            for port in self.dut_ports:
+                tester_port = self.tester.get_local_port(port)
+                tport_iface = self.tester.get_interface(tester_port)
+                self.tester.send_expect(
+                    "ethtool --set-priv-flags %s %s %s"
+                    % (tport_iface, self.flag, self.default_stats),
+                    "# ",
+                )
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V3] tests/pmd_bonded: modify script to support ice nic
  2023-02-14 18:31 [dts] [PATCH V3] tests/pmd_bonded: modify script to support ice nic Song Jiale
@ 2023-03-07  3:25 ` lijuan.tu
  2023-03-07  3:30 ` lijuan.tu
  1 sibling, 0 replies; 3+ messages in thread
From: lijuan.tu @ 2023-03-07  3:25 UTC (permalink / raw)
  To: dts, Song Jiale; +Cc: Song Jiale

On Tue, 14 Feb 2023 18:31:34 +0000, Song Jiale <songx.jiale@intel.com> wrote:
> if the link status of the port of the ice nic needs to be
> synchronized with the peer, the peer needs to enable 
> "link-down-on-close".
> 
> Signed-off-by: Song Jiale <songx.jiale@intel.com>


Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V3] tests/pmd_bonded: modify script to support ice nic
  2023-02-14 18:31 [dts] [PATCH V3] tests/pmd_bonded: modify script to support ice nic Song Jiale
  2023-03-07  3:25 ` lijuan.tu
@ 2023-03-07  3:30 ` lijuan.tu
  1 sibling, 0 replies; 3+ messages in thread
From: lijuan.tu @ 2023-03-07  3:30 UTC (permalink / raw)
  To: dts, Song Jiale; +Cc: Song Jiale

On Tue, 14 Feb 2023 18:31:34 +0000, Song Jiale <songx.jiale@intel.com> wrote:
> if the link status of the port of the ice nic needs to be
> synchronized with the peer, the peer needs to enable 
> "link-down-on-close".
> 
> Signed-off-by: Song Jiale <songx.jiale@intel.com>

Reviewed-by: Lijuan Tu <lijuan.tu@intel.com>
Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-03-07  3:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-14 18:31 [dts] [PATCH V3] tests/pmd_bonded: modify script to support ice nic Song Jiale
2023-03-07  3:25 ` lijuan.tu
2023-03-07  3:30 ` lijuan.tu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).