test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/generic_flow_api: put validate rule after create rule
@ 2021-03-30  8:18 Xia Yan
  2021-03-30  8:59 ` Chen, LingliX
  2021-03-31  6:02 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: Xia Yan @ 2021-03-30  8:18 UTC (permalink / raw)
  To: dts; +Cc: Xia Yan

it's not work if execute validate rule before execute create rule, so put validate 
after create rule.

Signed-off-by: Xia Yan <yanx.xia@intel.com>
---
 tests/TestSuite_generic_flow_api.py | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/tests/TestSuite_generic_flow_api.py b/tests/TestSuite_generic_flow_api.py
index 6822f8ab..5f9de37c 100644
--- a/tests/TestSuite_generic_flow_api.py
+++ b/tests/TestSuite_generic_flow_api.py
@@ -705,19 +705,19 @@ class TestGeneric_flow_api(TestCase):
         time.sleep(2)
         # create the flow rules
         basic_flow_actions = [
-            {'create': 'validate', 'flows': ['ipv4', 'sip', 'dip'], 'actions': ['queue']},
-            {'create': 'validate', 'flows': ['ipv4', 'sip', 'dip', 'proto', 'udp', 'sport', 'dport'],
-             'actions': ['queue']},
-            {'create': 'validate', 'flows': ['ipv4', 'sip', 'dip', 'proto', 'tcp', 'sport', 'dport'],
-             'actions': ['queue']},
-            {'create': 'validate', 'flows': ['ipv4', 'sip', 'dip', 'proto', 'sctp', 'sport', 'dport'],
-             'actions': ['queue']},
             {'create': 'create', 'flows': ['ipv4', 'sip', 'dip'], 'actions': ['queue']},
             {'create': 'create', 'flows': ['ipv4', 'sip', 'dip', 'proto', 'udp', 'sport', 'dport'],
              'actions': ['queue']},
             {'create': 'create', 'flows': ['ipv4', 'sip', 'dip', 'proto', 'tcp', 'sport', 'dport'],
              'actions': ['queue']},
             {'create': 'create', 'flows': ['ipv4', 'sip', 'dip', 'proto', 'sctp', 'sport', 'dport'],
+             'actions': ['queue']},
+            {'create': 'validate', 'flows': ['ipv4', 'sip', 'dip'], 'actions': ['queue']},
+            {'create': 'validate', 'flows': ['ipv4', 'sip', 'dip', 'proto', 'udp', 'sport', 'dport'],
+             'actions': ['queue']},
+            {'create': 'validate', 'flows': ['ipv4', 'sip', 'dip', 'proto', 'tcp', 'sport', 'dport'],
+             'actions': ['queue']},
+            {'create': 'validate', 'flows': ['ipv4', 'sip', 'dip', 'proto', 'sctp', 'sport', 'dport'],
              'actions': ['queue']}
         ]
         extrapkt_rulenum = self.all_flows_process(basic_flow_actions)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/generic_flow_api: put validate rule after create rule
  2021-03-30  8:18 [dts] [PATCH V1] tests/generic_flow_api: put validate rule after create rule Xia Yan
@ 2021-03-30  8:59 ` Chen, LingliX
  2021-03-31  6:02 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Chen, LingliX @ 2021-03-30  8:59 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]


> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Xia Yan
> Sent: Tuesday, March 30, 2021 4:18 PM
> To: dts@dpdk.org
> Cc: Xia, YanX <yanx.xia@intel.com>
> Subject: [dts] [PATCH V1] tests/generic_flow_api: put validate rule after create
> rule

Tested-by: Chen Lingli <linglix.chen@intel.com>

[-- Attachment #2: TestGeneric_flow_api.log --]
[-- Type: application/octet-stream, Size: 275891 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/generic_flow_api: put validate rule after create rule
  2021-03-30  8:18 [dts] [PATCH V1] tests/generic_flow_api: put validate rule after create rule Xia Yan
  2021-03-30  8:59 ` Chen, LingliX
@ 2021-03-31  6:02 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2021-03-31  6:02 UTC (permalink / raw)
  To: Xia, YanX, dts; +Cc: Xia, YanX



> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Xia Yan
> Sent: 2021年3月30日 16:18
> To: dts@dpdk.org
> Cc: Xia, YanX <yanx.xia@intel.com>
> Subject: [dts] [PATCH V1] tests/generic_flow_api: put validate rule after create
> rule
> 
> it's not work if execute validate rule before execute create rule, so put validate
> after create rule.
> 
> Signed-off-by: Xia Yan <yanx.xia@intel.com>

Why do this, it violates test plan:

validate the rules first before create it in each case.
All the rules that can be validated correctly should be created successfully.
The rules can't be validated correctly shouldn't be created successfully.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-31  6:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-30  8:18 [dts] [PATCH V1] tests/generic_flow_api: put validate rule after create rule Xia Yan
2021-03-30  8:59 ` Chen, LingliX
2021-03-31  6:02 ` Tu, Lijuan

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git