[spp] [PATCH 0/2] Fix compile errors for SPP v18.08

[spp] [PATCH 0/2] Fix compile errors for SPP v18.08

[ogawa.yasufumi]

From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>

This series of patches is to fix compile errors for previous patches to
update version to v18.08.

* Add `-DALLOW_EXPERIMENTAL_API` to CFLAGS to avoid warnings for
  experimental APIs. 

* Fix compile error of not used variable.

Yasufumi Ogawa (2):
  makefile: add DALLOW_EXPERIMENTAL_API option
  spp_vf: fix bug of not used variable

 src/mirror/Makefile         | 1 +
 src/nfv/Makefile            | 1 +
 src/primary/Makefile        | 1 +
 src/vf/Makefile             | 1 +
 src/vf/common/command_dec.c | 1 +
 5 files changed, 5 insertions(+)

-- 
2.7.4

[spp] [PATCH 1/2] makefile: add DALLOW_EXPERIMENTAL_API option

[ogawa.yasufumi]

From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>

Some of latest DPDK APIs introduced to replace deprecated APIs are
still experimental. This update is to add `-DALLOW_EXPERIMENTAL_API`
option to CFLAGS to avoid compile errors for the experimental APIs.

Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
---
 src/mirror/Makefile  | 1 +
 src/nfv/Makefile     | 1 +
 src/primary/Makefile | 1 +
 src/vf/Makefile      | 1 +
 4 files changed, 4 insertions(+)

diff --git a/src/mirror/Makefile b/src/mirror/Makefile
index a759ad2..614a44c 100644
--- a/src/mirror/Makefile
+++ b/src/mirror/Makefile
@@ -19,6 +19,7 @@ SRCS-y += ../vf/common/command_conn.c ../vf/common/command_proc.c
 SRCS-y += ../vf/common/command_dec.c
 SRCS-y += ../vf/common/ringlatencystats.c ../vf/common/string_buffer.c
 
+CFLAGS += -DALLOW_EXPERIMENTAL_API
 CFLAGS += $(WERROR_FLAGS) -O3
 CFLAGS += -I$(SRCDIR)/../shared
 CFLAGS += -I$(SRCDIR)/../vf/common
diff --git a/src/nfv/Makefile b/src/nfv/Makefile
index 4d5eec6..16dfbbb 100644
--- a/src/nfv/Makefile
+++ b/src/nfv/Makefile
@@ -14,6 +14,7 @@ APP = spp_nfv
 # all source are stored in SRCS-y
 SRCS-y := nfv.c ../shared/common.c
 
+CFLAGS += -DALLOW_EXPERIMENTAL_API
 CFLAGS += $(WERROR_FLAGS) -O3
 CFLAGS += -I$(SRCDIR)/../shared
 
diff --git a/src/primary/Makefile b/src/primary/Makefile
index e8a5d8d..bedea8e 100644
--- a/src/primary/Makefile
+++ b/src/primary/Makefile
@@ -23,6 +23,7 @@ SRCS-y := main.c init.c args.c ../shared/common.c
 
 INC := $(wildcard *.h)
 
+CFLAGS += -DALLOW_EXPERIMENTAL_API
 CFLAGS += $(WERROR_FLAGS) -O3
 CFLAGS += -I$(SRCDIR)/../shared
 
diff --git a/src/vf/Makefile b/src/vf/Makefile
index b0a1fdb..f2a167b 100644
--- a/src/vf/Makefile
+++ b/src/vf/Makefile
@@ -18,6 +18,7 @@ SRCS-y += common/command_conn.c common/command_dec.c common/command_proc.c
 SRCS-y += common/spp_proc.c
 SRCS-y += ../shared/common.c
 
+CFLAGS += -DALLOW_EXPERIMENTAL_API
 CFLAGS += $(WERROR_FLAGS) -O3
 CFLAGS += -I$(SRCDIR)/../shared
 CFLAGS += -I$(SRCDIR)/common
-- 
2.7.4

[spp] [PATCH 2/2] spp_vf: fix bug of not used variable

[ogawa.yasufumi]

From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>

`type_str` is only used in `ifdef` preprocessor directive and it is
considered as not used variable and causes a compile error. This update
is to fix this bug by reffering it outside `ifdef` directive.

Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
---
 src/vf/common/command_dec.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/vf/common/command_dec.c b/src/vf/common/command_dec.c
index 9f56eba..5b6ffcf 100644
--- a/src/vf/common/command_dec.c
+++ b/src/vf/common/command_dec.c
@@ -186,6 +186,7 @@ spp_convert_port_to_iface(const char *port,
 static enum spp_component_type
 spp_convert_component_type(const char *type_str)
 {
+	RTE_LOG(DEBUG, APP, "type_str is %s\n", type_str);
 #ifdef SPP_VF_MODULE
 	if (strncmp(type_str, CORE_TYPE_CLASSIFIER_MAC_STR,
 			strlen(CORE_TYPE_CLASSIFIER_MAC_STR)+1) == 0) {
-- 
2.7.4