Soft Patch Panel
 help / color / mirror / Atom feed
* [spp] [PATCH] controller: fix bug of no existing variable
@ 2019-01-31  3:04 ogawa.yasufumi
  0 siblings, 0 replies; only message in thread
From: ogawa.yasufumi @ 2019-01-31  3:04 UTC (permalink / raw)
  To: ferruh.yigit, spp, ogawa.yasufumi

From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>

Correct to refer no existing member variable `rest_common_error_codes`
which was moved spp_ctl_cli object.

Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
---
 src/controller/commands/pri.py | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/src/controller/commands/pri.py b/src/controller/commands/pri.py
index 7712ba2..662e41a 100644
--- a/src/controller/commands/pri.py
+++ b/src/controller/commands/pri.py
@@ -6,6 +6,7 @@ from __future__ import absolute_import
 from .. import spp_common
 from ..shell_lib import common
 
+
 class SppPrimary(object):
     """Exec SPP primary command.
 
@@ -33,12 +34,15 @@ class SppPrimary(object):
             print("Invalid pri command: '%s'" % subcmd)
             return None
 
+        # use short name
+        common_err_codes = self.spp_ctl_cli.rest_common_error_codes
+
         if subcmd == 'status':
             res = self.spp_ctl_cli.get('primary/status')
             if res is not None:
                 if res.status_code == 200:
                     self.print_status(res.json())
-                elif res.status_code in self.rest_common_error_codes:
+                elif res.status_code in common_err_codes:
                     # Print default error message
                     pass
                 else:
@@ -52,7 +56,7 @@ class SppPrimary(object):
             if res is not None:
                 if res.status_code == 204:
                     print('Clear port statistics.')
-                elif res.status_code in self.rest_common_error_codes:
+                elif res.status_code in common_err_codes:
                     pass
                 else:
                     print('Error: unknown response.')
@@ -62,6 +66,7 @@ class SppPrimary(object):
 
     def do_exit(self):
         res = self.spp_ctl_cli.delete('primary')
+
         if res is not None:
             error_codes = self.spp_ctl_cli.rest_common_error_codes
             if res.status_code == 204:
@@ -199,7 +204,7 @@ class SppPrimary(object):
                 for proc in res.json():
                     if proc['type'] != 'primary':
                         sec_ids.append(proc['client-id'])
-            elif res.status_code in self.rest_common_error_codes:
+            elif res.status_code in self.spp_ctl_cli.rest_common_error_codes:
                 # Print default error message
                 pass
             else:
-- 
2.7.4

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-01-31  3:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-31  3:04 [spp] [PATCH] controller: fix bug of no existing variable ogawa.yasufumi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).