From: x-fn-spp@sl.ntt-tx.co.jp
To: ferruh.yigit@intel.com, ogawa.yasufumi@lab.ntt.co.jp
Cc: spp@dpdk.org
Subject: [spp] [PATCH 2/4] spp_nfv: fix incorrect deleting for ring port
Date: Fri, 8 Feb 2019 17:47:51 +0900 [thread overview]
Message-ID: <201902080847.x188lrFd021615@imss03.silk.ntt-tx.co.jp> (raw)
In-Reply-To: <20190208084753.8049-1-x-fn-spp@sl.ntt-tx.co.jp>
From: Hideyuki Yamashita <yamashita.hideyuki@po.ntt-tx.co.jp>
Spp_nfv uses `rte_eal_hotplug_remove()` in `dev_detach_by_port_id()` to
delete a ring. However, it is wrong because it causes an error when
adding the same ring again. This update is to use `rte_eth_dev_stop()`
and `rte_eth_dev_close()` as correct manner.
Signed-off-by: Hideyuki Yamashita <yamashita.hideyuki@po.ntt-tx.co.jp>
Signed-off-by: Naoki Takada <takada.naoki@lab.ntt.co.jp>
---
src/nfv/commands.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/nfv/commands.h b/src/nfv/commands.h
index 36ad86d..c8f726f 100644
--- a/src/nfv/commands.h
+++ b/src/nfv/commands.h
@@ -38,7 +38,8 @@ do_del(char *res_uid)
if (port_id == PORT_RESET)
return -1;
- dev_detach_by_port_id(port_id);
+ rte_eth_dev_stop(port_id);
+ rte_eth_dev_close(port_id);
} else if (!strcmp(p_type, "pcap")) {
port_id = find_port_id(p_id, PCAP);
--
2.17.1
next prev parent reply other threads:[~2019-02-08 8:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190208084753.8049-1-x-fn-spp@sl.ntt-tx.co.jp>
2019-02-08 8:47 ` [spp] [PATCH 1/4] shared: fix trying to create ring already exist x-fn-spp
2019-02-08 8:47 ` x-fn-spp [this message]
2019-02-08 8:47 ` [spp] [PATCH 3/4] spp_vf: " x-fn-spp
2019-02-08 8:47 ` [spp] [PATCH 4/4] spp_pcap: " x-fn-spp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201902080847.x188lrFd021615@imss03.silk.ntt-tx.co.jp \
--to=x-fn-spp@sl.ntt-tx.co.jp \
--cc=ferruh.yigit@intel.com \
--cc=ogawa.yasufumi@lab.ntt.co.jp \
--cc=spp@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).