[spp] [PATCH 1/4] shared: fix trying to create ring already exist

[x-fn-spp@sl.ntt-tx.co.jp]

From: Hideyuki Yamashita <yamashita.hideyuki@po.ntt-tx.co.jp>

In add_ring_pmd(), it tries to create a ring port without checking if
already exists. To fix the issue, check requested port is created
before. If so, it calls rte_eth_dev_start() instead.

Signed-off-by: Hideyuki Yamashita <yamashita.hideyuki@po.ntt-tx.co.jp>
Signed-off-by: Naoki Takada <takada.naoki@lab.ntt.co.jp>
---
 src/shared/secondary/add_port.c | 21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)

diff --git a/src/shared/secondary/add_port.c b/src/shared/secondary/add_port.c
index 2841f94..6924583 100644
--- a/src/shared/secondary/add_port.c
+++ b/src/shared/secondary/add_port.c
@@ -103,6 +103,8 @@ add_ring_pmd(int ring_id)
 	struct rte_ring *ring;
 	int res;
 	char rx_queue_name[32];  /* Prefix and number like as 'eth_ring_0' */
+	uint16_t port_id = PORT_RESET;
+	char dev_name[RTE_ETH_NAME_MAX_LEN];
 
 	memset(rx_queue_name, '\0', sizeof(rx_queue_name));
 	sprintf(rx_queue_name, "%s", get_rx_queue_name(ring_id));
@@ -118,12 +120,21 @@ add_ring_pmd(int ring_id)
 	RTE_LOG(INFO, SHARED, "Looked up ring '%s'\n", rx_queue_name);
 
 	/* create ring pmd*/
-	res = rte_eth_from_ring(ring);
-	if (res < 0) {
-		RTE_LOG(ERR, SHARED,
-			"Cannot create eth dev with rte_eth_from_ring()\n");
-		return -1;
+	snprintf(dev_name, RTE_ETH_NAME_MAX_LEN - 1, "net_ring_%s", ring->name);
+	/* check whether a port already exists. */
+	res = rte_eth_dev_get_port_by_name(dev_name, &port_id);
+	if (port_id == PORT_RESET) {
+		res = rte_eth_from_ring(ring);
+		if (res < 0) {
+			RTE_LOG(ERR, SHARED, "Cannot create eth dev with "
+						"rte_eth_from_ring()\n");
+			return -1;
+		}
+	} else {
+		res = port_id;
+		rte_eth_dev_start(res);
 	}
+
 	RTE_LOG(INFO, SHARED, "Created ring PMD: %d\n", res);
 
 	return res;
-- 
2.17.1