Soft Patch Panel
 help / color / Atom feed
* [spp] [PATCH 00/11] switch to use original vhost PMD again
@ 2020-04-02  0:06 Itsuro Oda
  2020-04-02  0:06 ` [spp] [PATCH 01/11] shared: " Itsuro Oda
                   ` (12 more replies)
  0 siblings, 13 replies; 14+ messages in thread
From: Itsuro Oda @ 2020-04-02  0:06 UTC (permalink / raw)
  To: spp, ferruh.yigit, yasufum.o

Original vhost PMD was fixed to be used by a secondary process
in DPDK v20.02.
This series of patches switch to use original vhost PMD and
remove SPP dedicated vhost PMD.

Itsuro Oda (11):
  shared: switch to use original vhost PMD again
  spp_nfv: remove unnecessary code for vhost
  spp_primary: remove unnecessary code for vhost
  spp_primary: remove link to vhost PMD in Makefile
  spp_nfv: remove link to vhost PMD in Makefile
  spp_vf: remove link to vhost PMD in Makefile
  spp_mirror: remove link to vhost PMD in Makefile
  spp_pcap: remove link to vhost PMD in Makefile
  vdev_test: remove link to vhost PMD in Makefile
  drivers: remove build task for SPP dedicated vhost PMD
  drivers/vhost: remove SPP dedicated vhost PMD

 src/drivers/Makefile                          |   1 -
 src/drivers/vhost/Makefile                    |  28 -
 .../vhost/rte_pmd_spp_vhost_version.map       |   4 -
 src/drivers/vhost/rte_spp_vhost.c             | 592 ------------------
 src/mirror/Makefile                           |   2 +-
 src/nfv/Makefile                              |   2 +-
 src/nfv/commands.h                            |   1 -
 src/pcap/Makefile                             |   2 +-
 src/primary/Makefile                          |   2 +-
 src/primary/main.c                            |   1 -
 src/shared/common.c                           |   4 +-
 src/shared/common.h                           |   1 -
 src/shared/secondary/add_port.c               |  15 +-
 src/shared/secondary/add_port.h               |   2 +-
 src/vf/Makefile                               |   2 +-
 tools/vdev_test/Makefile                      |   2 +-
 16 files changed, 18 insertions(+), 643 deletions(-)
 delete mode 100644 src/drivers/vhost/Makefile
 delete mode 100644 src/drivers/vhost/rte_pmd_spp_vhost_version.map
 delete mode 100644 src/drivers/vhost/rte_spp_vhost.c

-- 
2.17.0


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [spp] [PATCH 01/11] shared: switch to use original vhost PMD again
  2020-04-02  0:06 [spp] [PATCH 00/11] switch to use original vhost PMD again Itsuro Oda
@ 2020-04-02  0:06 ` " Itsuro Oda
  2020-04-02  0:06 ` [spp] [PATCH 02/11] spp_nfv: remove unnecessary code for vhost Itsuro Oda
                   ` (11 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: Itsuro Oda @ 2020-04-02  0:06 UTC (permalink / raw)
  To: spp, ferruh.yigit, yasufum.o

Original vhost PMD was fixed to be used by a secondary process
in DPDK v20.02.
This patch switches to use original vhost PMD instead of SPP
dedicated vhost PMD.
This patch also modifies comment about vhost in detail more.

Signed-off-by: Itsuro Oda <oda@valinux.co.jp>
---
 src/shared/common.c             |  4 +---
 src/shared/common.h             |  1 -
 src/shared/secondary/add_port.c | 15 ++++++++++-----
 src/shared/secondary/add_port.h |  2 +-
 4 files changed, 12 insertions(+), 10 deletions(-)

diff --git a/src/shared/common.c b/src/shared/common.c
index d1c3e36..61db6ba 100644
--- a/src/shared/common.c
+++ b/src/shared/common.c
@@ -91,9 +91,7 @@ int parse_dev_name(char *dev_name, int *port_type, int *port_id)
 	} else if (strncmp(dev_name, VDEV_ETH_VHOST,
 				strlen(VDEV_ETH_VHOST)) == 0 ||
 			strncmp(dev_name, VDEV_NET_VHOST,
-				strlen(VDEV_NET_VHOST)) == 0 ||
-			strncmp(dev_name, VDEV_SPP_VHOST,
-				strlen(VDEV_SPP_VHOST)) == 0) {
+				strlen(VDEV_NET_VHOST)) == 0) {
 		dev_str_len = strlen(VDEV_NET_VHOST);
 		pid_len = dev_name_len - dev_str_len;
 		strncpy(pid_str, dev_name + strlen(VDEV_NET_VHOST),
diff --git a/src/shared/common.h b/src/shared/common.h
index fd3102c..f2909c2 100644
--- a/src/shared/common.h
+++ b/src/shared/common.h
@@ -52,7 +52,6 @@
 #define VDEV_NET_RING "net_ring"
 #define VDEV_ETH_VHOST "eth_vhost"
 #define VDEV_NET_VHOST "net_vhost"
-#define VDEV_SPP_VHOST "spp_vhost"
 #define VDEV_NET_PCAP "net_pcap"
 #define VDEV_ETH_TAP "eth_tap"
 #define VDEV_NET_TAP "net_tap"
diff --git a/src/shared/secondary/add_port.c b/src/shared/secondary/add_port.c
index a7b7261..bca18b1 100644
--- a/src/shared/secondary/add_port.c
+++ b/src/shared/secondary/add_port.c
@@ -186,11 +186,16 @@ add_vhost_pmd(int index)
 		return ret;
 	}
 
-	/* NOTE: make sure the eth_dev is stopped.
-	 * it is for the case a secondary process which used the vhost
-	 * was down without stopping the device.
-	 * note that it is still user responsibility to prevent multipul
-	 * processes use a vhost at the same time.
+	/* NOTE:
+	 * A vhost PMD is shared among multi processes, but it
+	 * can be used by only one process. It is user responsibility
+	 * to prevent multipul processes use a vhost at the same time.
+	 * The same vhost interface can be used after the vhost is
+	 * deleted (and created again) or the process which used the
+	 * vhost is down.
+	 * dev_attach_by_devargs will succeed even if the device exists.
+	 * rte_eth_dev_stop is necessary to configure the device again.
+	 * It is no-op if the device is stopped.
 	 */
 	rte_eth_dev_stop(vhost_port_id);
 
diff --git a/src/shared/secondary/add_port.h b/src/shared/secondary/add_port.h
index 39feb50..d41969b 100644
--- a/src/shared/secondary/add_port.h
+++ b/src/shared/secondary/add_port.h
@@ -10,7 +10,7 @@
 #define NR_DESCS 128
 
 #define VHOST_IFACE_NAME "/tmp/sock%u"
-#define VHOST_BACKEND_NAME "spp_vhost%u"
+#define VHOST_BACKEND_NAME "eth_vhost%u"
 
 #define PCAP_PMD_DEV_NAME "eth_pcap%u"
 #define MEMIF_PMD_DEV_NAME "net_memif%u"
-- 
2.17.0


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [spp] [PATCH 02/11] spp_nfv: remove unnecessary code for vhost
  2020-04-02  0:06 [spp] [PATCH 00/11] switch to use original vhost PMD again Itsuro Oda
  2020-04-02  0:06 ` [spp] [PATCH 01/11] shared: " Itsuro Oda
@ 2020-04-02  0:06 ` Itsuro Oda
  2020-04-02  0:06 ` [spp] [PATCH 03/11] spp_primary: " Itsuro Oda
                   ` (10 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: Itsuro Oda @ 2020-04-02  0:06 UTC (permalink / raw)
  To: spp, ferruh.yigit, yasufum.o

This patch removes an unnecessary code for original vhost PMD
which was necessary for SPP dedicated vhost PMD.

Signed-off-by: Itsuro Oda <oda@valinux.co.jp>
---
 src/nfv/commands.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/nfv/commands.h b/src/nfv/commands.h
index 6b3a935..fd7f1f8 100644
--- a/src/nfv/commands.h
+++ b/src/nfv/commands.h
@@ -25,7 +25,6 @@ do_del(char *p_type, int p_id, uint16_t queue_id)
 		port_id = find_port_id(p_id, VHOST);
 		if (port_id == PORT_RESET)
 			return -1;
-		rte_eth_dev_stop(port_id);
 		dev_detach_by_port_id(port_id);
 
 	} else if (!strcmp(p_type, "ring")) {
-- 
2.17.0


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [spp] [PATCH 03/11] spp_primary: remove unnecessary code for vhost
  2020-04-02  0:06 [spp] [PATCH 00/11] switch to use original vhost PMD again Itsuro Oda
  2020-04-02  0:06 ` [spp] [PATCH 01/11] shared: " Itsuro Oda
  2020-04-02  0:06 ` [spp] [PATCH 02/11] spp_nfv: remove unnecessary code for vhost Itsuro Oda
@ 2020-04-02  0:06 ` " Itsuro Oda
  2020-04-02  0:06 ` [spp] [PATCH 04/11] spp_primary: remove link to vhost PMD in Makefile Itsuro Oda
                   ` (9 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: Itsuro Oda @ 2020-04-02  0:06 UTC (permalink / raw)
  To: spp, ferruh.yigit, yasufum.o

This patch removes an unnecessary code for original vhost PMD
which was necessary for SPP dedicated vhost PMD.

Signed-off-by: Itsuro Oda <oda@valinux.co.jp>
---
 src/primary/main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/primary/main.c b/src/primary/main.c
index 872f820..6d3ec96 100644
--- a/src/primary/main.c
+++ b/src/primary/main.c
@@ -970,7 +970,6 @@ del_port(char *p_type, int p_id)
 		dev_id = find_ethdev_id(p_id, VHOST);
 		if (dev_id == PORT_RESET)
 			return -1;
-		rte_eth_dev_stop(dev_id);
 		dev_detach_by_port_id(dev_id);
 
 	} else if (!strcmp(p_type, "ring")) {
-- 
2.17.0


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [spp] [PATCH 04/11] spp_primary: remove link to vhost PMD in Makefile
  2020-04-02  0:06 [spp] [PATCH 00/11] switch to use original vhost PMD again Itsuro Oda
                   ` (2 preceding siblings ...)
  2020-04-02  0:06 ` [spp] [PATCH 03/11] spp_primary: " Itsuro Oda
@ 2020-04-02  0:06 ` Itsuro Oda
  2020-04-02  0:06 ` [spp] [PATCH 05/11] spp_nfv: " Itsuro Oda
                   ` (8 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: Itsuro Oda @ 2020-04-02  0:06 UTC (permalink / raw)
  To: spp, ferruh.yigit, yasufum.o

This patch removes link to SPP dedicated vhost PMD in Makefile.

Signed-off-by: Itsuro Oda <oda@valinux.co.jp>
---
 src/primary/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/primary/Makefile b/src/primary/Makefile
index 156b7cd..35520ef 100644
--- a/src/primary/Makefile
+++ b/src/primary/Makefile
@@ -52,6 +52,6 @@ endif
 EXTRA_CFLAGS += -fno-strict-aliasing
 
 SPP_DRIVERS_DIR = $(BASE_OUTPUT)/src/drivers
-EXTRA_LDLIBS = -L$(SPP_DRIVERS_DIR)/vhost -L$(SPP_DRIVERS_DIR)/pipe --whole-archive -lrte_pmd_spp_vhost -lrte_pmd_spp_pipe --no-whole-archive
+EXTRA_LDLIBS = -L$(SPP_DRIVERS_DIR)/pipe --whole-archive -lrte_pmd_spp_pipe --no-whole-archive
 
 include $(RTE_SDK)/mk/rte.extapp.mk
-- 
2.17.0


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [spp] [PATCH 05/11] spp_nfv: remove link to vhost PMD in Makefile
  2020-04-02  0:06 [spp] [PATCH 00/11] switch to use original vhost PMD again Itsuro Oda
                   ` (3 preceding siblings ...)
  2020-04-02  0:06 ` [spp] [PATCH 04/11] spp_primary: remove link to vhost PMD in Makefile Itsuro Oda
@ 2020-04-02  0:06 ` " Itsuro Oda
  2020-04-02  0:06 ` [spp] [PATCH 06/11] spp_vf: " Itsuro Oda
                   ` (7 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: Itsuro Oda @ 2020-04-02  0:06 UTC (permalink / raw)
  To: spp, ferruh.yigit, yasufum.o

This patch removes link to SPP dedicated vhost PMD in Makefile.

Signed-off-by: Itsuro Oda <oda@valinux.co.jp>
---
 src/nfv/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/nfv/Makefile b/src/nfv/Makefile
index 16a10f7..cb18900 100644
--- a/src/nfv/Makefile
+++ b/src/nfv/Makefile
@@ -28,6 +28,6 @@ LDLIBS += -lrte_pmd_vhost
 endif
 
 SPP_DRIVERS_DIR = $(BASE_OUTPUT)/src/drivers
-EXTRA_LDLIBS = -L$(SPP_DRIVERS_DIR)/vhost -L$(SPP_DRIVERS_DIR)/pipe --whole-archive -lrte_pmd_spp_vhost -lrte_pmd_spp_pipe --no-whole-archive
+EXTRA_LDLIBS = -L$(SPP_DRIVERS_DIR)/pipe --whole-archive -lrte_pmd_spp_pipe --no-whole-archive
 
 include $(RTE_SDK)/mk/rte.extapp.mk
-- 
2.17.0


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [spp] [PATCH 06/11] spp_vf: remove link to vhost PMD in Makefile
  2020-04-02  0:06 [spp] [PATCH 00/11] switch to use original vhost PMD again Itsuro Oda
                   ` (4 preceding siblings ...)
  2020-04-02  0:06 ` [spp] [PATCH 05/11] spp_nfv: " Itsuro Oda
@ 2020-04-02  0:06 ` " Itsuro Oda
  2020-04-02  0:06 ` [spp] [PATCH 07/11] spp_mirror: " Itsuro Oda
                   ` (6 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: Itsuro Oda @ 2020-04-02  0:06 UTC (permalink / raw)
  To: spp, ferruh.yigit, yasufum.o

This patch removes link to SPP dedicated vhost PMD in Makefile.

Signed-off-by: Itsuro Oda <oda@valinux.co.jp>
---
 src/vf/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/vf/Makefile b/src/vf/Makefile
index 0f7410f..1daddb6 100644
--- a/src/vf/Makefile
+++ b/src/vf/Makefile
@@ -49,6 +49,6 @@ LDLIBS += -lrte_pmd_vhost
 endif
 
 SPP_DRIVERS_DIR = $(BASE_OUTPUT)/src/drivers
-EXTRA_LDLIBS = -L$(SPP_DRIVERS_DIR)/vhost -L$(SPP_DRIVERS_DIR)/pipe --whole-archive -lrte_pmd_spp_vhost -lrte_pmd_spp_pipe --no-whole-archive
+EXTRA_LDLIBS = -L$(SPP_DRIVERS_DIR)/pipe --whole-archive -lrte_pmd_spp_pipe --no-whole-archive
 
 include $(RTE_SDK)/mk/rte.extapp.mk
-- 
2.17.0


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [spp] [PATCH 07/11] spp_mirror: remove link to vhost PMD in Makefile
  2020-04-02  0:06 [spp] [PATCH 00/11] switch to use original vhost PMD again Itsuro Oda
                   ` (5 preceding siblings ...)
  2020-04-02  0:06 ` [spp] [PATCH 06/11] spp_vf: " Itsuro Oda
@ 2020-04-02  0:06 ` " Itsuro Oda
  2020-04-02  0:06 ` [spp] [PATCH 08/11] spp_pcap: " Itsuro Oda
                   ` (5 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: Itsuro Oda @ 2020-04-02  0:06 UTC (permalink / raw)
  To: spp, ferruh.yigit, yasufum.o

This patch removes link to SPP dedicated vhost PMD in Makefile.

Signed-off-by: Itsuro Oda <oda@valinux.co.jp>
---
 src/mirror/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mirror/Makefile b/src/mirror/Makefile
index e00ca76..e878c89 100644
--- a/src/mirror/Makefile
+++ b/src/mirror/Makefile
@@ -54,6 +54,6 @@ LDLIBS += -lrte_pmd_vhost
 endif
 
 SPP_DRIVERS_DIR = $(BASE_OUTPUT)/src/drivers
-EXTRA_LDLIBS = -L$(SPP_DRIVERS_DIR)/vhost -L$(SPP_DRIVERS_DIR)/pipe --whole-archive -lrte_pmd_spp_vhost -lrte_pmd_spp_pipe --no-whole-archive
+EXTRA_LDLIBS = -L$(SPP_DRIVERS_DIR)/pipe --whole-archive -lrte_pmd_spp_pipe --no-whole-archive
 
 include $(RTE_SDK)/mk/rte.extapp.mk
-- 
2.17.0


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [spp] [PATCH 08/11] spp_pcap: remove link to vhost PMD in Makefile
  2020-04-02  0:06 [spp] [PATCH 00/11] switch to use original vhost PMD again Itsuro Oda
                   ` (6 preceding siblings ...)
  2020-04-02  0:06 ` [spp] [PATCH 07/11] spp_mirror: " Itsuro Oda
@ 2020-04-02  0:06 ` " Itsuro Oda
  2020-04-02  0:06 ` [spp] [PATCH 09/11] vdev_test: " Itsuro Oda
                   ` (4 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: Itsuro Oda @ 2020-04-02  0:06 UTC (permalink / raw)
  To: spp, ferruh.yigit, yasufum.o

This patch removes link to SPP dedicated vhost PMD in Makefile.

Signed-off-by: Itsuro Oda <oda@valinux.co.jp>
---
 src/pcap/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/pcap/Makefile b/src/pcap/Makefile
index fd51c65..4e53952 100644
--- a/src/pcap/Makefile
+++ b/src/pcap/Makefile
@@ -44,6 +44,6 @@ LDLIBS += -lrte_pmd_vhost
 endif
 
 SPP_DRIVERS_DIR = $(BASE_OUTPUT)/src/drivers
-EXTRA_LDLIBS = -L$(SPP_DRIVERS_DIR)/vhost -L$(SPP_DRIVERS_DIR)/pipe --whole-archive -lrte_pmd_spp_vhost -lrte_pmd_spp_pipe --no-whole-archive
+EXTRA_LDLIBS = -L$(SPP_DRIVERS_DIR)/pipe --whole-archive -lrte_pmd_spp_pipe --no-whole-archive
 
 include $(RTE_SDK)/mk/rte.extapp.mk
-- 
2.17.0


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [spp] [PATCH 09/11] vdev_test: remove link to vhost PMD in Makefile
  2020-04-02  0:06 [spp] [PATCH 00/11] switch to use original vhost PMD again Itsuro Oda
                   ` (7 preceding siblings ...)
  2020-04-02  0:06 ` [spp] [PATCH 08/11] spp_pcap: " Itsuro Oda
@ 2020-04-02  0:06 ` " Itsuro Oda
  2020-04-02  0:06 ` [spp] [PATCH 10/11] drivers: remove build task for SPP dedicated vhost PMD Itsuro Oda
                   ` (3 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: Itsuro Oda @ 2020-04-02  0:06 UTC (permalink / raw)
  To: spp, ferruh.yigit, yasufum.o

This patch removes link to SPP dedicated vhost PMD in Makefile.

Signed-off-by: Itsuro Oda <oda@valinux.co.jp>
---
 tools/vdev_test/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/vdev_test/Makefile b/tools/vdev_test/Makefile
index aabd9c4..a77cccc 100644
--- a/tools/vdev_test/Makefile
+++ b/tools/vdev_test/Makefile
@@ -20,6 +20,6 @@ CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
 
 SPP_DRIVERS_DIR = $(BASE_OUTPUT)/src/drivers
-EXTRA_LDLIBS = -L$(SPP_DRIVERS_DIR)/vhost -L$(SPP_DRIVERS_DIR)/pipe --whole-archive -lrte_pmd_spp_vhost -lrte_pmd_spp_pipe --no-whole-archive
+EXTRA_LDLIBS = -L$(SPP_DRIVERS_DIR)/pipe --whole-archive -lrte_pmd_spp_pipe --no-whole-archive
 
 include $(RTE_SDK)/mk/rte.extapp.mk
-- 
2.17.0


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [spp] [PATCH 10/11] drivers: remove build task for SPP dedicated vhost PMD
  2020-04-02  0:06 [spp] [PATCH 00/11] switch to use original vhost PMD again Itsuro Oda
                   ` (8 preceding siblings ...)
  2020-04-02  0:06 ` [spp] [PATCH 09/11] vdev_test: " Itsuro Oda
@ 2020-04-02  0:06 ` Itsuro Oda
  2020-04-02  0:06 ` [spp] [PATCH 11/11] drivers/vhost: remove " Itsuro Oda
                   ` (2 subsequent siblings)
  12 siblings, 0 replies; 14+ messages in thread
From: Itsuro Oda @ 2020-04-02  0:06 UTC (permalink / raw)
  To: spp, ferruh.yigit, yasufum.o

This patch remove build task for SPP dedicated vhost PMD

Signed-off-by: Itsuro Oda <oda@valinux.co.jp>
---
 src/drivers/Makefile | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/drivers/Makefile b/src/drivers/Makefile
index f759238..fae05e8 100644
--- a/src/drivers/Makefile
+++ b/src/drivers/Makefile
@@ -10,7 +10,6 @@ RTE_TARGET ?= x86_64-native-linuxapp-gcc
 
 include $(RTE_SDK)/mk/rte.vars.mk
 
-DIRS-y += vhost
 DIRS-y += pipe
 
 include $(RTE_SDK)/mk/rte.extsubdir.mk
-- 
2.17.0


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [spp] [PATCH 11/11] drivers/vhost: remove SPP dedicated vhost PMD
  2020-04-02  0:06 [spp] [PATCH 00/11] switch to use original vhost PMD again Itsuro Oda
                   ` (9 preceding siblings ...)
  2020-04-02  0:06 ` [spp] [PATCH 10/11] drivers: remove build task for SPP dedicated vhost PMD Itsuro Oda
@ 2020-04-02  0:06 ` " Itsuro Oda
  2020-04-30  2:39 ` [spp] (x-fn-spp-ml 616) [PATCH 00/11] switch to use original vhost PMD again Hideyuki Yamashita
  2020-05-25  3:04 ` [spp] " Yasufumi Ogawa
  12 siblings, 0 replies; 14+ messages in thread
From: Itsuro Oda @ 2020-04-02  0:06 UTC (permalink / raw)
  To: spp, ferruh.yigit, yasufum.o

This patch removes SPP dedicated vhost PMD.

Signed-off-by: Itsuro Oda <oda@valinux.co.jp>
---
 src/drivers/vhost/Makefile                    |  28 -
 .../vhost/rte_pmd_spp_vhost_version.map       |   4 -
 src/drivers/vhost/rte_spp_vhost.c             | 592 ------------------
 3 files changed, 624 deletions(-)
 delete mode 100644 src/drivers/vhost/Makefile
 delete mode 100644 src/drivers/vhost/rte_pmd_spp_vhost_version.map
 delete mode 100644 src/drivers/vhost/rte_spp_vhost.c

diff --git a/src/drivers/vhost/Makefile b/src/drivers/vhost/Makefile
deleted file mode 100644
index e29c330..0000000
--- a/src/drivers/vhost/Makefile
+++ /dev/null
@@ -1,28 +0,0 @@
-# SPDX-License-Identifier: BSD-3-Clause
-# Copyright(c) 2019 Nippon Telegraph and Telephone Corporation
-
-include $(RTE_SDK)/mk/rte.vars.mk
-
-#
-# library name
-#
-LIB = librte_pmd_spp_vhost.a
-
-LDLIBS += -lpthread
-LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
-LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs -lrte_vhost
-LDLIBS += -lrte_bus_vdev
-
-CFLAGS += -O3
-CFLAGS += $(WERROR_FLAGS)
-
-EXPORT_MAP := rte_pmd_spp_vhost_version.map
-
-LIBABIVER := 2
-
-#
-# all source are stored in SRCS-y
-#
-SRCS-$(CONFIG_RTE_LIBRTE_PMD_VHOST) += rte_spp_vhost.c
-
-include $(RTE_SDK)/mk/rte.lib.mk
diff --git a/src/drivers/vhost/rte_pmd_spp_vhost_version.map b/src/drivers/vhost/rte_pmd_spp_vhost_version.map
deleted file mode 100644
index ef35398..0000000
--- a/src/drivers/vhost/rte_pmd_spp_vhost_version.map
+++ /dev/null
@@ -1,4 +0,0 @@
-DPDK_2.0 {
-
-	local: *;
-};
diff --git a/src/drivers/vhost/rte_spp_vhost.c b/src/drivers/vhost/rte_spp_vhost.c
deleted file mode 100644
index fe63064..0000000
--- a/src/drivers/vhost/rte_spp_vhost.c
+++ /dev/null
@@ -1,592 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2016 IGEL Co., Ltd.
- * Copyright(c) 2016-2018 Intel Corporation
- * Copyright(c) 2019 Nippon Telegraph and Telephone Corporation
- */
-#include <unistd.h>
-#include <pthread.h>
-#include <stdbool.h>
-
-#include <rte_mbuf.h>
-#include <rte_ethdev_driver.h>
-#include <rte_ethdev_vdev.h>
-#include <rte_malloc.h>
-#include <rte_memcpy.h>
-#include <rte_bus_vdev.h>
-#include <rte_kvargs.h>
-#include <rte_vhost.h>
-#include <rte_spinlock.h>
-
-static int vhost_logtype;
-
-#define VHOST_LOG(level, ...) \
-	rte_log(RTE_LOG_ ## level, vhost_logtype, __VA_ARGS__)
-
-enum {VIRTIO_RXQ, VIRTIO_TXQ, VIRTIO_QNUM};
-
-#define ETH_VHOST_IFACE_ARG		"iface"
-#define ETH_VHOST_QUEUES_ARG		"queues"
-#define ETH_VHOST_CLIENT_ARG		"client"
-
-static const char *valid_arguments[] = {
-	ETH_VHOST_IFACE_ARG,
-	ETH_VHOST_QUEUES_ARG,
-	ETH_VHOST_CLIENT_ARG,
-	NULL
-};
-
-struct vhost_queue {
-	struct pmd_internal *internal;
-	struct rte_mempool *mb_pool;
-	uint16_t virtqueue_id;
-	rte_spinlock_t queuing_lock;
-	uint64_t pkts;
-	uint64_t missed_pkts;
-};
-
-struct pmd_internal {
-	uint16_t max_queues;
-	uint64_t vhost_flags;
-	struct rte_eth_dev_data *eth_dev_data;
-	int vid;
-	char iface_name[PATH_MAX];
-};
-
-static struct rte_eth_link pmd_link = {
-	.link_speed = 10000,
-	.link_duplex = ETH_LINK_FULL_DUPLEX,
-	.link_status = ETH_LINK_DOWN
-};
-
-#define MZ_RTE_VHOST_PMD_INTERNAL "vhost_pmd_internal"
-static struct pmd_internal **pmd_internal_list;
-
-static uint16_t
-eth_vhost_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
-{
-	struct vhost_queue *r = q;
-	struct pmd_internal *internal;
-	uint16_t nb_rx = 0;
-
-	if (!q)
-		return 0;
-
-	internal = r->internal;
-	rte_spinlock_lock(&r->queuing_lock);
-	if (internal->vid == -1)
-		goto out;
-
-	/* Dequeue packets from guest TX queue */
-	nb_rx = rte_vhost_dequeue_burst(internal->vid, r->virtqueue_id,
-				        r->mb_pool, bufs, nb_bufs);
-	r->pkts += nb_rx;
-
-out:
-	rte_spinlock_unlock(&r->queuing_lock);
-
-	return nb_rx;
-}
-
-static uint16_t
-eth_vhost_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
-{
-	struct vhost_queue *r = q;
-	struct pmd_internal *internal;
-	uint16_t i, nb_tx = 0;
-
-	if (!q)
-		return 0;
-
-	internal = r->internal;
-	rte_spinlock_lock(&r->queuing_lock);
-	if (internal->vid == -1)
-		goto out;
-
-	/* Enqueue packets to guest RX queue */
-	nb_tx = rte_vhost_enqueue_burst(internal->vid, r->virtqueue_id,
-				        bufs, nb_bufs);
-	r->pkts += nb_tx;
-	r->missed_pkts += nb_bufs - nb_tx;
-
-	for (i = 0; i < nb_tx; i++)
-		rte_pktmbuf_free(bufs[i]);
-
-out:
-	rte_spinlock_unlock(&r->queuing_lock);
-
-	return nb_tx;
-}
-
-static inline struct pmd_internal *
-find_internal_resource(int vid)
-{
-	struct pmd_internal *internal;
-	int i;
-	char ifname[PATH_MAX];
-
-	if (rte_vhost_get_ifname(vid, ifname, sizeof(ifname)) == -1)
-		return NULL;
-
-	/* likely(found in a few loops) */
-	for (i = 0; i < RTE_MAX_ETHPORTS; i++) {
-		internal = pmd_internal_list[i];
-		if (internal != NULL && !strcmp(internal->iface_name, ifname)) {
-			return internal;
-		}
-	}
-
-	return NULL;
-}
-
-static int
-new_device(int vid)
-{
-	struct pmd_internal *internal;
-
-	internal = find_internal_resource(vid);
-	if (internal == NULL) {
-		VHOST_LOG(INFO, "Invalid device : %d\n", vid);
-		return -1;
-	}
-
-	internal->vid = vid;
-	internal->eth_dev_data->dev_link.link_status = ETH_LINK_UP;
-
-	VHOST_LOG(INFO, "Vhost device %d created\n", vid);
-
-	return 0;
-}
-
-static void
-destroy_device(int vid)
-{
-	struct pmd_internal *internal;
-	struct vhost_queue *vq;
-	struct rte_eth_dev_data *data;
-	int i;
-
-	internal = find_internal_resource(vid);
-	if (internal == NULL) {
-		VHOST_LOG(ERR, "Invalid device : %d\n", vid);
-		return;
-	}
-	data = internal->eth_dev_data;
-
-	/* wait inflight queuing done */
-	for (i = 0; i < data->nb_rx_queues; i++) {
-		if ((vq = data->rx_queues[i]) != NULL)
-			rte_spinlock_lock(&vq->queuing_lock);
-	}
-	for (i = 0; i < data->nb_tx_queues; i++) {
-		if ((vq = data->tx_queues[i]) != NULL)
-			rte_spinlock_lock(&vq->queuing_lock);
-	}
-
-	data->dev_link.link_status = ETH_LINK_DOWN;
-	internal->vid = -1;
-
-	for (i = 0; i < data->nb_rx_queues; i++) {
-		if ((vq = data->rx_queues[i]) != NULL)
-			rte_spinlock_unlock(&vq->queuing_lock);
-	}
-	for (i = 0; i < data->nb_tx_queues; i++) {
-		if ((vq = data->tx_queues[i]) != NULL)
-			rte_spinlock_unlock(&vq->queuing_lock);
-	}
-
-	VHOST_LOG(INFO, "Vhost device %d destroyed\n", vid);
-}
-
-static struct vhost_device_ops vhost_ops = {
-	.new_device          = new_device,
-	.destroy_device      = destroy_device,
-};
-
-static int
-eth_dev_start(struct rte_eth_dev *eth_dev)
-{
-	struct pmd_internal *internal = eth_dev->data->dev_private;
-
-	if (rte_vhost_driver_register(internal->iface_name, internal->vhost_flags))
-		return -1;
-
-	if (rte_vhost_driver_callback_register(internal->iface_name, &vhost_ops) < 0) {
-		VHOST_LOG(ERR, "Can't register callbacks\n");
-		return -1;
-	}
-
-	if (rte_vhost_driver_start(internal->iface_name) < 0) {
-		VHOST_LOG(ERR, "Failed to start driver for %s\n",
-			internal->iface_name);
-		return -1;
-	}
-
-	return 0;
-}
-
-static void
-eth_dev_stop(struct rte_eth_dev *dev)
-{
-	struct pmd_internal *internal = dev->data->dev_private;
-
-	rte_vhost_driver_unregister(internal->iface_name);
-}
-
-static int
-eth_dev_configure(struct rte_eth_dev *dev __rte_unused)
-{
-	return 0;
-}
-
-static int
-eth_dev_info(struct rte_eth_dev *dev,
-	     struct rte_eth_dev_info *dev_info)
-{
-	struct pmd_internal *internal = dev->data->dev_private;
-
-	dev_info->max_mac_addrs = 1;
-	dev_info->max_rx_pktlen = (uint32_t)-1;
-	dev_info->max_rx_queues = internal->max_queues;
-	dev_info->max_tx_queues = internal->max_queues;
-	dev_info->min_rx_bufsize = 0;
-
-	return 0;
-}
-
-static int
-eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t rx_queue_id,
-		   uint16_t nb_rx_desc __rte_unused,
-		   unsigned int socket_id,
-		   const struct rte_eth_rxconf *rx_conf __rte_unused,
-		   struct rte_mempool *mb_pool)
-{
-	struct pmd_internal *internal = dev->data->dev_private;
-	struct vhost_queue *vq;
-
-	vq = rte_zmalloc_socket(NULL, sizeof(struct vhost_queue),
-			RTE_CACHE_LINE_SIZE, socket_id);
-	if (vq == NULL) {
-		VHOST_LOG(ERR, "Failed to allocate memory for rx queue\n");
-		return -ENOMEM;
-	}
-
-	vq->internal = internal;
-	vq->mb_pool = mb_pool;
-	vq->virtqueue_id = rx_queue_id * VIRTIO_QNUM + VIRTIO_TXQ;
-	rte_spinlock_init(&vq->queuing_lock);
-	dev->data->rx_queues[rx_queue_id] = vq;
-
-	return 0;
-}
-
-static int
-eth_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id,
-		   uint16_t nb_tx_desc __rte_unused,
-		   unsigned int socket_id,
-		   const struct rte_eth_txconf *tx_conf __rte_unused)
-{
-	struct pmd_internal *internal = dev->data->dev_private;
-	struct vhost_queue *vq;
-
-	vq = rte_zmalloc_socket(NULL, sizeof(struct vhost_queue),
-			RTE_CACHE_LINE_SIZE, socket_id);
-	if (vq == NULL) {
-		VHOST_LOG(ERR, "Failed to allocate memory for tx queue\n");
-		return -ENOMEM;
-	}
-
-	vq->internal = internal;
-	vq->virtqueue_id = tx_queue_id * VIRTIO_QNUM + VIRTIO_RXQ;
-	rte_spinlock_init(&vq->queuing_lock);
-	dev->data->tx_queues[tx_queue_id] = vq;
-
-	return 0;
-}
-
-static void
-eth_queue_release(void *q)
-{
-	rte_free(q);
-}
-
-static int
-eth_link_update(struct rte_eth_dev *dev __rte_unused,
-		int wait_to_complete __rte_unused)
-{
-	return 0;
-}
-
-static int
-eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
-{
-	unsigned i;
-	unsigned long rx_total = 0, tx_total = 0, tx_err_total = 0;
-	struct vhost_queue *vq;
-
-	for (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS &&
-			i < dev->data->nb_rx_queues; i++) {
-		if ((vq = dev->data->rx_queues[i]) != NULL) {
-			stats->q_ipackets[i] = vq->pkts;
-			rx_total += vq->pkts;
-		}
-	}
-
-	for (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS &&
-			i < dev->data->nb_tx_queues; i++) {
-		if ((vq = dev->data->rx_queues[i]) != NULL) {
-			stats->q_opackets[i] = vq->pkts;
-			tx_total += vq->pkts;
-			stats->q_errors[i] = vq->missed_pkts;
-			tx_err_total += vq->missed_pkts;
-		}
-	}
-
-	stats->ipackets = rx_total;
-	stats->opackets = tx_total;
-	stats->oerrors = tx_err_total;
-
-	return 0;
-}
-
-static int
-eth_stats_reset(struct rte_eth_dev *dev)
-{
-	struct vhost_queue *vq;
-	unsigned i;
-
-	for (i = 0; i < dev->data->nb_rx_queues; i++) {
-		if ((vq = dev->data->rx_queues[i]) != NULL)
-			vq->pkts = 0;
-	}
-	for (i = 0; i < dev->data->nb_tx_queues; i++) {
-		if ((vq = dev->data->rx_queues[i]) != NULL) {
-			vq->pkts = 0;
-			vq->missed_pkts = 0;
-		}
-	}
-
-	return 0;
-}
-
-static const struct eth_dev_ops ops = {
-	.dev_start = eth_dev_start,
-	.dev_stop = eth_dev_stop,
-	.dev_configure = eth_dev_configure,
-	.dev_infos_get = eth_dev_info,
-	.rx_queue_setup = eth_rx_queue_setup,
-	.tx_queue_setup = eth_tx_queue_setup,
-	.rx_queue_release = eth_queue_release,
-	.tx_queue_release = eth_queue_release,
-	.link_update = eth_link_update,
-	.stats_get = eth_stats_get,
-	.stats_reset = eth_stats_reset,
-};
-
-static int
-init_shared_data(void)
-{
-	const struct rte_memzone *mz;
-
-	if (pmd_internal_list == NULL) {
-		if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
-			size_t len = sizeof(*pmd_internal_list) * RTE_MAX_ETHPORTS;
-			mz = rte_memzone_reserve(MZ_RTE_VHOST_PMD_INTERNAL,
-					len, rte_socket_id(), 0);
-			if (mz)
-				memset(mz->addr, 0, len);
-		} else
-			mz = rte_memzone_lookup(MZ_RTE_VHOST_PMD_INTERNAL);
-		if (mz == NULL) {
-			VHOST_LOG(ERR, "Cannot allocate vhost shared data\n");
-			return -1;
-		}
-		pmd_internal_list = mz->addr;
-	}
-
-	return 0;
-}
-
-static int
-eth_dev_vhost_create(struct rte_vdev_device *dev, char *iface_name,
-	int16_t queues, const unsigned int numa_node, uint64_t flags)
-{
-	struct rte_eth_dev_data *data;
-	struct pmd_internal *internal;
-	struct rte_eth_dev *eth_dev;
-	struct rte_ether_addr *eth_addr;
-
-	VHOST_LOG(INFO, "Creating VHOST-USER backend on numa socket %u\n",
-		numa_node);
-
-	eth_addr = rte_zmalloc_socket(NULL, sizeof(*eth_addr), 0, numa_node);
-	if (eth_addr == NULL)
-		return -ENOMEM;
-
-	eth_dev = rte_eth_vdev_allocate(dev, sizeof(*internal));
-	if (eth_dev == NULL)
-		return -ENOMEM;
-
-	data = eth_dev->data;
-
-	data->dev_link = pmd_link;
-	data->dev_flags = RTE_ETH_DEV_INTR_LSC;
-	data->mac_addrs = eth_addr;
-
-	eth_dev->dev_ops = &ops;
-	eth_dev->rx_pkt_burst = eth_vhost_rx;
-	eth_dev->tx_pkt_burst = eth_vhost_tx;
-
-	internal = data->dev_private;
-
-	internal->max_queues = queues;
-	internal->vid = -1;
-	internal->vhost_flags = flags;
-	internal->eth_dev_data = data;
-	strncpy(internal->iface_name, iface_name, sizeof(internal->iface_name));
-
-	pmd_internal_list[data->port_id] = internal;
-
-	rte_eth_dev_probing_finish(eth_dev);
-
-	return 0;
-}
-
-static inline int
-open_iface(const char *key __rte_unused, const char *value, void *extra_args)
-{
-	const char **iface_name = extra_args;
-
-	if (value == NULL)
-		return -1;
-
-	*iface_name = value;
-
-	return 0;
-}
-
-static inline int
-open_int(const char *key __rte_unused, const char *value, void *extra_args)
-{
-	uint16_t *n = extra_args;
-	char *endptr;
-
-	if (value == NULL)
-		return -1;
-
-	*n = (uint16_t)strtoul(value, &endptr, 0);
-	if (*endptr != '\0' || errno == ERANGE)
-		return -1;
-
-	return 0;
-}
-
-static int
-rte_pmd_vhost_probe(struct rte_vdev_device *dev)
-{
-	struct rte_kvargs *kvlist = NULL;
-	int ret = 0;
-	char *iface_name = NULL;
-	uint16_t queues = 1;
-	uint64_t flags = 0;
-	uint16_t client_mode = 0;
-	struct rte_eth_dev *eth_dev;
-	const char *name = rte_vdev_device_name(dev);
-
-	VHOST_LOG(INFO, "Initializing pmd_vhost for %s\n", name);
-
-	if (init_shared_data() == -1)
-		return -ENOMEM;
-
-	if (rte_eal_process_type() == RTE_PROC_SECONDARY) {
-		eth_dev = rte_eth_dev_attach_secondary(name);
-		if (!eth_dev) {
-			VHOST_LOG(ERR, "Failed to probe %s\n", name);
-			return -ENOENT;
-		}
-		eth_dev->rx_pkt_burst = eth_vhost_rx;
-		eth_dev->tx_pkt_burst = eth_vhost_tx;
-
-		eth_dev->dev_ops = &ops;
-		eth_dev->device = &dev->device;
-		rte_eth_dev_probing_finish(eth_dev);
-		return 0;
-	}
-
-	kvlist = rte_kvargs_parse(rte_vdev_device_args(dev), valid_arguments);
-	if (kvlist == NULL)
-		return -EINVAL;
-
-	if (rte_kvargs_process(kvlist, ETH_VHOST_IFACE_ARG,
-			&open_iface, &iface_name) == -1 ||
-	    rte_kvargs_process(kvlist, ETH_VHOST_QUEUES_ARG,
-			&open_int, &queues) == -1 ||
-	    rte_kvargs_process(kvlist, ETH_VHOST_CLIENT_ARG,
-			&open_int, &client_mode) == -1) {
-		rte_kvargs_free(kvlist);
-		return -EINVAL;
-	}
-
-	if (iface_name == NULL ||
-	    queues == 0 || queues > RTE_MAX_QUEUES_PER_PORT ||
-	    (client_mode != 0 && client_mode != 1)) {
-		rte_kvargs_free(kvlist);
-		return -EINVAL;
-	}
-
-	if (client_mode)
-		flags |= RTE_VHOST_USER_CLIENT;
-
-	ret = eth_dev_vhost_create(dev, iface_name, queues, rte_socket_id(), flags);
-
-	rte_kvargs_free(kvlist);
-	return ret;
-}
-
-static int
-rte_pmd_vhost_remove(struct rte_vdev_device *dev)
-{
-	const char *name = rte_vdev_device_name(dev);
-	struct rte_eth_dev *eth_dev;
-	int i;
-
-	VHOST_LOG(INFO, "Un-Initializing pmd_vhost for %s\n", name);
-
-	eth_dev = rte_eth_dev_allocated(name);
-	if (eth_dev == NULL)
-		return 0;
-
-	if (rte_eal_process_type() != RTE_PROC_PRIMARY)
-		return rte_eth_dev_release_port(eth_dev);
-
-	if (eth_dev->data->dev_started) {
-		VHOST_LOG(WARNING, "device must be stoped.\n");
-	}
-
-	for (i = 0; i < eth_dev->data->nb_rx_queues; i++)
-		rte_free(eth_dev->data->rx_queues[i]);
-
-	for (i = 0; i < eth_dev->data->nb_tx_queues; i++)
-		rte_free(eth_dev->data->tx_queues[i]);
-
-	pmd_internal_list[eth_dev->data->port_id] = NULL;
-
-	return rte_eth_dev_release_port(eth_dev);
-}
-
-static struct rte_vdev_driver pmd_vhost_drv = {
-	.probe = rte_pmd_vhost_probe,
-	.remove = rte_pmd_vhost_remove,
-};
-
-RTE_PMD_REGISTER_VDEV(spp_vhost, pmd_vhost_drv);
-RTE_PMD_REGISTER_PARAM_STRING(spp_vhost,
-	"iface=<ifc> "
-	"queues=<int> "
-	"client=<0|1> ");
-
-RTE_INIT(vhost_init_log)
-{
-	vhost_logtype = rte_log_register("pmd.spp.vhost");
-	if (vhost_logtype >= 0)
-		rte_log_set_level(vhost_logtype, RTE_LOG_NOTICE);
-}
-- 
2.17.0


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [spp] (x-fn-spp-ml 616) [PATCH 00/11] switch to use original vhost PMD again
  2020-04-02  0:06 [spp] [PATCH 00/11] switch to use original vhost PMD again Itsuro Oda
                   ` (10 preceding siblings ...)
  2020-04-02  0:06 ` [spp] [PATCH 11/11] drivers/vhost: remove " Itsuro Oda
@ 2020-04-30  2:39 ` Hideyuki Yamashita
  2020-05-25  3:04 ` [spp] " Yasufumi Ogawa
  12 siblings, 0 replies; 14+ messages in thread
From: Hideyuki Yamashita @ 2020-04-30  2:39 UTC (permalink / raw)
  To: Itsuro Oda; +Cc: spp, ferruh.yigit, yasufum.o

Reviewed-by: Hideyuki Yamashita <yamashita.hideyuki@ntt-tx.co.jp>

> Original vhost PMD was fixed to be used by a secondary process
> in DPDK v20.02.
> This series of patches switch to use original vhost PMD and
> remove SPP dedicated vhost PMD.
> 
> Itsuro Oda (11):
>   shared: switch to use original vhost PMD again
>   spp_nfv: remove unnecessary code for vhost
>   spp_primary: remove unnecessary code for vhost
>   spp_primary: remove link to vhost PMD in Makefile
>   spp_nfv: remove link to vhost PMD in Makefile
>   spp_vf: remove link to vhost PMD in Makefile
>   spp_mirror: remove link to vhost PMD in Makefile
>   spp_pcap: remove link to vhost PMD in Makefile
>   vdev_test: remove link to vhost PMD in Makefile
>   drivers: remove build task for SPP dedicated vhost PMD
>   drivers/vhost: remove SPP dedicated vhost PMD
> 
>  src/drivers/Makefile                          |   1 -
>  src/drivers/vhost/Makefile                    |  28 -
>  .../vhost/rte_pmd_spp_vhost_version.map       |   4 -
>  src/drivers/vhost/rte_spp_vhost.c             | 592 ------------------
>  src/mirror/Makefile                           |   2 +-
>  src/nfv/Makefile                              |   2 +-
>  src/nfv/commands.h                            |   1 -
>  src/pcap/Makefile                             |   2 +-
>  src/primary/Makefile                          |   2 +-
>  src/primary/main.c                            |   1 -
>  src/shared/common.c                           |   4 +-
>  src/shared/common.h                           |   1 -
>  src/shared/secondary/add_port.c               |  15 +-
>  src/shared/secondary/add_port.h               |   2 +-
>  src/vf/Makefile                               |   2 +-
>  tools/vdev_test/Makefile                      |   2 +-
>  16 files changed, 18 insertions(+), 643 deletions(-)
>  delete mode 100644 src/drivers/vhost/Makefile
>  delete mode 100644 src/drivers/vhost/rte_pmd_spp_vhost_version.map
>  delete mode 100644 src/drivers/vhost/rte_spp_vhost.c
> 
> -- 
> 2.17.0



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [spp] [PATCH 00/11] switch to use original vhost PMD again
  2020-04-02  0:06 [spp] [PATCH 00/11] switch to use original vhost PMD again Itsuro Oda
                   ` (11 preceding siblings ...)
  2020-04-30  2:39 ` [spp] (x-fn-spp-ml 616) [PATCH 00/11] switch to use original vhost PMD again Hideyuki Yamashita
@ 2020-05-25  3:04 ` " Yasufumi Ogawa
  12 siblings, 0 replies; 14+ messages in thread
From: Yasufumi Ogawa @ 2020-05-25  3:04 UTC (permalink / raw)
  To: Itsuro Oda, spp

> Original vhost PMD was fixed to be used by a secondary process
> in DPDK v20.02.
> This series of patches switch to use original vhost PMD and
> remove SPP dedicated vhost PMD.
Acked-by: Yasufumi Ogawa <yasufum.o@gmail.com>
> 
> Itsuro Oda (11):
>    shared: switch to use original vhost PMD again
>    spp_nfv: remove unnecessary code for vhost
>    spp_primary: remove unnecessary code for vhost
>    spp_primary: remove link to vhost PMD in Makefile
>    spp_nfv: remove link to vhost PMD in Makefile
>    spp_vf: remove link to vhost PMD in Makefile
>    spp_mirror: remove link to vhost PMD in Makefile
>    spp_pcap: remove link to vhost PMD in Makefile
>    vdev_test: remove link to vhost PMD in Makefile
>    drivers: remove build task for SPP dedicated vhost PMD
>    drivers/vhost: remove SPP dedicated vhost PMD
> 
>   src/drivers/Makefile                          |   1 -
>   src/drivers/vhost/Makefile                    |  28 -
>   .../vhost/rte_pmd_spp_vhost_version.map       |   4 -
>   src/drivers/vhost/rte_spp_vhost.c             | 592 ------------------
>   src/mirror/Makefile                           |   2 +-
>   src/nfv/Makefile                              |   2 +-
>   src/nfv/commands.h                            |   1 -
>   src/pcap/Makefile                             |   2 +-
>   src/primary/Makefile                          |   2 +-
>   src/primary/main.c                            |   1 -
>   src/shared/common.c                           |   4 +-
>   src/shared/common.h                           |   1 -
>   src/shared/secondary/add_port.c               |  15 +-
>   src/shared/secondary/add_port.h               |   2 +-
>   src/vf/Makefile                               |   2 +-
>   tools/vdev_test/Makefile                      |   2 +-
>   16 files changed, 18 insertions(+), 643 deletions(-)
>   delete mode 100644 src/drivers/vhost/Makefile
>   delete mode 100644 src/drivers/vhost/rte_pmd_spp_vhost_version.map
>   delete mode 100644 src/drivers/vhost/rte_spp_vhost.c
> 

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, back to index

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-02  0:06 [spp] [PATCH 00/11] switch to use original vhost PMD again Itsuro Oda
2020-04-02  0:06 ` [spp] [PATCH 01/11] shared: " Itsuro Oda
2020-04-02  0:06 ` [spp] [PATCH 02/11] spp_nfv: remove unnecessary code for vhost Itsuro Oda
2020-04-02  0:06 ` [spp] [PATCH 03/11] spp_primary: " Itsuro Oda
2020-04-02  0:06 ` [spp] [PATCH 04/11] spp_primary: remove link to vhost PMD in Makefile Itsuro Oda
2020-04-02  0:06 ` [spp] [PATCH 05/11] spp_nfv: " Itsuro Oda
2020-04-02  0:06 ` [spp] [PATCH 06/11] spp_vf: " Itsuro Oda
2020-04-02  0:06 ` [spp] [PATCH 07/11] spp_mirror: " Itsuro Oda
2020-04-02  0:06 ` [spp] [PATCH 08/11] spp_pcap: " Itsuro Oda
2020-04-02  0:06 ` [spp] [PATCH 09/11] vdev_test: " Itsuro Oda
2020-04-02  0:06 ` [spp] [PATCH 10/11] drivers: remove build task for SPP dedicated vhost PMD Itsuro Oda
2020-04-02  0:06 ` [spp] [PATCH 11/11] drivers/vhost: remove " Itsuro Oda
2020-04-30  2:39 ` [spp] (x-fn-spp-ml 616) [PATCH 00/11] switch to use original vhost PMD again Hideyuki Yamashita
2020-05-25  3:04 ` [spp] " Yasufumi Ogawa

Soft Patch Panel

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/spp/0 spp/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 spp spp/ http://inbox.dpdk.org/spp \
		spp@dpdk.org
	public-inbox-index spp


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.spp


AGPL code for this site: git clone https://public-inbox.org/ public-inbox