Soft Patch Panel
 help / color / Atom feed
From: Itsuro ODA <oda@valinux.co.jp>
To: Yasufumi Ogawa <yasufum.o@gmail.com>
Cc: spp@dpdk.org
Subject: Re: [spp] [PATCH] tools/sppc: improvement of Dockerfile for SPP container
Date: Thu, 18 Jun 2020 08:19:31 +0900
Message-ID: <20200618081931.A1F4.277DD91C@valinux.co.jp> (raw)
In-Reply-To: <f303721e-f959-b38f-7d4b-c5adbf89761f@gmail.com>

Hi Yasufumi,

The spp_mirror container surely ran with networking-spp k8s
environment.
About the spp_pcap container, it is confirmed to start at
least although detailed test are not done. 

Thanks.
Itsuro Oda

On Tue, 16 Jun 2020 18:33:32 +0900
Yasufumi Ogawa <yasufum.o@gmail.com> wrote:

> > This patch includes some improvements of Dockerfile used by
> > building SPP containers.
> >
> > * remove a nonexistent command path
> > * add some useful command paths
> > * specify a value of 'make -j' option of making DPDK not to
> >    exhaust system resources by compiling processes.
> I totally agree with your changes, but have one thing to be confirmed.
> 
> I remember that I haven't included spp_mirror and spp_pcap in apps in SPP container because I don't have tested well yet. Have you confirmed that these app run on container env?
> 
> >
> > Signed-off-by: Itsuro Oda <oda@valinux.co.jp>
> > ---
> >   tools/sppc/build/ubuntu/spp/Dockerfile.16.04  | 5 +++--
> >   tools/sppc/build/ubuntu/spp/Dockerfile.18.04  | 5 +++--
> >   tools/sppc/build/ubuntu/spp/Dockerfile.latest | 5 +++--
> >   3 files changed, 9 insertions(+), 6 deletions(-)
> >
> > diff --git a/tools/sppc/build/ubuntu/spp/Dockerfile.16.04 b/tools/sppc/build/ubuntu/spp/Dockerfile.16.04
> > index 3e060df..7c81b3a 100644
> > --- a/tools/sppc/build/ubuntu/spp/Dockerfile.16.04
> > +++ b/tools/sppc/build/ubuntu/spp/Dockerfile.16.04
> > @@ -19,7 +19,8 @@ ENV PATH ${rte_sdk}/${rte_target}/app:${PATH}
> >   ENV PATH ${home_dir}/${spp_dir}/src/primary/${rte_target}/:${PATH}
> >   ENV PATH ${home_dir}/${spp_dir}/src/nfv/${rte_target}/:${PATH}
> >   ENV PATH ${home_dir}/${spp_dir}/src/vf/${rte_target}/:${PATH}
> > -ENV PATH ${home_dir}/${spp_dir}/src/vm/${rte_target}/:${PATH}
> > +ENV PATH ${home_dir}/${spp_dir}/src/mirror/${rte_target}/:${PATH}
> > +ENV PATH ${home_dir}/${spp_dir}/src/pcap/${rte_target}/:${PATH}
> >  >   WORKDIR $home_dir
> >   RUN git clone ${dpdk_branch} ${dpdk_repo}
> > @@ -27,7 +28,7 @@ RUN git clone ${spp_branch} ${spp_repo}
> >  >   # Compile DPDK and SPP
> >   WORKDIR ${rte_sdk}
> > -RUN make -j install T=${rte_target}
> > +RUN make -j 4 install T=${rte_target}
> >  >   WORKDIR ${home_dir}/${spp_dir}
> >   RUN make -j
> > diff --git a/tools/sppc/build/ubuntu/spp/Dockerfile.18.04 b/tools/sppc/build/ubuntu/spp/Dockerfile.18.04
> > index e35fbc2..9b90dd4 100644
> > --- a/tools/sppc/build/ubuntu/spp/Dockerfile.18.04
> > +++ b/tools/sppc/build/ubuntu/spp/Dockerfile.18.04
> > @@ -19,7 +19,8 @@ ENV PATH ${rte_sdk}/${rte_target}/app:${PATH}
> >   ENV PATH ${home_dir}/${spp_dir}/src/primary/${rte_target}/:${PATH}
> >   ENV PATH ${home_dir}/${spp_dir}/src/nfv/${rte_target}/:${PATH}
> >   ENV PATH ${home_dir}/${spp_dir}/src/vf/${rte_target}/:${PATH}
> > -ENV PATH ${home_dir}/${spp_dir}/src/vm/${rte_target}/:${PATH}
> > +ENV PATH ${home_dir}/${spp_dir}/src/mirror/${rte_target}/:${PATH}
> > +ENV PATH ${home_dir}/${spp_dir}/src/pcap/${rte_target}/:${PATH}
> >   ENV DEBIAN_FRONTEND noninteractive
> >  >   WORKDIR $home_dir
> > @@ -28,7 +29,7 @@ RUN git clone ${spp_branch} ${spp_repo}
> >  >   # Compile DPDK and SPP
> >   WORKDIR ${rte_sdk}
> > -RUN make -j install T=${rte_target}
> > +RUN make -j 4 install T=${rte_target}
> >  >   WORKDIR ${home_dir}/${spp_dir}
> >   RUN make -j
> > diff --git a/tools/sppc/build/ubuntu/spp/Dockerfile.latest b/tools/sppc/build/ubuntu/spp/Dockerfile.latest
> > index a1ffc80..7e6f5ac 100644
> > --- a/tools/sppc/build/ubuntu/spp/Dockerfile.latest
> > +++ b/tools/sppc/build/ubuntu/spp/Dockerfile.latest
> > @@ -19,7 +19,8 @@ ENV PATH ${rte_sdk}/${rte_target}/app:${PATH}
> >   ENV PATH ${home_dir}/${spp_dir}/src/primary/${rte_target}/:${PATH}
> >   ENV PATH ${home_dir}/${spp_dir}/src/nfv/${rte_target}/:${PATH}
> >   ENV PATH ${home_dir}/${spp_dir}/src/vf/${rte_target}/:${PATH}
> > -ENV PATH ${home_dir}/${spp_dir}/src/vm/${rte_target}/:${PATH}
> > +ENV PATH ${home_dir}/${spp_dir}/src/mirror/${rte_target}/:${PATH}
> > +ENV PATH ${home_dir}/${spp_dir}/src/pcap/${rte_target}/:${PATH}
> >   ENV DEBIAN_FRONTEND noninteractive
> >  >   WORKDIR $home_dir
> > @@ -28,7 +29,7 @@ RUN git clone ${spp_branch} ${spp_repo}
> >  >   # Compile DPDK and SPP
> >   WORKDIR ${rte_sdk}
> > -RUN make -j install T=${rte_target}
> > +RUN make -j 4 install T=${rte_target}
> >  >   WORKDIR ${home_dir}/${spp_dir}
> >   RUN make -j
> > 

-- 
Itsuro ODA <oda@valinux.co.jp>


  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-11 23:31 Itsuro Oda
2020-06-16  9:33 ` Yasufumi Ogawa
2020-06-17 23:19   ` Itsuro ODA [this message]
2020-06-18  2:40 ` Yasufumi Ogawa

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200618081931.A1F4.277DD91C@valinux.co.jp \
    --to=oda@valinux.co.jp \
    --cc=spp@dpdk.org \
    --cc=yasufum.o@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Soft Patch Panel

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/spp/0 spp/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 spp spp/ http://inbox.dpdk.org/spp \
		spp@dpdk.org
	public-inbox-index spp


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.spp


AGPL code for this site: git clone https://public-inbox.org/ public-inbox