* [PATCH] net/netvsc: increase VSP response timeout to 60 seconds
@ 2023-07-26 22:29 longli
2023-09-28 18:01 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: longli @ 2023-07-26 22:29 UTC (permalink / raw)
To: Ferruh Yigit, Andrew Rybchenko; +Cc: dev, Long Li, stable
From: Long Li <longli@microsoft.com>
The current timeout is set to 5 seconds. In Azure, tests show that it may
take up to 15 seconds for VSP to respond on busy nodes. The VSP schedules
unbounded work to process VSC resquest, there is no upper limit on how long
it takes to send response back to VSC.
In the NETVSC kernel mode driver, it waits forever for VSP response. While in
DPDK we can't wait forever, setting the timeout to 60 seconds.
Cc: stable@dpdk.org
Signed-off-by: Long Li <longli@microsoft.com>
---
drivers/net/netvsc/hn_rndis.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/netvsc/hn_rndis.c b/drivers/net/netvsc/hn_rndis.c
index e6f1f28768..7e9abce8d0 100644
--- a/drivers/net/netvsc/hn_rndis.c
+++ b/drivers/net/netvsc/hn_rndis.c
@@ -35,7 +35,7 @@
#include "hn_rndis.h"
#include "ndis.h"
-#define RNDIS_TIMEOUT_SEC 5
+#define RNDIS_TIMEOUT_SEC 60
#define RNDIS_DELAY_MS 10
#define HN_RNDIS_XFER_SIZE 0x4000
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net/netvsc: increase VSP response timeout to 60 seconds
2023-07-26 22:29 [PATCH] net/netvsc: increase VSP response timeout to 60 seconds longli
@ 2023-09-28 18:01 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2023-09-28 18:01 UTC (permalink / raw)
To: longli, Andrew Rybchenko; +Cc: dev, stable
On 7/26/2023 11:29 PM, longli@linuxonhyperv.com wrote:
> From: Long Li <longli@microsoft.com>
>
> The current timeout is set to 5 seconds. In Azure, tests show that it may
> take up to 15 seconds for VSP to respond on busy nodes. The VSP schedules
> unbounded work to process VSC resquest, there is no upper limit on how long
> it takes to send response back to VSC.
>
> In the NETVSC kernel mode driver, it waits forever for VSP response. While in
> DPDK we can't wait forever, setting the timeout to 60 seconds.
>
> Cc: stable@dpdk.org
> Signed-off-by: Long Li <longli@microsoft.com>
>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-28 18:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-26 22:29 [PATCH] net/netvsc: increase VSP response timeout to 60 seconds longli
2023-09-28 18:01 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).