* [dpdk-stable] [PATCH] devtools: fix symbol check when adding experimental section
@ 2019-04-17 10:17 Hemant Agrawal
0 siblings, 0 replies; 4+ messages in thread
From: Hemant Agrawal @ 2019-04-17 10:17 UTC (permalink / raw)
To: hemant.dpdk; +Cc: stable, David Marchand
From: David Marchand <david.marchand@redhat.com>
The incriminated commit did relax the condition to catch all sections
but dropped the + removal which can trigger false detection of the
special EXPERIMENTAL section when adding symbols and the section in the
same patch.
Fixes: 7281cf520f89 ("devtools: relax rule for identifying symbol section")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
---
devtools/check-symbol-change.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
index 4b8d9f3c7..020da7ed0 100755
--- a/devtools/check-symbol-change.sh
+++ b/devtools/check-symbol-change.sh
@@ -31,6 +31,7 @@ build_map_changes()
# Triggering this rule sets in_sec to 1, which actives the
# symbol rule below
/^.*{/ {
+ gsub("+", "");
if (in_map == 1) {
sec=$(NF-1); in_sec=1;
}
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-stable] [PATCH] devtools: fix symbol check when adding experimental section
@ 2018-12-12 13:29 AndyPei
0 siblings, 0 replies; 4+ messages in thread
From: AndyPei @ 2018-12-12 13:29 UTC (permalink / raw)
To: andy.pei; +Cc: David Marchand, stable
From: David Marchand <david.marchand@redhat.com>
The incriminated commit did relax the condition to catch all sections
but dropped the + removal which can trigger false detection of the
special EXPERIMENTAL section when adding symbols and the section in the
same patch.
Fixes: 7281cf520f89 ("devtools: relax rule for identifying symbol section")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
---
devtools/check-symbol-change.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
index 4b8d9f3..020da7e 100755
--- a/devtools/check-symbol-change.sh
+++ b/devtools/check-symbol-change.sh
@@ -31,6 +31,7 @@ build_map_changes()
# Triggering this rule sets in_sec to 1, which actives the
# symbol rule below
/^.*{/ {
+ gsub("+", "");
if (in_map == 1) {
sec=$(NF-1); in_sec=1;
}
--
1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-stable] [PATCH] devtools: fix symbol check when adding experimental section
[not found] <1543978226-23480-1-git-send-email-gfree.wind@vip.163.com>
@ 2018-12-05 2:50 ` gfree.wind
0 siblings, 0 replies; 4+ messages in thread
From: gfree.wind @ 2018-12-05 2:50 UTC (permalink / raw)
To: dev; +Cc: David Marchand, stable
From: David Marchand <david.marchand@redhat.com>
The incriminated commit did relax the condition to catch all sections
but dropped the + removal which can trigger false detection of the
special EXPERIMENTAL section when adding symbols and the section in the
same patch.
Fixes: 7281cf520f89 ("devtools: relax rule for identifying symbol section")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
---
devtools/check-symbol-change.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
index 4b8d9f3..020da7e 100755
--- a/devtools/check-symbol-change.sh
+++ b/devtools/check-symbol-change.sh
@@ -31,6 +31,7 @@ build_map_changes()
# Triggering this rule sets in_sec to 1, which actives the
# symbol rule below
/^.*{/ {
+ gsub("+", "");
if (in_map == 1) {
sec=$(NF-1); in_sec=1;
}
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-stable] [PATCH] devtools: fix symbol check when adding experimental section
[not found] <1543977934-23205-1-git-send-email-gfree.wind@vip.163.com>
@ 2018-12-05 2:45 ` gfree.wind
0 siblings, 0 replies; 4+ messages in thread
From: gfree.wind @ 2018-12-05 2:45 UTC (permalink / raw)
To: davidfgao; +Cc: David Marchand, stable
From: David Marchand <david.marchand@redhat.com>
The incriminated commit did relax the condition to catch all sections
but dropped the + removal which can trigger false detection of the
special EXPERIMENTAL section when adding symbols and the section in the
same patch.
Fixes: 7281cf520f89 ("devtools: relax rule for identifying symbol section")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
---
devtools/check-symbol-change.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
index 4b8d9f3..020da7e 100755
--- a/devtools/check-symbol-change.sh
+++ b/devtools/check-symbol-change.sh
@@ -31,6 +31,7 @@ build_map_changes()
# Triggering this rule sets in_sec to 1, which actives the
# symbol rule below
/^.*{/ {
+ gsub("+", "");
if (in_map == 1) {
sec=$(NF-1); in_sec=1;
}
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-17 10:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-17 10:17 [dpdk-stable] [PATCH] devtools: fix symbol check when adding experimental section Hemant Agrawal
-- strict thread matches above, loose matches on Subject: below --
2018-12-12 13:29 AndyPei
[not found] <1543978226-23480-1-git-send-email-gfree.wind@vip.163.com>
2018-12-05 2:50 ` gfree.wind
[not found] <1543977934-23205-1-git-send-email-gfree.wind@vip.163.com>
2018-12-05 2:45 ` gfree.wind
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).