patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: stable@dpdk.org, marcinx.smoczynski@intel.com,
	konstantin.ananyev@intel.com, ferruh.yigit@intel.com,
	salehals@mellanox.com
Cc: bluca@debian.org, bruce.richardson@intel.com,
	Kevin Traynor <ktraynor@redhat.com>
Subject: [dpdk-stable] [PATCH 18.11 0/1] Enable __BSD_VISIBLE
Date: Wed, 25 Sep 2019 18:12:41 +0100	[thread overview]
Message-ID: <20190925171242.8005-1-ktraynor@redhat.com> (raw)

This backport is needed for 18.11 as the below commit
[Fixes: 54e4657b2385 ("net: define IPv4 IHL and VHL")]
requires that __BSD_VISIBLE is defined for <sys/types.h>
in FreeBSD.

Otherwise, there is a build error on FreeBSD similar to the one
originally reported here
http://inbox.dpdk.org/stable/3d694042-dbe9-7560-5912-d865da048c7c@intel.com/

The other option is to revert the following commits from branch 18.11.

commit d8084ac1f9c74ce9fe61b26c9d4198d872d5fc7e
Author: Saleh Alsouqi <salehals@mellanox.com>
Date:   Thu Jul 4 07:33:22 2019 +0000

    app/testpmd: fix MPLS IPv4 encapsulation fields
    
    [ upstream commit a97ec9ba45d4357c172df71be3fcf601dfdb8147 ]
    
    Having version and ihl set to 0 would result in a
    corrupted/incorrect encapsulating packet for MPLS,
    this commit sets these fields to 4 and 5 respectively
    as defined in librte_net/rte_ip.h.
    
    Fixes: 3e77031be855 ("app/testpmd: add MPLSoGRE encapsulation")
    Fixes: a1191d39cb57 ("app/testpmd: add MPLSoUDP encapsulation")
    
    Signed-off-by: Saleh Alsouqi <salehals@mellanox.com>
    Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

commit 54e4657b238593c633367a2dda48ecf4e04249bb
Author: Saleh Alsouqi <salehals@mellanox.com>
Date:   Thu Jul 4 07:33:19 2019 +0000

    net: define IPv4 IHL and VHL
    
    [ upstream commit 2318d8d5456532e8022d324937a77a416b701d2b ]
    
    Define IPv4 Minimum IHL and VHL according to rfc791 (see [1])
    
        "The Version field indicates the format of the
        internet header."
    
        "Internet Header Length (ihl) is the length of the
        internet header in 32 bit words, and thus points
        to the beginning of the data. Note that
        the minimum value for a correct header is 5."
    
    [1] https://tools.ietf.org/html/rfc791
    
    Signed-off-by: Saleh Alsouqi <salehals@mellanox.com>
    Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Marcin Smoczynski (1):
  build: enable BSD features visibility for FreeBSD

 app/meson.build               | 3 ---
 config/meson.build            | 8 ++++++++
 drivers/meson.build           | 3 ---
 examples/meson.build          | 3 ---
 lib/meson.build               | 3 ---
 meson.build                   | 6 +++++-
 mk/target/generic/rte.vars.mk | 5 +++++
 7 files changed, 18 insertions(+), 13 deletions(-)

-- 
2.20.1


             reply	other threads:[~2019-09-25 17:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-25 17:12 Kevin Traynor [this message]
2019-09-25 17:12 ` [dpdk-stable] [PATCH 18.11 1/1] build: enable BSD features visibility for FreeBSD Kevin Traynor
2019-09-25 18:03   ` Luca Boccassi
2019-09-26  8:19 ` [dpdk-stable] [PATCH 18.11 0/1] Enable __BSD_VISIBLE Richardson, Bruce
2019-09-26 13:19 ` Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190925171242.8005-1-ktraynor@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=bluca@debian.org \
    --cc=bruce.richardson@intel.com \
    --cc=ferruh.yigit@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=marcinx.smoczynski@intel.com \
    --cc=salehals@mellanox.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).