From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
pascal.mazon@6wind.com, stable@dpdk.org
Subject: [dpdk-stable] [PATCH 10/14] tap: close netlink socket on device close
Date: Fri, 3 Jan 2020 17:33:37 -0800 [thread overview]
Message-ID: <20200104013341.19809-11-stephen@networkplumber.org> (raw)
In-Reply-To: <20200104013341.19809-1-stephen@networkplumber.org>
The netlink socket for flow creation was left open and never
closed.
Fixes: bf7b7f437b49 ("net/tap: create netdevice during probing")
Cc: pascal.mazon@6wind.com
Cc: stable@dpdk.org
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/tap/rte_eth_tap.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index a13d8d50d7d7..d293dd8eeed5 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -1035,6 +1035,11 @@ tap_dev_close(struct rte_eth_dev *dev)
&internals->remote_initial_flags);
}
+ if (internals->nlsk_fd != -1) {
+ close(internals->nlsk_fd);
+ internals->nlsk_fd = -1;
+ }
+
if (internals->ka_fd != -1) {
close(internals->ka_fd);
internals->ka_fd = -1;
@@ -2406,7 +2411,7 @@ rte_pmd_tap_remove(struct rte_vdev_device *dev)
TAP_LOG(DEBUG, "Closing %s Ethernet device on numa %u",
tuntap_types[internals->type], rte_socket_id());
- if (internals->nlsk_fd) {
+ if (internals->nlsk_fd != -1) {
tap_flow_flush(eth_dev, NULL);
tap_flow_implicit_flush(internals, NULL);
tap_nl_final(internals->nlsk_fd);
--
2.20.1
next prev parent reply other threads:[~2020-01-04 1:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200104013341.19809-1-stephen@networkplumber.org>
2020-01-04 1:33 ` [dpdk-stable] [PATCH 06/14] eal: mp: end the multiprocess thread during cleanup Stephen Hemminger
2020-04-27 15:37 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly
2020-01-04 1:33 ` [dpdk-stable] [PATCH 08/14] eal: vfio: cleanup the mp sync handle Stephen Hemminger
2020-04-27 12:12 ` Burakov, Anatoly
2020-01-04 1:33 ` Stephen Hemminger [this message]
2020-04-25 15:52 ` [dpdk-stable] [dpdk-dev] [PATCH 10/14] tap: close netlink socket on device close David Marchand
[not found] ` <20200428231415.17985-1-stephen@networkplumber.org>
2020-04-28 23:14 ` [dpdk-stable] [PATCH v2 5/8] eal: mp: end the multiprocess thread during cleanup Stephen Hemminger
2020-04-28 23:14 ` [dpdk-stable] [PATCH v2 6/8] eal: vfio: cleanup the mp sync handle Stephen Hemminger
[not found] ` <20200428235827.15383-1-stephen@networkplumber.org>
2020-04-28 23:58 ` [dpdk-stable] [PATCH v3 5/8] eal: mp: end the multiprocess thread during cleanup Stephen Hemminger
2020-04-28 23:58 ` [dpdk-stable] [PATCH v3 6/8] eal: vfio: cleanup the mp sync handle Stephen Hemminger
[not found] ` <20211113002824.338343-1-stephen@networkplumber.org>
2021-11-13 0:28 ` [PATCH v4 3/5] " Stephen Hemminger
[not found] ` <20211113033209.341027-1-stephen@networkplumber.org>
2021-11-13 3:32 ` [PATCH v5 " Stephen Hemminger
[not found] ` <20211113172257.6543-1-stephen@networkplumber.org>
2021-11-13 17:22 ` [PATCH v6 " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200104013341.19809-11-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=pascal.mazon@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).