From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
anatoly.burakov@intel.com, stable@dpdk.org
Subject: [PATCH v4 3/5] eal: vfio: cleanup the mp sync handle
Date: Fri, 12 Nov 2021 16:28:22 -0800 [thread overview]
Message-ID: <20211113002824.338343-4-stephen@networkplumber.org> (raw)
In-Reply-To: <20211113002824.338343-1-stephen@networkplumber.org>
When rte_eal_cleanup is called the rte_mp_action for VFIO
should be freed.
Fixes: edf73dd33072 ("ipc: handle unsupported IPC in action register")
Cc: anatoly.burakov@intel.com
Cc: stable@dpdk.org
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
lib/eal/linux/eal.c | 4 ++++
lib/eal/linux/eal_vfio.h | 1 +
lib/eal/linux/eal_vfio_mp_sync.c | 8 ++++++++
3 files changed, 13 insertions(+)
diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c
index b67030b2792e..ad8f130b509d 100644
--- a/lib/eal/linux/eal.c
+++ b/lib/eal/linux/eal.c
@@ -1362,7 +1362,11 @@ rte_eal_cleanup(void)
if (rte_eal_process_type() == RTE_PROC_PRIMARY)
rte_memseg_walk(mark_freeable, NULL);
+
rte_service_finalize();
+#ifdef VFIO_PRESENT
+ vfio_mp_sync_cleanup();
+#endif
rte_mp_channel_cleanup();
/* after this point, any DPDK pointers will become dangling */
rte_eal_memory_detach();
diff --git a/lib/eal/linux/eal_vfio.h b/lib/eal/linux/eal_vfio.h
index 6ebaca6a0cbf..921ee595388c 100644
--- a/lib/eal/linux/eal_vfio.h
+++ b/lib/eal/linux/eal_vfio.h
@@ -133,6 +133,7 @@ int
vfio_has_supported_extensions(int vfio_container_fd);
int vfio_mp_sync_setup(void);
+void vfio_mp_sync_cleanup(void);
#define EAL_VFIO_MP "eal_vfio_mp_sync"
diff --git a/lib/eal/linux/eal_vfio_mp_sync.c b/lib/eal/linux/eal_vfio_mp_sync.c
index a2accfab3a38..d12bbaee648b 100644
--- a/lib/eal/linux/eal_vfio_mp_sync.c
+++ b/lib/eal/linux/eal_vfio_mp_sync.c
@@ -120,4 +120,12 @@ vfio_mp_sync_setup(void)
return 0;
}
+void
+vfio_mp_sync_cleanup(void)
+{
+ if (rte_eal_process_type() != RTE_PROC_PRIMARY)
+ return;
+
+ rte_mp_action_unregister(EAL_VFIO_MP);
+}
#endif
--
2.30.2
next prev parent reply other threads:[~2021-11-13 0:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200104013341.19809-1-stephen@networkplumber.org>
2020-01-04 1:33 ` [dpdk-stable] [PATCH 06/14] eal: mp: end the multiprocess thread during cleanup Stephen Hemminger
2020-04-27 15:37 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly
2020-01-04 1:33 ` [dpdk-stable] [PATCH 08/14] eal: vfio: cleanup the mp sync handle Stephen Hemminger
2020-04-27 12:12 ` Burakov, Anatoly
2020-01-04 1:33 ` [dpdk-stable] [PATCH 10/14] tap: close netlink socket on device close Stephen Hemminger
2020-04-25 15:52 ` [dpdk-stable] [dpdk-dev] " David Marchand
[not found] ` <20200428231415.17985-1-stephen@networkplumber.org>
2020-04-28 23:14 ` [dpdk-stable] [PATCH v2 5/8] eal: mp: end the multiprocess thread during cleanup Stephen Hemminger
2020-04-28 23:14 ` [dpdk-stable] [PATCH v2 6/8] eal: vfio: cleanup the mp sync handle Stephen Hemminger
[not found] ` <20200428235827.15383-1-stephen@networkplumber.org>
2020-04-28 23:58 ` [dpdk-stable] [PATCH v3 5/8] eal: mp: end the multiprocess thread during cleanup Stephen Hemminger
2020-04-28 23:58 ` [dpdk-stable] [PATCH v3 6/8] eal: vfio: cleanup the mp sync handle Stephen Hemminger
[not found] ` <20211113002824.338343-1-stephen@networkplumber.org>
2021-11-13 0:28 ` Stephen Hemminger [this message]
[not found] ` <20211113033209.341027-1-stephen@networkplumber.org>
2021-11-13 3:32 ` [PATCH v5 3/5] " Stephen Hemminger
[not found] ` <20211113172257.6543-1-stephen@networkplumber.org>
2021-11-13 17:22 ` [PATCH v6 " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211113002824.338343-4-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).