patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Nithin Dabilpuram <ndabilpuram@marvell.com>
To: <thomas@monjalon.net>, <david.marchand@redhat.com>,
	Neil Horman <nhorman@tuxdriver.com>
Cc: <dev@dpdk.org>, <jerinj@marvell.com>, <bingz@mellanox.com>,
	"Nithin Dabilpuram" <ndabilpuram@marvell.com>, <stable@dpdk.org>
Subject: [dpdk-stable] [PATCH v2] devtools: fix check symbol change script
Date: Mon, 23 Mar 2020 17:26:13 +0530	[thread overview]
Message-ID: <20200323115613.29677-1-ndabilpuram@marvell.com> (raw)
In-Reply-To: <20200319144418.15661-1-ndabilpuram@marvell.com>

Fix check symbol change script to detect new diff file when
it is in between  "--- /dev/null" to "b/lib/...".
Current awk line expects line to start with "a/..."
which is not always true for all diffs.
As a result if in_map was '1' earlier, it will not be changed
to '0' and we get check patch errors which are not true.

Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition")
Cc: nhorman@tuxdriver.com
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Tested-by: Jerin Jacob <jerinj@marvell.com>
---

v2:
- Updated logic from David to fix "not map" check 

 devtools/check-symbol-change.sh | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
index c5434f3..ed2178e 100755
--- a/devtools/check-symbol-change.sh
+++ b/devtools/check-symbol-change.sh
@@ -17,13 +17,11 @@ build_map_changes()
 		# map files are altered, and all section/symbol names
 		# appearing between a triggering of this rule and the
 		# next trigger of this rule are associated with this file
-		/[-+] a\/.*\.map/ {map=$2; in_map=1}
+		/[-+] [ab]\/.*\.map/ {map=$2; in_map=1; next}
 
-		# Same pattern as above, only it matches on anything that
-		# does not end in 'map', indicating we have left the map chunk.
-		# When we hit this, turn off the in_map variable, which
-		# supresses the subordonate rules below
-		/[-+] a\/.*\.[^map]/ {in_map=0}
+		# The previous rule catches all .map files, anything else
+		# indicates we left the map chunk.
+		/[-+] [ab]\// {in_map=0}
 
 		# Triggering this rule, which starts a line and ends it
 		# with a { identifies a versioned section.  The section name is
-- 
2.8.4


  parent reply	other threads:[~2020-03-23 11:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-19 14:44 [dpdk-stable] [PATCH] " Nithin Dabilpuram
2020-03-19 14:56 ` David Marchand
2020-03-19 15:40   ` Neil Horman
2020-03-19 15:45     ` [dpdk-stable] [EXT] " Nithin Dabilpuram
2020-03-19 18:59       ` Neil Horman
2020-03-19 15:49     ` [dpdk-stable] " Bing Zhao
2020-03-22 14:37 ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
2020-03-23  8:13 ` [dpdk-stable] " David Marchand
2020-03-23  9:28   ` [dpdk-stable] [EXT] " Nithin Dabilpuram
2020-03-23  9:30     ` David Marchand
2020-03-23 11:56 ` Nithin Dabilpuram [this message]
2020-03-23 13:19   ` [dpdk-stable] [PATCH v2] " David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200323115613.29677-1-ndabilpuram@marvell.com \
    --to=ndabilpuram@marvell.com \
    --cc=bingz@mellanox.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=nhorman@tuxdriver.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).