From: Haiyue Wang <haiyue.wang@intel.com> To: dev@dpdk.org Cc: ferruh.yigit@intel.com, qi.z.zhang@intel.com, Haiyue Wang <haiyue.wang@intel.com>, stable@dpdk.org, Jeff Guo <jia.guo@intel.com>, Wei Zhao <wei.zhao1@intel.com>, Beilei Xing <beilei.xing@intel.com>, Wei Dai <wei.dai@intel.com>, Wenzhuo Lu <wenzhuo.lu@intel.com> Subject: [dpdk-stable] [PATCH v1] net/ixgbe: remove the redundant MAC flag check Date: Thu, 12 Nov 2020 10:00:06 +0800 Message-ID: <20201112020006.739838-1-haiyue.wang@intel.com> (raw) The flag of RTE_ETHTYPE_FLAGS_MAC has been checked twice, so remove the first error message "Not supported by ethertype filter" which is not so specific, and keep the error message "mac compare is unsupported" which aligns to the definition of RTE_ETHTYPE_FLAGS_MAC. Fixes: eb3539fc8550 ("net/ixgbe: parse ethertype filter") Cc: stable@dpdk.org Signed-off-by: Haiyue Wang <haiyue.wang@intel.com> --- drivers/net/ixgbe/ixgbe_flow.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c index dff04c462c..39f6ed73f6 100644 --- a/drivers/net/ixgbe/ixgbe_flow.c +++ b/drivers/net/ixgbe/ixgbe_flow.c @@ -870,15 +870,6 @@ ixgbe_parse_ethertype_filter(struct rte_eth_dev *dev, if (ret) return ret; - /* Ixgbe doesn't support MAC address. */ - if (filter->flags & RTE_ETHTYPE_FLAGS_MAC) { - memset(filter, 0, sizeof(struct rte_eth_ethertype_filter)); - rte_flow_error_set(error, EINVAL, - RTE_FLOW_ERROR_TYPE_ITEM, - NULL, "Not supported by ethertype filter"); - return -rte_errno; - } - if (filter->queue >= dev->data->nb_rx_queues) { memset(filter, 0, sizeof(struct rte_eth_ethertype_filter)); rte_flow_error_set(error, EINVAL, -- 2.29.2
next reply other threads:[~2020-11-12 2:14 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-12 2:00 Haiyue Wang [this message] 2020-11-12 23:49 ` Zhang, Qi Z
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201112020006.739838-1-haiyue.wang@intel.com \ --to=haiyue.wang@intel.com \ --cc=beilei.xing@intel.com \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=jia.guo@intel.com \ --cc=qi.z.zhang@intel.com \ --cc=stable@dpdk.org \ --cc=wei.dai@intel.com \ --cc=wei.zhao1@intel.com \ --cc=wenzhuo.lu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/public-inbox.git