* [dpdk-stable] [PATCH 01/10] examples/fips_validation: fix build with pkg-config [not found] <20201110151219.4893-1-david.marchand@redhat.com> @ 2020-11-10 15:12 ` David Marchand 2020-11-10 15:12 ` [dpdk-stable] [PATCH 02/10] examples/ipsec-gw: " David Marchand ` (5 subsequent siblings) 6 siblings, 0 replies; 19+ messages in thread From: David Marchand @ 2020-11-10 15:12 UTC (permalink / raw) To: dev Cc: thomas, bruce.richardson, stable, Marko Kovacevic, Akhil Goyal, Fiona Trahe, Fan Zhang When this example started using rte_cryptodev_sym_session_pool_create, the part for pkg-config builds was not updated. Fixes: 261bbff75e34 ("examples: use separate crypto session mempools") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com> --- examples/fips_validation/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/fips_validation/Makefile b/examples/fips_validation/Makefile index 7ba9bcfea6..8f82a4c6c5 100644 --- a/examples/fips_validation/Makefile +++ b/examples/fips_validation/Makefile @@ -36,6 +36,8 @@ CFLAGS += -O3 $(shell $(PKGCONF) --cflags libdpdk) LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk) LDFLAGS_STATIC = $(shell $(PKGCONF) --static --libs libdpdk) +CFLAGS += -DALLOW_EXPERIMENTAL_API + build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build $(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED) -- 2.23.0 ^ permalink raw reply [flat|nested] 19+ messages in thread
* [dpdk-stable] [PATCH 02/10] examples/ipsec-gw: fix build with pkg-config [not found] <20201110151219.4893-1-david.marchand@redhat.com> 2020-11-10 15:12 ` [dpdk-stable] [PATCH 01/10] examples/fips_validation: fix build with pkg-config David Marchand @ 2020-11-10 15:12 ` David Marchand 2020-11-10 15:12 ` [dpdk-stable] [PATCH 03/10] examples/kni: " David Marchand ` (4 subsequent siblings) 6 siblings, 0 replies; 19+ messages in thread From: David Marchand @ 2020-11-10 15:12 UTC (permalink / raw) To: dev Cc: thomas, bruce.richardson, stable, Radu Nicolau, Akhil Goyal, Anoob Joseph flow.c: In function ‘parse_flow_tokens’: flow.c:153:23: error: taking address of packed member of ‘struct rte_ipv4_hdr’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 153 | if (ipv4_addr_cpy(&rule->ipv4.spec.hdr.src_addr, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ flow.c:154:9: error: taking address of packed member of ‘struct rte_ipv4_hdr’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 154 | &rule->ipv4.mask.hdr.src_addr, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ flow.c:170:23: error: taking address of packed member of ‘struct rte_ipv4_hdr’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 170 | if (ipv4_addr_cpy(&rule->ipv4.spec.hdr.dst_addr, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ flow.c:171:9: error: taking address of packed member of ‘struct rte_ipv4_hdr’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 171 | &rule->ipv4.mask.hdr.dst_addr, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors Meson build is fine since we waive those warnings. Replicate it for make. Fixes: 8e693616fcb2 ("examples/ipsec-secgw: enable flow based distribution") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com> --- examples/ipsec-secgw/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/ipsec-secgw/Makefile b/examples/ipsec-secgw/Makefile index 5e6cb51eac..7670cc3684 100644 --- a/examples/ipsec-secgw/Makefile +++ b/examples/ipsec-secgw/Makefile @@ -42,6 +42,7 @@ LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk) LDFLAGS_STATIC = $(shell $(PKGCONF) --static --libs libdpdk) CFLAGS += -DALLOW_EXPERIMENTAL_API +CFLAGS += -Wno-address-of-packed-member build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build $(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED) -- 2.23.0 ^ permalink raw reply [flat|nested] 19+ messages in thread
* [dpdk-stable] [PATCH 03/10] examples/kni: fix build with pkg-config [not found] <20201110151219.4893-1-david.marchand@redhat.com> 2020-11-10 15:12 ` [dpdk-stable] [PATCH 01/10] examples/fips_validation: fix build with pkg-config David Marchand 2020-11-10 15:12 ` [dpdk-stable] [PATCH 02/10] examples/ipsec-gw: " David Marchand @ 2020-11-10 15:12 ` David Marchand 2020-11-10 15:12 ` [dpdk-stable] [PATCH 06/10] examples/ntb: fix clean target David Marchand ` (3 subsequent siblings) 6 siblings, 0 replies; 19+ messages in thread From: David Marchand @ 2020-11-10 15:12 UTC (permalink / raw) To: dev; +Cc: thomas, bruce.richardson, stable, Ferruh Yigit, Dan Gora rm -f build/kni build/kni-static build/kni-shared test -d build && rmdir -p build || true [...] /usr/bin/ld: /tmp/cc72ssnK.o: undefined reference to symbol 'pthread_join@@GLIBC_2.2.5' This example explicitly call pthread API and should be linked against the pthread library. Fixes: 724beb913b44 ("examples/kni: monitor and update link state continually") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com> --- examples/kni/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/kni/Makefile b/examples/kni/Makefile index fa9fa85319..bdc8a2aabe 100644 --- a/examples/kni/Makefile +++ b/examples/kni/Makefile @@ -24,6 +24,7 @@ PKGCONF ?= pkg-config PC_FILE := $(shell $(PKGCONF) --path libdpdk 2>/dev/null) CFLAGS += -O3 $(shell $(PKGCONF) --cflags libdpdk) CFLAGS += -DALLOW_EXPERIMENTAL_API +LDFLAGS += -pthread LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk) LDFLAGS_STATIC = $(shell $(PKGCONF) --static --libs libdpdk) -- 2.23.0 ^ permalink raw reply [flat|nested] 19+ messages in thread
* [dpdk-stable] [PATCH 06/10] examples/ntb: fix clean target [not found] <20201110151219.4893-1-david.marchand@redhat.com> ` (2 preceding siblings ...) 2020-11-10 15:12 ` [dpdk-stable] [PATCH 03/10] examples/kni: " David Marchand @ 2020-11-10 15:12 ` David Marchand 2020-11-12 1:30 ` Li, Xiaoyun 2020-11-10 15:12 ` [dpdk-stable] [PATCH 08/10] examples/rxtx_callbacks: fix build with pkg-config David Marchand ` (2 subsequent siblings) 6 siblings, 1 reply; 19+ messages in thread From: David Marchand @ 2020-11-10 15:12 UTC (permalink / raw) To: dev Cc: thomas, bruce.richardson, stable, Xiaoyun Li, Jingjing Wu, Xiaolong Ye When introducing this example, the cleanup from commit 7e9562a107f1 ("examples: fix make clean when using pkg-config") was missed. Fixes: c5eebf85badc ("examples/ntb: add example for NTB") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com> --- examples/ntb/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/ntb/Makefile b/examples/ntb/Makefile index 4675570fd2..d35dabc471 100644 --- a/examples/ntb/Makefile +++ b/examples/ntb/Makefile @@ -42,4 +42,4 @@ build: .PHONY: clean clean: rm -f build/$(APP) build/$(APP)-static build/$(APP)-shared - rmdir --ignore-fail-on-non-empty build + test -d build && rmdir -p build || true -- 2.23.0 ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [dpdk-stable] [PATCH 06/10] examples/ntb: fix clean target 2020-11-10 15:12 ` [dpdk-stable] [PATCH 06/10] examples/ntb: fix clean target David Marchand @ 2020-11-12 1:30 ` Li, Xiaoyun 0 siblings, 0 replies; 19+ messages in thread From: Li, Xiaoyun @ 2020-11-12 1:30 UTC (permalink / raw) To: David Marchand, dev Cc: thomas, Richardson, Bruce, stable, Wu, Jingjing, Xiaolong Ye > -----Original Message----- > From: David Marchand <david.marchand@redhat.com> > Sent: Tuesday, November 10, 2020 23:12 > To: dev@dpdk.org > Cc: thomas@monjalon.net; Richardson, Bruce <bruce.richardson@intel.com>; > stable@dpdk.org; Li, Xiaoyun <xiaoyun.li@intel.com>; Wu, Jingjing > <jingjing.wu@intel.com>; Xiaolong Ye <xiaolong.ye@intel.com> > Subject: [PATCH 06/10] examples/ntb: fix clean target > > When introducing this example, the cleanup from commit 7e9562a107f1 > ("examples: fix make clean when using pkg-config") was missed. > > Fixes: c5eebf85badc ("examples/ntb: add example for NTB") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand <david.marchand@redhat.com> > --- > examples/ntb/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/examples/ntb/Makefile b/examples/ntb/Makefile index > 4675570fd2..d35dabc471 100644 > --- a/examples/ntb/Makefile > +++ b/examples/ntb/Makefile > @@ -42,4 +42,4 @@ build: > .PHONY: clean > clean: > rm -f build/$(APP) build/$(APP)-static build/$(APP)-shared > - rmdir --ignore-fail-on-non-empty build > + test -d build && rmdir -p build || true > -- > 2.23.0 Thanks for the catch. Acked-by: Xiaoyun Li <xiaoyun.li@intel.com> ^ permalink raw reply [flat|nested] 19+ messages in thread
* [dpdk-stable] [PATCH 08/10] examples/rxtx_callbacks: fix build with pkg-config [not found] <20201110151219.4893-1-david.marchand@redhat.com> ` (3 preceding siblings ...) 2020-11-10 15:12 ` [dpdk-stable] [PATCH 06/10] examples/ntb: fix clean target David Marchand @ 2020-11-10 15:12 ` David Marchand [not found] ` <20201113122430.25354-1-david.marchand@redhat.com> [not found] ` <20201114090533.6059-1-david.marchand@redhat.com> 6 siblings, 0 replies; 19+ messages in thread From: David Marchand @ 2020-11-10 15:12 UTC (permalink / raw) To: dev Cc: thomas, bruce.richardson, stable, John McNamara, Ferruh Yigit, Tom Barbette This example is missing the experimental flag since it uses an experimental API. Fixes: cd1dadeb9b2a ("examples/rxtx_callbacks: support HW timestamp") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com> --- examples/rxtx_callbacks/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/rxtx_callbacks/Makefile b/examples/rxtx_callbacks/Makefile index bac3015d34..a618cdf751 100644 --- a/examples/rxtx_callbacks/Makefile +++ b/examples/rxtx_callbacks/Makefile @@ -26,6 +26,8 @@ CFLAGS += -O3 $(shell $(PKGCONF) --cflags libdpdk) LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk) LDFLAGS_STATIC = $(shell $(PKGCONF) --static --libs libdpdk) +CFLAGS += -DALLOW_EXPERIMENTAL_API + build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build $(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED) -- 2.23.0 ^ permalink raw reply [flat|nested] 19+ messages in thread
[parent not found: <20201113122430.25354-1-david.marchand@redhat.com>]
* [dpdk-stable] [PATCH v2 01/11] examples/fips_validation: fix build with pkg-config [not found] ` <20201113122430.25354-1-david.marchand@redhat.com> @ 2020-11-13 12:24 ` David Marchand 2020-11-13 12:24 ` [dpdk-stable] [PATCH v2 02/11] examples/ipsec-gw: " David Marchand ` (4 subsequent siblings) 5 siblings, 0 replies; 19+ messages in thread From: David Marchand @ 2020-11-13 12:24 UTC (permalink / raw) To: dev Cc: thomas, bruce.richardson, stable, Marko Kovacevic, Akhil Goyal, Fiona Trahe, Fan Zhang When this example started using rte_cryptodev_sym_session_pool_create, the part for pkg-config builds was not updated. Fixes: 261bbff75e34 ("examples: use separate crypto session mempools") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com> --- examples/fips_validation/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/fips_validation/Makefile b/examples/fips_validation/Makefile index 7ba9bcfea6..8f82a4c6c5 100644 --- a/examples/fips_validation/Makefile +++ b/examples/fips_validation/Makefile @@ -36,6 +36,8 @@ CFLAGS += -O3 $(shell $(PKGCONF) --cflags libdpdk) LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk) LDFLAGS_STATIC = $(shell $(PKGCONF) --static --libs libdpdk) +CFLAGS += -DALLOW_EXPERIMENTAL_API + build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build $(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED) -- 2.23.0 ^ permalink raw reply [flat|nested] 19+ messages in thread
* [dpdk-stable] [PATCH v2 02/11] examples/ipsec-gw: fix build with pkg-config [not found] ` <20201113122430.25354-1-david.marchand@redhat.com> 2020-11-13 12:24 ` [dpdk-stable] [PATCH v2 01/11] examples/fips_validation: " David Marchand @ 2020-11-13 12:24 ` David Marchand 2020-11-16 4:16 ` [dpdk-stable] [EXT] " Anoob Joseph 2020-11-13 12:24 ` [dpdk-stable] [PATCH v2 03/11] examples/kni: " David Marchand ` (3 subsequent siblings) 5 siblings, 1 reply; 19+ messages in thread From: David Marchand @ 2020-11-13 12:24 UTC (permalink / raw) To: dev Cc: thomas, bruce.richardson, stable, Radu Nicolau, Akhil Goyal, Anoob Joseph flow.c: In function ‘parse_flow_tokens’: flow.c:153:23: error: taking address of packed member of ‘struct rte_ipv4_hdr’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 153 | if (ipv4_addr_cpy(&rule->ipv4.spec.hdr.src_addr, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ flow.c:154:9: error: taking address of packed member of ‘struct rte_ipv4_hdr’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 154 | &rule->ipv4.mask.hdr.src_addr, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ flow.c:170:23: error: taking address of packed member of ‘struct rte_ipv4_hdr’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 170 | if (ipv4_addr_cpy(&rule->ipv4.spec.hdr.dst_addr, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ flow.c:171:9: error: taking address of packed member of ‘struct rte_ipv4_hdr’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 171 | &rule->ipv4.mask.hdr.dst_addr, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors Meson build is fine since we waive those warnings. Replicate it for make. Fixes: 8e693616fcb2 ("examples/ipsec-secgw: enable flow based distribution") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com> --- examples/ipsec-secgw/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/ipsec-secgw/Makefile b/examples/ipsec-secgw/Makefile index 5e6cb51eac..7670cc3684 100644 --- a/examples/ipsec-secgw/Makefile +++ b/examples/ipsec-secgw/Makefile @@ -42,6 +42,7 @@ LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk) LDFLAGS_STATIC = $(shell $(PKGCONF) --static --libs libdpdk) CFLAGS += -DALLOW_EXPERIMENTAL_API +CFLAGS += -Wno-address-of-packed-member build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build $(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED) -- 2.23.0 ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [dpdk-stable] [EXT] [PATCH v2 02/11] examples/ipsec-gw: fix build with pkg-config 2020-11-13 12:24 ` [dpdk-stable] [PATCH v2 02/11] examples/ipsec-gw: " David Marchand @ 2020-11-16 4:16 ` Anoob Joseph 0 siblings, 0 replies; 19+ messages in thread From: Anoob Joseph @ 2020-11-16 4:16 UTC (permalink / raw) To: David Marchand, dev Cc: thomas, bruce.richardson, stable, Radu Nicolau, Akhil Goyal > flow.c: In function ‘parse_flow_tokens’: > flow.c:153:23: error: taking address of packed member of ‘struct > rte_ipv4_hdr’ may result in an unaligned pointer value [-Werror=address-of- > packed-member] > 153 | if (ipv4_addr_cpy(&rule->ipv4.spec.hdr.src_addr, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > flow.c:154:9: error: taking address of packed member of ‘struct rte_ipv4_hdr’ > may result in an unaligned pointer value [-Werror=address-of-packed- > member] > 154 | &rule->ipv4.mask.hdr.src_addr, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > flow.c:170:23: error: taking address of packed member of ‘struct > rte_ipv4_hdr’ may result in an unaligned pointer value [-Werror=address-of- > packed-member] > 170 | if (ipv4_addr_cpy(&rule->ipv4.spec.hdr.dst_addr, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > flow.c:171:9: error: taking address of packed member of ‘struct rte_ipv4_hdr’ > may result in an unaligned pointer value [-Werror=address-of-packed- > member] > 171 | &rule->ipv4.mask.hdr.dst_addr, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > > Meson build is fine since we waive those warnings. > Replicate it for make. > > Fixes: 8e693616fcb2 ("examples/ipsec-secgw: enable flow based > distribution") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand <david.marchand@redhat.com> > Acked-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: Anoob Joseph <anoobj@marvell.com> ^ permalink raw reply [flat|nested] 19+ messages in thread
* [dpdk-stable] [PATCH v2 03/11] examples/kni: fix build with pkg-config [not found] ` <20201113122430.25354-1-david.marchand@redhat.com> 2020-11-13 12:24 ` [dpdk-stable] [PATCH v2 01/11] examples/fips_validation: " David Marchand 2020-11-13 12:24 ` [dpdk-stable] [PATCH v2 02/11] examples/ipsec-gw: " David Marchand @ 2020-11-13 12:24 ` David Marchand 2020-11-13 12:24 ` [dpdk-stable] [PATCH v2 06/11] examples/ntb: fix clean target David Marchand ` (2 subsequent siblings) 5 siblings, 0 replies; 19+ messages in thread From: David Marchand @ 2020-11-13 12:24 UTC (permalink / raw) To: dev; +Cc: thomas, bruce.richardson, stable, Ferruh Yigit, Dan Gora rm -f build/kni build/kni-static build/kni-shared test -d build && rmdir -p build || true [...] /usr/bin/ld: /tmp/cc72ssnK.o: undefined reference to symbol 'pthread_join@@GLIBC_2.2.5' This example explicitly call pthread API and should be linked against the pthread library. Fixes: 724beb913b44 ("examples/kni: monitor and update link state continually") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com> --- examples/kni/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/kni/Makefile b/examples/kni/Makefile index fa9fa85319..bdc8a2aabe 100644 --- a/examples/kni/Makefile +++ b/examples/kni/Makefile @@ -24,6 +24,7 @@ PKGCONF ?= pkg-config PC_FILE := $(shell $(PKGCONF) --path libdpdk 2>/dev/null) CFLAGS += -O3 $(shell $(PKGCONF) --cflags libdpdk) CFLAGS += -DALLOW_EXPERIMENTAL_API +LDFLAGS += -pthread LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk) LDFLAGS_STATIC = $(shell $(PKGCONF) --static --libs libdpdk) -- 2.23.0 ^ permalink raw reply [flat|nested] 19+ messages in thread
* [dpdk-stable] [PATCH v2 06/11] examples/ntb: fix clean target [not found] ` <20201113122430.25354-1-david.marchand@redhat.com> ` (2 preceding siblings ...) 2020-11-13 12:24 ` [dpdk-stable] [PATCH v2 03/11] examples/kni: " David Marchand @ 2020-11-13 12:24 ` David Marchand 2020-11-13 12:24 ` [dpdk-stable] [PATCH v2 07/11] examples/performance-thread: fix build with pkg-config David Marchand 2020-11-13 12:24 ` [dpdk-stable] [PATCH v2 09/11] examples/rxtx_callbacks: " David Marchand 5 siblings, 0 replies; 19+ messages in thread From: David Marchand @ 2020-11-13 12:24 UTC (permalink / raw) To: dev Cc: thomas, bruce.richardson, stable, Xiaoyun Li, Jingjing Wu, Xiaolong Ye When introducing this example, the cleanup from commit 7e9562a107f1 ("examples: fix make clean when using pkg-config") was missed. Fixes: c5eebf85badc ("examples/ntb: add example for NTB") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: Xiaoyun Li <xiaoyun.li@intel.com> --- examples/ntb/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/ntb/Makefile b/examples/ntb/Makefile index 4675570fd2..d35dabc471 100644 --- a/examples/ntb/Makefile +++ b/examples/ntb/Makefile @@ -42,4 +42,4 @@ build: .PHONY: clean clean: rm -f build/$(APP) build/$(APP)-static build/$(APP)-shared - rmdir --ignore-fail-on-non-empty build + test -d build && rmdir -p build || true -- 2.23.0 ^ permalink raw reply [flat|nested] 19+ messages in thread
* [dpdk-stable] [PATCH v2 07/11] examples/performance-thread: fix build with pkg-config [not found] ` <20201113122430.25354-1-david.marchand@redhat.com> ` (3 preceding siblings ...) 2020-11-13 12:24 ` [dpdk-stable] [PATCH v2 06/11] examples/ntb: fix clean target David Marchand @ 2020-11-13 12:24 ` David Marchand 2020-11-13 12:24 ` [dpdk-stable] [PATCH v2 09/11] examples/rxtx_callbacks: " David Marchand 5 siblings, 0 replies; 19+ messages in thread From: David Marchand @ 2020-11-13 12:24 UTC (permalink / raw) To: dev Cc: thomas, bruce.richardson, stable, John McNamara, Tomasz Kulasek, Ian Betts main.c: In function ‘lthread_tx’: main.c:2091:25: error: implicit declaration of function ‘sched_getcpu’; did you mean ‘sched_getparam’? [-Werror=implicit-function-declaration] 2091 | tx_conf->conf.cpu_id = sched_getcpu(); | ^~~~~~~~~~~~ | sched_getparam cc1: all warnings being treated as errors Explicitly pass _GNU_SOURCE and include missing header (rather than rely on automagic inclusion from other system headers). Fixes: d48415e1fee3 ("examples/performance-thread: add l3fwd-thread app") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com> --- examples/performance-thread/l3fwd-thread/main.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/examples/performance-thread/l3fwd-thread/main.c b/examples/performance-thread/l3fwd-thread/main.c index 7bf61db6be..4d82fb82ef 100644 --- a/examples/performance-thread/l3fwd-thread/main.c +++ b/examples/performance-thread/l3fwd-thread/main.c @@ -2,6 +2,10 @@ * Copyright(c) 2010-2016 Intel Corporation */ +#ifndef _GNU_SOURCE +#define _GNU_SOURCE +#endif + #include <stdio.h> #include <stdlib.h> #include <stdint.h> @@ -12,6 +16,7 @@ #include <stdarg.h> #include <errno.h> #include <getopt.h> +#include <sched.h> #include <rte_common.h> #include <rte_vect.h> -- 2.23.0 ^ permalink raw reply [flat|nested] 19+ messages in thread
* [dpdk-stable] [PATCH v2 09/11] examples/rxtx_callbacks: fix build with pkg-config [not found] ` <20201113122430.25354-1-david.marchand@redhat.com> ` (4 preceding siblings ...) 2020-11-13 12:24 ` [dpdk-stable] [PATCH v2 07/11] examples/performance-thread: fix build with pkg-config David Marchand @ 2020-11-13 12:24 ` David Marchand 5 siblings, 0 replies; 19+ messages in thread From: David Marchand @ 2020-11-13 12:24 UTC (permalink / raw) To: dev Cc: thomas, bruce.richardson, stable, John McNamara, Ferruh Yigit, Tom Barbette This example is missing the experimental flag since it uses an experimental API. Fixes: cd1dadeb9b2a ("examples/rxtx_callbacks: support HW timestamp") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com> --- examples/rxtx_callbacks/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/rxtx_callbacks/Makefile b/examples/rxtx_callbacks/Makefile index bac3015d34..a618cdf751 100644 --- a/examples/rxtx_callbacks/Makefile +++ b/examples/rxtx_callbacks/Makefile @@ -26,6 +26,8 @@ CFLAGS += -O3 $(shell $(PKGCONF) --cflags libdpdk) LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk) LDFLAGS_STATIC = $(shell $(PKGCONF) --static --libs libdpdk) +CFLAGS += -DALLOW_EXPERIMENTAL_API + build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build $(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED) -- 2.23.0 ^ permalink raw reply [flat|nested] 19+ messages in thread
[parent not found: <20201114090533.6059-1-david.marchand@redhat.com>]
* [dpdk-stable] [PATCH v3 01/11] examples/fips_validation: fix build with pkg-config [not found] ` <20201114090533.6059-1-david.marchand@redhat.com> @ 2020-11-14 9:05 ` David Marchand 2020-11-14 9:05 ` [dpdk-stable] [PATCH v3 02/11] examples/ipsec-gw: " David Marchand ` (4 subsequent siblings) 5 siblings, 0 replies; 19+ messages in thread From: David Marchand @ 2020-11-14 9:05 UTC (permalink / raw) To: dev Cc: thomas, bruce.richardson, stable, Marko Kovacevic, Akhil Goyal, Fiona Trahe, Fan Zhang When this example started using rte_cryptodev_sym_session_pool_create, the part for pkg-config builds was not updated. Fixes: 261bbff75e34 ("examples: use separate crypto session mempools") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com> --- examples/fips_validation/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/fips_validation/Makefile b/examples/fips_validation/Makefile index 7ba9bcfea6..8f82a4c6c5 100644 --- a/examples/fips_validation/Makefile +++ b/examples/fips_validation/Makefile @@ -36,6 +36,8 @@ CFLAGS += -O3 $(shell $(PKGCONF) --cflags libdpdk) LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk) LDFLAGS_STATIC = $(shell $(PKGCONF) --static --libs libdpdk) +CFLAGS += -DALLOW_EXPERIMENTAL_API + build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build $(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED) -- 2.23.0 ^ permalink raw reply [flat|nested] 19+ messages in thread
* [dpdk-stable] [PATCH v3 02/11] examples/ipsec-gw: fix build with pkg-config [not found] ` <20201114090533.6059-1-david.marchand@redhat.com> 2020-11-14 9:05 ` [dpdk-stable] [PATCH v3 01/11] examples/fips_validation: " David Marchand @ 2020-11-14 9:05 ` David Marchand 2020-11-14 9:05 ` [dpdk-stable] [PATCH v3 03/11] examples/kni: " David Marchand ` (3 subsequent siblings) 5 siblings, 0 replies; 19+ messages in thread From: David Marchand @ 2020-11-14 9:05 UTC (permalink / raw) To: dev Cc: thomas, bruce.richardson, stable, Radu Nicolau, Akhil Goyal, Anoob Joseph flow.c: In function ‘parse_flow_tokens’: flow.c:153:23: error: taking address of packed member of ‘struct rte_ipv4_hdr’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 153 | if (ipv4_addr_cpy(&rule->ipv4.spec.hdr.src_addr, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ flow.c:154:9: error: taking address of packed member of ‘struct rte_ipv4_hdr’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 154 | &rule->ipv4.mask.hdr.src_addr, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ flow.c:170:23: error: taking address of packed member of ‘struct rte_ipv4_hdr’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 170 | if (ipv4_addr_cpy(&rule->ipv4.spec.hdr.dst_addr, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ flow.c:171:9: error: taking address of packed member of ‘struct rte_ipv4_hdr’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 171 | &rule->ipv4.mask.hdr.dst_addr, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors Meson build is fine since we waive those warnings. Replicate it for make. Fixes: 8e693616fcb2 ("examples/ipsec-secgw: enable flow based distribution") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com> --- examples/ipsec-secgw/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/ipsec-secgw/Makefile b/examples/ipsec-secgw/Makefile index 5e6cb51eac..7670cc3684 100644 --- a/examples/ipsec-secgw/Makefile +++ b/examples/ipsec-secgw/Makefile @@ -42,6 +42,7 @@ LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk) LDFLAGS_STATIC = $(shell $(PKGCONF) --static --libs libdpdk) CFLAGS += -DALLOW_EXPERIMENTAL_API +CFLAGS += -Wno-address-of-packed-member build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build $(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED) -- 2.23.0 ^ permalink raw reply [flat|nested] 19+ messages in thread
* [dpdk-stable] [PATCH v3 03/11] examples/kni: fix build with pkg-config [not found] ` <20201114090533.6059-1-david.marchand@redhat.com> 2020-11-14 9:05 ` [dpdk-stable] [PATCH v3 01/11] examples/fips_validation: " David Marchand 2020-11-14 9:05 ` [dpdk-stable] [PATCH v3 02/11] examples/ipsec-gw: " David Marchand @ 2020-11-14 9:05 ` David Marchand 2020-11-14 9:05 ` [dpdk-stable] [PATCH v3 07/11] examples/ntb: fix clean target David Marchand ` (2 subsequent siblings) 5 siblings, 0 replies; 19+ messages in thread From: David Marchand @ 2020-11-14 9:05 UTC (permalink / raw) To: dev; +Cc: thomas, bruce.richardson, stable, Ferruh Yigit, Dan Gora rm -f build/kni build/kni-static build/kni-shared test -d build && rmdir -p build || true [...] /usr/bin/ld: /tmp/cc72ssnK.o: undefined reference to symbol 'pthread_join@@GLIBC_2.2.5' This example explicitly call pthread API and should be linked against the pthread library. Fixes: 724beb913b44 ("examples/kni: monitor and update link state continually") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com> --- examples/kni/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/kni/Makefile b/examples/kni/Makefile index fa9fa85319..bbf3bcae12 100644 --- a/examples/kni/Makefile +++ b/examples/kni/Makefile @@ -27,6 +27,8 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk) LDFLAGS_STATIC = $(shell $(PKGCONF) --static --libs libdpdk) +LDFLAGS += -pthread + build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build $(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED) -- 2.23.0 ^ permalink raw reply [flat|nested] 19+ messages in thread
* [dpdk-stable] [PATCH v3 07/11] examples/ntb: fix clean target [not found] ` <20201114090533.6059-1-david.marchand@redhat.com> ` (2 preceding siblings ...) 2020-11-14 9:05 ` [dpdk-stable] [PATCH v3 03/11] examples/kni: " David Marchand @ 2020-11-14 9:05 ` David Marchand 2020-11-14 9:05 ` [dpdk-stable] [PATCH v3 08/11] examples/performance-thread: fix build with pkg-config David Marchand 2020-11-14 9:05 ` [dpdk-stable] [PATCH v3 10/11] examples/rxtx_callbacks: " David Marchand 5 siblings, 0 replies; 19+ messages in thread From: David Marchand @ 2020-11-14 9:05 UTC (permalink / raw) To: dev Cc: thomas, bruce.richardson, stable, Xiaoyun Li, Jingjing Wu, Xiaolong Ye When introducing this example, the cleanup from commit 7e9562a107f1 ("examples: fix make clean when using pkg-config") was missed. Fixes: c5eebf85badc ("examples/ntb: add example for NTB") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: Xiaoyun Li <xiaoyun.li@intel.com> --- examples/ntb/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/ntb/Makefile b/examples/ntb/Makefile index 4675570fd2..d35dabc471 100644 --- a/examples/ntb/Makefile +++ b/examples/ntb/Makefile @@ -42,4 +42,4 @@ build: .PHONY: clean clean: rm -f build/$(APP) build/$(APP)-static build/$(APP)-shared - rmdir --ignore-fail-on-non-empty build + test -d build && rmdir -p build || true -- 2.23.0 ^ permalink raw reply [flat|nested] 19+ messages in thread
* [dpdk-stable] [PATCH v3 08/11] examples/performance-thread: fix build with pkg-config [not found] ` <20201114090533.6059-1-david.marchand@redhat.com> ` (3 preceding siblings ...) 2020-11-14 9:05 ` [dpdk-stable] [PATCH v3 07/11] examples/ntb: fix clean target David Marchand @ 2020-11-14 9:05 ` David Marchand 2020-11-14 9:05 ` [dpdk-stable] [PATCH v3 10/11] examples/rxtx_callbacks: " David Marchand 5 siblings, 0 replies; 19+ messages in thread From: David Marchand @ 2020-11-14 9:05 UTC (permalink / raw) To: dev Cc: thomas, bruce.richardson, stable, John McNamara, Tomasz Kulasek, Ian Betts main.c: In function ‘lthread_tx’: main.c:2091:25: error: implicit declaration of function ‘sched_getcpu’; did you mean ‘sched_getparam’? [-Werror=implicit-function-declaration] 2091 | tx_conf->conf.cpu_id = sched_getcpu(); | ^~~~~~~~~~~~ | sched_getparam cc1: all warnings being treated as errors Explicitly pass _GNU_SOURCE and include missing header (rather than rely on automagic inclusion from other system headers). Fixes: d48415e1fee3 ("examples/performance-thread: add l3fwd-thread app") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com> --- examples/performance-thread/l3fwd-thread/main.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/examples/performance-thread/l3fwd-thread/main.c b/examples/performance-thread/l3fwd-thread/main.c index 7bf61db6be..4d82fb82ef 100644 --- a/examples/performance-thread/l3fwd-thread/main.c +++ b/examples/performance-thread/l3fwd-thread/main.c @@ -2,6 +2,10 @@ * Copyright(c) 2010-2016 Intel Corporation */ +#ifndef _GNU_SOURCE +#define _GNU_SOURCE +#endif + #include <stdio.h> #include <stdlib.h> #include <stdint.h> @@ -12,6 +16,7 @@ #include <stdarg.h> #include <errno.h> #include <getopt.h> +#include <sched.h> #include <rte_common.h> #include <rte_vect.h> -- 2.23.0 ^ permalink raw reply [flat|nested] 19+ messages in thread
* [dpdk-stable] [PATCH v3 10/11] examples/rxtx_callbacks: fix build with pkg-config [not found] ` <20201114090533.6059-1-david.marchand@redhat.com> ` (4 preceding siblings ...) 2020-11-14 9:05 ` [dpdk-stable] [PATCH v3 08/11] examples/performance-thread: fix build with pkg-config David Marchand @ 2020-11-14 9:05 ` David Marchand 5 siblings, 0 replies; 19+ messages in thread From: David Marchand @ 2020-11-14 9:05 UTC (permalink / raw) To: dev Cc: thomas, bruce.richardson, stable, John McNamara, Ferruh Yigit, Tom Barbette This example is missing the experimental flag since it uses an experimental API. Fixes: cd1dadeb9b2a ("examples/rxtx_callbacks: support HW timestamp") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com> --- examples/rxtx_callbacks/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/rxtx_callbacks/Makefile b/examples/rxtx_callbacks/Makefile index bac3015d34..a618cdf751 100644 --- a/examples/rxtx_callbacks/Makefile +++ b/examples/rxtx_callbacks/Makefile @@ -26,6 +26,8 @@ CFLAGS += -O3 $(shell $(PKGCONF) --cflags libdpdk) LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk) LDFLAGS_STATIC = $(shell $(PKGCONF) --static --libs libdpdk) +CFLAGS += -DALLOW_EXPERIMENTAL_API + build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build $(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED) -- 2.23.0 ^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2020-11-16 4:16 UTC | newest] Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20201110151219.4893-1-david.marchand@redhat.com> 2020-11-10 15:12 ` [dpdk-stable] [PATCH 01/10] examples/fips_validation: fix build with pkg-config David Marchand 2020-11-10 15:12 ` [dpdk-stable] [PATCH 02/10] examples/ipsec-gw: " David Marchand 2020-11-10 15:12 ` [dpdk-stable] [PATCH 03/10] examples/kni: " David Marchand 2020-11-10 15:12 ` [dpdk-stable] [PATCH 06/10] examples/ntb: fix clean target David Marchand 2020-11-12 1:30 ` Li, Xiaoyun 2020-11-10 15:12 ` [dpdk-stable] [PATCH 08/10] examples/rxtx_callbacks: fix build with pkg-config David Marchand [not found] ` <20201113122430.25354-1-david.marchand@redhat.com> 2020-11-13 12:24 ` [dpdk-stable] [PATCH v2 01/11] examples/fips_validation: " David Marchand 2020-11-13 12:24 ` [dpdk-stable] [PATCH v2 02/11] examples/ipsec-gw: " David Marchand 2020-11-16 4:16 ` [dpdk-stable] [EXT] " Anoob Joseph 2020-11-13 12:24 ` [dpdk-stable] [PATCH v2 03/11] examples/kni: " David Marchand 2020-11-13 12:24 ` [dpdk-stable] [PATCH v2 06/11] examples/ntb: fix clean target David Marchand 2020-11-13 12:24 ` [dpdk-stable] [PATCH v2 07/11] examples/performance-thread: fix build with pkg-config David Marchand 2020-11-13 12:24 ` [dpdk-stable] [PATCH v2 09/11] examples/rxtx_callbacks: " David Marchand [not found] ` <20201114090533.6059-1-david.marchand@redhat.com> 2020-11-14 9:05 ` [dpdk-stable] [PATCH v3 01/11] examples/fips_validation: " David Marchand 2020-11-14 9:05 ` [dpdk-stable] [PATCH v3 02/11] examples/ipsec-gw: " David Marchand 2020-11-14 9:05 ` [dpdk-stable] [PATCH v3 03/11] examples/kni: " David Marchand 2020-11-14 9:05 ` [dpdk-stable] [PATCH v3 07/11] examples/ntb: fix clean target David Marchand 2020-11-14 9:05 ` [dpdk-stable] [PATCH v3 08/11] examples/performance-thread: fix build with pkg-config David Marchand 2020-11-14 9:05 ` [dpdk-stable] [PATCH v3 10/11] examples/rxtx_callbacks: " David Marchand
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).