patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH 18.11 0/5] Backporting bnxt patches to 18.11
@ 2020-12-01  3:39 Kalesh A P
  2020-12-01  3:39 ` [dpdk-stable] [PATCH 18.11 1/5] net/bnxt: fix structure variable initialization Kalesh A P
                   ` (6 more replies)
  0 siblings, 7 replies; 10+ messages in thread
From: Kalesh A P @ 2020-12-01  3:39 UTC (permalink / raw)
  To: stable

From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>

Hi Kevin,

I have back ported conflicting patches to 18.11 LTS.

Please apply.

Kalesh AP (5):
  net/bnxt: fix structure variable initialization
  net/bnxt: fix UDP tunnel port removal
  net/bnxt: fix boolean operator usage
  net/bnxt: fix drop enable in get Rx queue info
  net/bnxt: increase size of Rx CQ

 drivers/net/bnxt/bnxt_ethdev.c | 15 +++------------
 drivers/net/bnxt/bnxt_hwrm.c   | 15 +++++++++++++--
 drivers/net/bnxt/bnxt_ring.h   |  2 +-
 drivers/net/bnxt/bnxt_rxq.c    |  5 +++++
 drivers/net/bnxt/bnxt_rxq.h    |  4 ++++
 drivers/net/bnxt/bnxt_rxr.c    |  3 +++
 drivers/net/bnxt/bnxt_txr.c    |  2 ++
 7 files changed, 31 insertions(+), 15 deletions(-)

-- 
2.10.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [dpdk-stable] [PATCH 18.11 1/5] net/bnxt: fix structure variable initialization
  2020-12-01  3:39 [dpdk-stable] [PATCH 18.11 0/5] Backporting bnxt patches to 18.11 Kalesh A P
@ 2020-12-01  3:39 ` Kalesh A P
  2020-12-01  3:39 ` [dpdk-stable] [PATCH 18.11 2/5] net/bnxt: fix UDP tunnel port removal Kalesh A P
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 10+ messages in thread
From: Kalesh A P @ 2020-12-01  3:39 UTC (permalink / raw)
  To: stable

From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>

[ upstream commit ce41561d1b998d9e15f74f9c3a6aff78e0f99871 ]

During port start if bnxt_alloc_all_hwrm_stat_ctxs() fails,
in the cleanup path we do see errors like below:

bnxt_hwrm_ring_free(): hwrm_ring_free cp failed. rc:2
bnxt_hwrm_ring_free(): hwrm_ring_free rx failed. rc:2

The reason for this is in bnxt_free_all_hwrm_rings(), the check
is made against "ring->fw_ring_id != INVALID_HW_RING_ID" which
always return true as ring->fw_ring_id is not set to INVALID_HW_RING_ID
while initialising the ring structs.

Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code")
Fixes: 2eb53b134aae ("net/bnxt: add initial Rx code")

Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Lance Richardson <lance.richardson@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
 drivers/net/bnxt/bnxt_rxr.c | 3 +++
 drivers/net/bnxt/bnxt_txr.c | 2 ++
 2 files changed, 5 insertions(+)

diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c
index a4234d1..433323b 100644
--- a/drivers/net/bnxt/bnxt_rxr.c
+++ b/drivers/net/bnxt/bnxt_rxr.c
@@ -695,6 +695,7 @@ int bnxt_init_rx_ring_struct(struct bnxt_rx_queue *rxq, unsigned int socket_id)
 	ring->bd_dma = rxr->rx_desc_mapping;
 	ring->vmem_size = ring->ring_size * sizeof(struct bnxt_sw_rx_bd);
 	ring->vmem = (void **)&rxr->rx_buf_ring;
+	ring->fw_ring_id = INVALID_HW_RING_ID;
 
 	cpr = rte_zmalloc_socket("bnxt_rx_ring",
 				 sizeof(struct bnxt_cp_ring_info),
@@ -716,6 +717,7 @@ int bnxt_init_rx_ring_struct(struct bnxt_rx_queue *rxq, unsigned int socket_id)
 	ring->bd_dma = cpr->cp_desc_mapping;
 	ring->vmem_size = 0;
 	ring->vmem = NULL;
+	ring->fw_ring_id = INVALID_HW_RING_ID;
 
 	/* Allocate Aggregator rings */
 	ring = rte_zmalloc_socket("bnxt_rx_ring_struct",
@@ -731,6 +733,7 @@ int bnxt_init_rx_ring_struct(struct bnxt_rx_queue *rxq, unsigned int socket_id)
 	ring->bd_dma = rxr->ag_desc_mapping;
 	ring->vmem_size = ring->ring_size * sizeof(struct bnxt_sw_rx_bd);
 	ring->vmem = (void **)&rxr->ag_buf_ring;
+	ring->fw_ring_id = INVALID_HW_RING_ID;
 
 	return 0;
 }
diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c
index 348b111..449c729 100644
--- a/drivers/net/bnxt/bnxt_txr.c
+++ b/drivers/net/bnxt/bnxt_txr.c
@@ -79,6 +79,7 @@ int bnxt_init_tx_ring_struct(struct bnxt_tx_queue *txq, unsigned int socket_id)
 	ring->bd_dma = txr->tx_desc_mapping;
 	ring->vmem_size = ring->ring_size * sizeof(struct bnxt_sw_tx_bd);
 	ring->vmem = (void **)&txr->tx_buf_ring;
+	ring->fw_ring_id = INVALID_HW_RING_ID;
 
 	cpr = rte_zmalloc_socket("bnxt_tx_ring",
 				 sizeof(struct bnxt_cp_ring_info),
@@ -99,6 +100,7 @@ int bnxt_init_tx_ring_struct(struct bnxt_tx_queue *txq, unsigned int socket_id)
 	ring->bd_dma = cpr->cp_desc_mapping;
 	ring->vmem_size = 0;
 	ring->vmem = NULL;
+	ring->fw_ring_id = INVALID_HW_RING_ID;
 
 	return 0;
 }
-- 
2.10.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [dpdk-stable] [PATCH 18.11 2/5] net/bnxt: fix UDP tunnel port removal
  2020-12-01  3:39 [dpdk-stable] [PATCH 18.11 0/5] Backporting bnxt patches to 18.11 Kalesh A P
  2020-12-01  3:39 ` [dpdk-stable] [PATCH 18.11 1/5] net/bnxt: fix structure variable initialization Kalesh A P
@ 2020-12-01  3:39 ` Kalesh A P
  2020-12-01  3:39 ` [dpdk-stable] [PATCH 18.11 3/5] net/bnxt: fix boolean operator usage Kalesh A P
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 10+ messages in thread
From: Kalesh A P @ 2020-12-01  3:39 UTC (permalink / raw)
  To: stable

From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>

[ upstream commit c4ae7adafa23fb1121b96518a9b9b815288e680c ]

The HWRM supports only one global destination port for a tunnel type.
When port is stopped, driver deletes the UDP tunnel port configured
in the HW, but it does not update the counter which causes the
tunnel port addition to fail after port is started again.

Fixed to update the counter when tunnel port is deleted.

Fixes: 10d074b2022d ("net/bnxt: support tunneling")

Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
---
 drivers/net/bnxt/bnxt_ethdev.c |  8 --------
 drivers/net/bnxt/bnxt_hwrm.c   | 15 +++++++++++++--
 2 files changed, 13 insertions(+), 10 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 82c54c3..366d36b 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -1308,14 +1308,6 @@ bnxt_udp_tunnel_port_del_op(struct rte_eth_dev *eth_dev,
 	}
 
 	rc = bnxt_hwrm_tunnel_dst_port_free(bp, port, tunnel_type);
-	if (!rc) {
-		if (tunnel_type ==
-		    HWRM_TUNNEL_DST_PORT_FREE_INPUT_TUNNEL_TYPE_VXLAN)
-			bp->vxlan_port = 0;
-		if (tunnel_type ==
-		    HWRM_TUNNEL_DST_PORT_FREE_INPUT_TUNNEL_TYPE_GENEVE)
-			bp->geneve_port = 0;
-	}
 	return rc;
 }
 
diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index 41372a1..7ad7767 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -2113,11 +2113,10 @@ void bnxt_free_tunnel_ports(struct bnxt *bp)
 	if (bp->vxlan_port_cnt)
 		bnxt_hwrm_tunnel_dst_port_free(bp, bp->vxlan_fw_dst_port_id,
 			HWRM_TUNNEL_DST_PORT_FREE_INPUT_TUNNEL_TYPE_VXLAN);
-	bp->vxlan_port = 0;
+
 	if (bp->geneve_port_cnt)
 		bnxt_hwrm_tunnel_dst_port_free(bp, bp->geneve_fw_dst_port_id,
 			HWRM_TUNNEL_DST_PORT_FREE_INPUT_TUNNEL_TYPE_GENEVE);
-	bp->geneve_port = 0;
 }
 
 void bnxt_free_all_hwrm_resources(struct bnxt *bp)
@@ -2910,6 +2909,18 @@ int bnxt_hwrm_tunnel_dst_port_free(struct bnxt *bp, uint16_t port,
 	HWRM_CHECK_RESULT();
 	HWRM_UNLOCK();
 
+	if (tunnel_type ==
+	    HWRM_TUNNEL_DST_PORT_FREE_INPUT_TUNNEL_TYPE_VXLAN) {
+		bp->vxlan_port = 0;
+		bp->vxlan_port_cnt = 0;
+	}
+
+	if (tunnel_type ==
+	    HWRM_TUNNEL_DST_PORT_FREE_INPUT_TUNNEL_TYPE_GENEVE) {
+		bp->geneve_port = 0;
+		bp->geneve_port_cnt = 0;
+	}
+
 	return rc;
 }
 
-- 
2.10.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [dpdk-stable] [PATCH 18.11 3/5] net/bnxt: fix boolean operator usage
  2020-12-01  3:39 [dpdk-stable] [PATCH 18.11 0/5] Backporting bnxt patches to 18.11 Kalesh A P
  2020-12-01  3:39 ` [dpdk-stable] [PATCH 18.11 1/5] net/bnxt: fix structure variable initialization Kalesh A P
  2020-12-01  3:39 ` [dpdk-stable] [PATCH 18.11 2/5] net/bnxt: fix UDP tunnel port removal Kalesh A P
@ 2020-12-01  3:39 ` Kalesh A P
  2020-12-01  3:39 ` [dpdk-stable] [PATCH 18.11 4/5] net/bnxt: fix drop enable in get Rx queue info Kalesh A P
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 10+ messages in thread
From: Kalesh A P @ 2020-12-01  3:39 UTC (permalink / raw)
  To: stable

From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>

[ upstream commit 47b70761670dc8b5bb8399df280476d9767b11df ]

Use boolean AND operator instead of bitwise operator.

Fixes: b42c15c83e88 ("net/bnxt: support trusted VF")

Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
 drivers/net/bnxt/bnxt_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 366d36b..a8123d8 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -753,7 +753,7 @@ static int bnxt_mac_addr_add_op(struct rte_eth_dev *eth_dev,
 	struct bnxt_filter_info *filter;
 	int rc = 0;
 
-	if (BNXT_VF(bp) & !BNXT_VF_IS_TRUSTED(bp)) {
+	if (BNXT_VF(bp) && !BNXT_VF_IS_TRUSTED(bp)) {
 		PMD_DRV_LOG(ERR, "Cannot add MAC address to a VF interface\n");
 		return -ENOTSUP;
 	}
-- 
2.10.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [dpdk-stable] [PATCH 18.11 4/5] net/bnxt: fix drop enable in get Rx queue info
  2020-12-01  3:39 [dpdk-stable] [PATCH 18.11 0/5] Backporting bnxt patches to 18.11 Kalesh A P
                   ` (2 preceding siblings ...)
  2020-12-01  3:39 ` [dpdk-stable] [PATCH 18.11 3/5] net/bnxt: fix boolean operator usage Kalesh A P
@ 2020-12-01  3:39 ` Kalesh A P
  2020-12-01  3:39 ` [dpdk-stable] [PATCH 18.11 5/5] net/bnxt: increase size of Rx CQ Kalesh A P
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 10+ messages in thread
From: Kalesh A P @ 2020-12-01  3:39 UTC (permalink / raw)
  To: stable

From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>

[ upstream commit bd881e8d2a075b2dd69362176e2f8c76c88187ec ]

Return correct value for rx_drop_en. Add per-queue field to
track rx_drop_en configuration.

Fixes: 2fc201884be8 ("net/bnxt: support rxq/txq get information")

Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
 drivers/net/bnxt/bnxt_ethdev.c | 5 ++---
 drivers/net/bnxt/bnxt_rxq.c    | 5 +++++
 drivers/net/bnxt/bnxt_rxq.h    | 4 ++++
 3 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index a8123d8..7fd2e3b 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -445,8 +445,7 @@ static void bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev,
 			.wthresh = 0,
 		},
 		.rx_free_thresh = 32,
-		/* If no descriptors available, pkts are dropped by default */
-		.rx_drop_en = 1,
+		.rx_drop_en = BNXT_DEFAULT_RX_DROP_EN,
 	};
 
 	dev_info->default_txconf = (struct rte_eth_txconf) {
@@ -1569,7 +1568,7 @@ bnxt_rxq_info_get_op(struct rte_eth_dev *dev, uint16_t queue_id,
 	qinfo->nb_desc = rxq->nb_rx_desc;
 
 	qinfo->conf.rx_free_thresh = rxq->rx_free_thresh;
-	qinfo->conf.rx_drop_en = 0;
+	qinfo->conf.rx_drop_en = rxq->drop_en;
 	qinfo->conf.rx_deferred_start = rxq->rx_deferred_start;
 	qinfo->conf.offloads = dev->data->dev_conf.rxmode.offloads;
 }
diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c
index d1664db..7d896dd 100644
--- a/drivers/net/bnxt/bnxt_rxq.c
+++ b/drivers/net/bnxt/bnxt_rxq.c
@@ -323,6 +323,11 @@ int bnxt_rx_queue_setup_op(struct rte_eth_dev *eth_dev,
 	rxq->nb_rx_desc = nb_desc;
 	rxq->rx_free_thresh = rx_conf->rx_free_thresh;
 
+	if (rx_conf->rx_drop_en != BNXT_DEFAULT_RX_DROP_EN)
+		PMD_DRV_LOG(NOTICE,
+			    "Per-queue config of drop-en is not supported.\n");
+	rxq->drop_en = BNXT_DEFAULT_RX_DROP_EN;
+
 	PMD_DRV_LOG(DEBUG, "RX Buf MTU %d\n", eth_dev->data->mtu);
 
 	rc = bnxt_init_rx_ring_struct(rxq, socket_id);
diff --git a/drivers/net/bnxt/bnxt_rxq.h b/drivers/net/bnxt/bnxt_rxq.h
index 00570b8..0eb350e 100644
--- a/drivers/net/bnxt/bnxt_rxq.h
+++ b/drivers/net/bnxt/bnxt_rxq.h
@@ -6,6 +6,9 @@
 #ifndef _BNXT_RQX_H_
 #define _BNXT_RQX_H_
 
+/* Drop by default when receive desc is not available. */
+#define BNXT_DEFAULT_RX_DROP_EN		1
+
 struct bnxt;
 struct bnxt_rx_ring_info;
 struct bnxt_cp_ring_info;
@@ -27,6 +30,7 @@ struct bnxt_rx_queue {
 	uint8_t			crc_len; /* 0 if CRC stripped, 4 otherwise */
 	uint8_t			rx_deferred_start; /* not in global dev start */
 	uint8_t			rx_started; /* RX queue is started */
+	uint8_t			drop_en; /* Drop when rx desc not available. */
 
 	struct bnxt		*bp;
 	int			index;
-- 
2.10.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [dpdk-stable] [PATCH 18.11 5/5] net/bnxt: increase size of Rx CQ
  2020-12-01  3:39 [dpdk-stable] [PATCH 18.11 0/5] Backporting bnxt patches to 18.11 Kalesh A P
                   ` (3 preceding siblings ...)
  2020-12-01  3:39 ` [dpdk-stable] [PATCH 18.11 4/5] net/bnxt: fix drop enable in get Rx queue info Kalesh A P
@ 2020-12-01  3:39 ` Kalesh A P
  2020-12-02 14:50 ` [dpdk-stable] [PATCH 18.11 0/5] Backporting bnxt patches to 18.11 Kevin Traynor
  2020-12-03 16:39 ` Kevin Traynor
  6 siblings, 0 replies; 10+ messages in thread
From: Kalesh A P @ 2020-12-01  3:39 UTC (permalink / raw)
  To: stable

From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>

[ upstream commit 45c6e1c66a4b5d7374e864502dc2fdb1ee71ceae ]

LRO aka TPA and jumbo frame support uses aggregation ring for placing
Rx buffers. These features can generate multiple Rx completions for a
single Rx packet. Increase size of Rx Completion Queue to handle TPA
and aggregation ring events.

Fixes: daef48efe5e5 ("net/bnxt: support set MTU")

Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Qingmin Liu <qingmin.liu@broadcom.com>
Reviewed-by: Randy Schacher <stuart.schacher@broadcom.com>
---
 drivers/net/bnxt/bnxt_ring.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bnxt/bnxt_ring.h b/drivers/net/bnxt/bnxt_ring.h
index 1446d78..2a613c8 100644
--- a/drivers/net/bnxt/bnxt_ring.h
+++ b/drivers/net/bnxt/bnxt_ring.h
@@ -27,7 +27,7 @@
 #define DEFAULT_TX_RING_SIZE	256
 
 #define BNXT_TPA_MAX		64
-#define AGG_RING_SIZE_FACTOR	2
+#define AGG_RING_SIZE_FACTOR	4
 #define AGG_RING_MULTIPLIER	2
 
 /* These assume 4k pages */
-- 
2.10.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-stable] [PATCH 18.11 0/5] Backporting bnxt patches to 18.11
  2020-12-01  3:39 [dpdk-stable] [PATCH 18.11 0/5] Backporting bnxt patches to 18.11 Kalesh A P
                   ` (4 preceding siblings ...)
  2020-12-01  3:39 ` [dpdk-stable] [PATCH 18.11 5/5] net/bnxt: increase size of Rx CQ Kalesh A P
@ 2020-12-02 14:50 ` Kevin Traynor
  2020-12-02 16:27   ` Kalesh Anakkur Purayil
  2020-12-03 16:39 ` Kevin Traynor
  6 siblings, 1 reply; 10+ messages in thread
From: Kevin Traynor @ 2020-12-02 14:50 UTC (permalink / raw)
  To: Kalesh A P, stable

On 01/12/2020 03:39, Kalesh A P wrote:
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> 
> Hi Kevin,
> 

Hi Kalesh,

> I have back ported conflicting patches to 18.11 LTS.
> 

Thanks for sending, they are running^Wcrawling in travis atm.

Are these the only bnxt fixes needed? the others in the list are:

$ grep bnxt failed-list-running
c92f053d4  Kalesh AP        net/bnxt: fix L2 filter allocation
99ad2abc0  Kalesh AP        net/bnxt: fix speed setting on certain adapters
4b029f02d  Somnath Kotur    net/bnxt: fix checking VNIC in shutdown path
ef10add37  Venkat Duvvuru   net/bnxt: fix PF support in SR-IOV mode
97c327178  Somnath Kotur    net/bnxt: fix queue release
0b42b92ae  Ferruh Yigit     net/bnxt: fix xstats by id
1ef8c6290  Stephen Hemminger net/bnxt: remove useless prefetches

Kevin.

> Please apply.
> 
> Kalesh AP (5):
>   net/bnxt: fix structure variable initialization
>   net/bnxt: fix UDP tunnel port removal
>   net/bnxt: fix boolean operator usage
>   net/bnxt: fix drop enable in get Rx queue info
>   net/bnxt: increase size of Rx CQ
> 
>  drivers/net/bnxt/bnxt_ethdev.c | 15 +++------------
>  drivers/net/bnxt/bnxt_hwrm.c   | 15 +++++++++++++--
>  drivers/net/bnxt/bnxt_ring.h   |  2 +-
>  drivers/net/bnxt/bnxt_rxq.c    |  5 +++++
>  drivers/net/bnxt/bnxt_rxq.h    |  4 ++++
>  drivers/net/bnxt/bnxt_rxr.c    |  3 +++
>  drivers/net/bnxt/bnxt_txr.c    |  2 ++
>  7 files changed, 31 insertions(+), 15 deletions(-)
> 


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-stable] [PATCH 18.11 0/5] Backporting bnxt patches to 18.11
  2020-12-02 14:50 ` [dpdk-stable] [PATCH 18.11 0/5] Backporting bnxt patches to 18.11 Kevin Traynor
@ 2020-12-02 16:27   ` Kalesh Anakkur Purayil
  2020-12-03  4:48     ` Somnath Kotur
  0 siblings, 1 reply; 10+ messages in thread
From: Kalesh Anakkur Purayil @ 2020-12-02 16:27 UTC (permalink / raw)
  To: Kevin Traynor; +Cc: stable

Hi Kevin,

On Wed, 2 Dec 2020 at 8:20 PM, Kevin Traynor <ktraynor@redhat.com> wrote:

> On 01/12/2020 03:39, Kalesh A P wrote:
> > From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> >
> > Hi Kevin,
> >
>
> Hi Kalesh,
>
> > I have back ported conflicting patches to 18.11 LTS.
> >
>
> Thanks for sending, they are running^Wcrawling in travis atm.
>
> Are these the only bnxt fixes needed? the others in the list are:
>
> $ grep bnxt failed-list-running
> c92f053d4  Kalesh AP        net/bnxt: fix L2 filter allocation
> 99ad2abc0  Kalesh AP        net/bnxt: fix speed setting on certain adapters

[Kalesh] these 2 are not needed for 18.11

>
> 4b029f02d  Somnath Kotur    net/bnxt: fix checking VNIC in shutdown path

[Kalesh] oops, my bad. I missed this one in the list. I need to check

>
> ef10add37  Venkat Duvvuru   net/bnxt: fix PF support in SR-IOV mode

[Kalesh] this one is not needed for 18.11

>
> 97c327178  Somnath Kotur    net/bnxt: fix queue release
> 0b42b92ae  Ferruh Yigit     net/bnxt: fix xstats by id
> 1ef8c6290  Stephen Hemminger net/bnxt: remove useless prefetches

[Kalesh] again my bad, missed these 3 and I need to check

>
>
> Kevin.
>
> > Please apply.
> >
> > Kalesh AP (5):
> >   net/bnxt: fix structure variable initialization
> >   net/bnxt: fix UDP tunnel port removal
> >   net/bnxt: fix boolean operator usage
> >   net/bnxt: fix drop enable in get Rx queue info
> >   net/bnxt: increase size of Rx CQ
> >
> >  drivers/net/bnxt/bnxt_ethdev.c | 15 +++------------
> >  drivers/net/bnxt/bnxt_hwrm.c   | 15 +++++++++++++--
> >  drivers/net/bnxt/bnxt_ring.h   |  2 +-
> >  drivers/net/bnxt/bnxt_rxq.c    |  5 +++++
> >  drivers/net/bnxt/bnxt_rxq.h    |  4 ++++
> >  drivers/net/bnxt/bnxt_rxr.c    |  3 +++
> >  drivers/net/bnxt/bnxt_txr.c    |  2 ++
> >  7 files changed, 31 insertions(+), 15 deletions(-)
> >
>
> --
Regards,
Kalesh A P

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-stable] [PATCH 18.11 0/5] Backporting bnxt patches to 18.11
  2020-12-02 16:27   ` Kalesh Anakkur Purayil
@ 2020-12-03  4:48     ` Somnath Kotur
  0 siblings, 0 replies; 10+ messages in thread
From: Somnath Kotur @ 2020-12-03  4:48 UTC (permalink / raw)
  To: Kalesh Anakkur Purayil; +Cc: Kevin Traynor, dpdk stable

On Wed, Dec 2, 2020 at 9:57 PM Kalesh Anakkur Purayil
<kalesh-anakkur.purayil@broadcom.com> wrote:
>
> Hi Kevin,
>
> On Wed, 2 Dec 2020 at 8:20 PM, Kevin Traynor <ktraynor@redhat.com> wrote:
>
> > On 01/12/2020 03:39, Kalesh A P wrote:
> > > From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> > >
> > > Hi Kevin,
> > >
> >
> > Hi Kalesh,
> >
> > > I have back ported conflicting patches to 18.11 LTS.
> > >
> >
> > Thanks for sending, they are running^Wcrawling in travis atm.
> >
> > Are these the only bnxt fixes needed? the others in the list are:
> >
> > $ grep bnxt failed-list-running
> > c92f053d4  Kalesh AP        net/bnxt: fix L2 filter allocation
> > 99ad2abc0  Kalesh AP        net/bnxt: fix speed setting on certain adapters
>
> [Kalesh] these 2 are not needed for 18.11
>
> >
> > 4b029f02d  Somnath Kotur    net/bnxt: fix checking VNIC in shutdown path
>
> [Kalesh] oops, my bad. I missed this one in the list. I need to check
[SOM]: Sent a patch for this just now
>
> >
> > ef10add37  Venkat Duvvuru   net/bnxt: fix PF support in SR-IOV mode
>
> [Kalesh] this one is not needed for 18.11
>
> >
> > 97c327178  Somnath Kotur    net/bnxt: fix queue release
[SOM]: Sent the patch for this now
> > 0b42b92ae  Ferruh Yigit     net/bnxt: fix xstats by id
> > 1ef8c6290  Stephen Hemminger net/bnxt: remove useless prefetches
>
> [Kalesh] again my bad, missed these 3 and I need to check
>
> >
> >
> > Kevin.
> >
> > > Please apply.
> > >
> > > Kalesh AP (5):
> > >   net/bnxt: fix structure variable initialization
> > >   net/bnxt: fix UDP tunnel port removal
> > >   net/bnxt: fix boolean operator usage
> > >   net/bnxt: fix drop enable in get Rx queue info
> > >   net/bnxt: increase size of Rx CQ
> > >
> > >  drivers/net/bnxt/bnxt_ethdev.c | 15 +++------------
> > >  drivers/net/bnxt/bnxt_hwrm.c   | 15 +++++++++++++--
> > >  drivers/net/bnxt/bnxt_ring.h   |  2 +-
> > >  drivers/net/bnxt/bnxt_rxq.c    |  5 +++++
> > >  drivers/net/bnxt/bnxt_rxq.h    |  4 ++++
> > >  drivers/net/bnxt/bnxt_rxr.c    |  3 +++
> > >  drivers/net/bnxt/bnxt_txr.c    |  2 ++
> > >  7 files changed, 31 insertions(+), 15 deletions(-)
> > >
> >
> > --
> Regards,
> Kalesh A P

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-stable] [PATCH 18.11 0/5] Backporting bnxt patches to 18.11
  2020-12-01  3:39 [dpdk-stable] [PATCH 18.11 0/5] Backporting bnxt patches to 18.11 Kalesh A P
                   ` (5 preceding siblings ...)
  2020-12-02 14:50 ` [dpdk-stable] [PATCH 18.11 0/5] Backporting bnxt patches to 18.11 Kevin Traynor
@ 2020-12-03 16:39 ` Kevin Traynor
  6 siblings, 0 replies; 10+ messages in thread
From: Kevin Traynor @ 2020-12-03 16:39 UTC (permalink / raw)
  To: Kalesh A P, stable

On 01/12/2020 03:39, Kalesh A P wrote:
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> 
> Hi Kevin,
> 
> I have back ported conflicting patches to 18.11 LTS.
> 
> Please apply.
> 
> Kalesh AP (5):
>   net/bnxt: fix structure variable initialization
>   net/bnxt: fix UDP tunnel port removal
>   net/bnxt: fix boolean operator usage
>   net/bnxt: fix drop enable in get Rx queue info
>   net/bnxt: increase size of Rx CQ
> 
>  drivers/net/bnxt/bnxt_ethdev.c | 15 +++------------
>  drivers/net/bnxt/bnxt_hwrm.c   | 15 +++++++++++++--
>  drivers/net/bnxt/bnxt_ring.h   |  2 +-
>  drivers/net/bnxt/bnxt_rxq.c    |  5 +++++
>  drivers/net/bnxt/bnxt_rxq.h    |  4 ++++
>  drivers/net/bnxt/bnxt_rxr.c    |  3 +++
>  drivers/net/bnxt/bnxt_txr.c    |  2 ++
>  7 files changed, 31 insertions(+), 15 deletions(-)
> 

applied, thanks.


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2020-12-03 16:39 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-01  3:39 [dpdk-stable] [PATCH 18.11 0/5] Backporting bnxt patches to 18.11 Kalesh A P
2020-12-01  3:39 ` [dpdk-stable] [PATCH 18.11 1/5] net/bnxt: fix structure variable initialization Kalesh A P
2020-12-01  3:39 ` [dpdk-stable] [PATCH 18.11 2/5] net/bnxt: fix UDP tunnel port removal Kalesh A P
2020-12-01  3:39 ` [dpdk-stable] [PATCH 18.11 3/5] net/bnxt: fix boolean operator usage Kalesh A P
2020-12-01  3:39 ` [dpdk-stable] [PATCH 18.11 4/5] net/bnxt: fix drop enable in get Rx queue info Kalesh A P
2020-12-01  3:39 ` [dpdk-stable] [PATCH 18.11 5/5] net/bnxt: increase size of Rx CQ Kalesh A P
2020-12-02 14:50 ` [dpdk-stable] [PATCH 18.11 0/5] Backporting bnxt patches to 18.11 Kevin Traynor
2020-12-02 16:27   ` Kalesh Anakkur Purayil
2020-12-03  4:48     ` Somnath Kotur
2020-12-03 16:39 ` Kevin Traynor

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git