* [dpdk-stable] [PATCH] test/service_cores: fix wrong comment
@ 2021-08-19 6:11 Joyce Kong
2021-08-19 8:13 ` Van Haaren, Harry
0 siblings, 1 reply; 3+ messages in thread
From: Joyce Kong @ 2021-08-19 6:11 UTC (permalink / raw)
To: jerin.jacob, harry.van.haaren, honnappa.nagarahalli, ruifeng.wang
Cc: dev, nd, stable
Change the inaccurate comment of 'set pass flag'
to 'clear pass flag' as the '*pass_test = 0' code
actually implements clearing.
Fixes: f038a81e1c56 ("service: add unit tests")
Cc: stable@dpdk.org
Signed-off-by: Joyce Kong <joyce.kong@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
app/test/test_service_cores.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test/test_service_cores.c b/app/test/test_service_cores.c
index ece104054e..8659a1526c 100644
--- a/app/test/test_service_cores.c
+++ b/app/test/test_service_cores.c
@@ -68,7 +68,7 @@ static int32_t dummy_mt_unsafe_cb(void *args)
rte_delay_ms(250);
__atomic_store_n(lock, 0, __ATOMIC_RELAXED);
} else {
- /* 2nd thread will fail to take lock, so set pass flag */
+ /* 2nd thread will fail to take lock, so clear pass flag */
*pass_test = 0;
}
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-stable] [PATCH] test/service_cores: fix wrong comment
2021-08-19 6:11 [dpdk-stable] [PATCH] test/service_cores: fix wrong comment Joyce Kong
@ 2021-08-19 8:13 ` Van Haaren, Harry
2021-10-12 18:48 ` [dpdk-stable] [dpdk-dev] " David Marchand
0 siblings, 1 reply; 3+ messages in thread
From: Van Haaren, Harry @ 2021-08-19 8:13 UTC (permalink / raw)
To: Joyce Kong, jerin.jacob, honnappa.nagarahalli, ruifeng.wang
Cc: dev, nd, stable
> -----Original Message-----
> From: Joyce Kong <joyce.kong@arm.com>
> Sent: Thursday, August 19, 2021 7:11 AM
> To: jerin.jacob@caviumnetworks.com; Van Haaren, Harry
> <harry.van.haaren@intel.com>; honnappa.nagarahalli@arm.com;
> ruifeng.wang@arm.com
> Cc: dev@dpdk.org; nd@arm.com; stable@dpdk.org
> Subject: [PATCH] test/service_cores: fix wrong comment
>
> Change the inaccurate comment of 'set pass flag'
> to 'clear pass flag' as the '*pass_test = 0' code
> actually implements clearing.
>
> Fixes: f038a81e1c56 ("service: add unit tests")
> Cc: stable@dpdk.org
>
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH] test/service_cores: fix wrong comment
2021-08-19 8:13 ` Van Haaren, Harry
@ 2021-10-12 18:48 ` David Marchand
0 siblings, 0 replies; 3+ messages in thread
From: David Marchand @ 2021-10-12 18:48 UTC (permalink / raw)
To: Joyce Kong
Cc: Van Haaren, Harry, jerin.jacob, honnappa.nagarahalli,
ruifeng.wang, dev, nd, stable
On Thu, Aug 19, 2021 at 10:13 AM Van Haaren, Harry
<harry.van.haaren@intel.com> wrote:
>
> > -----Original Message-----
> > From: Joyce Kong <joyce.kong@arm.com>
> > Sent: Thursday, August 19, 2021 7:11 AM
> > To: jerin.jacob@caviumnetworks.com; Van Haaren, Harry
> > <harry.van.haaren@intel.com>; honnappa.nagarahalli@arm.com;
> > ruifeng.wang@arm.com
> > Cc: dev@dpdk.org; nd@arm.com; stable@dpdk.org
> > Subject: [PATCH] test/service_cores: fix wrong comment
> >
> > Change the inaccurate comment of 'set pass flag'
> > to 'clear pass flag' as the '*pass_test = 0' code
> > actually implements clearing.
> >
> > Fixes: f038a81e1c56 ("service: add unit tests")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-12 18:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-19 6:11 [dpdk-stable] [PATCH] test/service_cores: fix wrong comment Joyce Kong
2021-08-19 8:13 ` Van Haaren, Harry
2021-10-12 18:48 ` [dpdk-stable] [dpdk-dev] " David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).