patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Maxime Coquelin <>
Cc:,,,, Maxime Coquelin <>
Subject: [dpdk-stable] [PATCH v3 0/5] Virtio PMD RSS support & RSS fixes
Date: Wed, 29 Sep 2021 11:16:56 +0200	[thread overview]
Message-ID: <> (raw)

This series is mainly adding support for RSS to Virtio PMD
driver. The two last patches are fixing an issue in testpmd
that could cause out of bounds access, and fix
an issue spotted in the mlx5 driver while looking for

The first motivation for this series is to eventually
support RSS down to the Vhost-user library, so that OVS can
benefit from it. But it will be also useful with vDPA
devices in the future.

Regarding the testing, I have tested it with qemu v5.2 from
Fedora 34. Since libvirt does not support yet enabling RSS
feature in the Qemu virtio-net device, and this feature is
disabled by default, the tester can either rebuild the qemu
package to enable it by default or use the qemu cmdline to
do the same.

The tester can use testpmd in icmpecho mode in the guest
and scapy on the host to inject random traffic on the tap
interface, e.g.:
sendp(Ether(src=RandMAC()) / IP(src=RandIP(), dst='') / UDP(sport=RandShort(), dport=RandShort()), loop=True, iface='vnet7')

Then it can play with RSS config in testpmd to change the
RETA, or hash type and see traffic being steered
accordingly by checking the Rx xstats.

Changes in v3:
- Add applying user-specified RSS conf a device config time (Andrew)
- Remove useless checks (Chenbo)
- Clean control message payload dlen variable (Chenbo)
- Add GTPU offload type (Xiaoyun)
- Add missing types to str2flowtype() (Xiaoyun)

Changes in v2:
- Rework patch 2 to keep old behaviour, but fix possible out of bounds due to key length (Andrew/Nelio/Xiaoyun)
- s/reta/RETA/ (Andrew)
- Applied A-by on patch 3 (Slava)
- Fix display of configured hash types
- Add missing flow types definition to testpmd's port info command

Maxime Coquelin (5):
  net/virtio: add initial RSS support
  app/testpmd: fix RSS key length
  app/testpmd: fix RSS type display
  net/mlx5: fix RSS RETA update
  app/testpmd: add missing flow types in port info

 app/test-pmd/cmdline.c                 |   4 +
 app/test-pmd/config.c                  |  11 +-
 doc/guides/nics/features/virtio.ini    |   3 +
 doc/guides/nics/virtio.rst             |   3 +
 doc/guides/rel_notes/release_21_11.rst |   6 +
 drivers/net/mlx5/mlx5_rss.c            |   2 +-
 drivers/net/virtio/virtio.h            |  31 +-
 drivers/net/virtio/virtio_ethdev.c     | 394 ++++++++++++++++++++++++-
 drivers/net/virtio/virtio_ethdev.h     |   3 +-
 drivers/net/virtio/virtqueue.h         |  21 ++
 10 files changed, 466 insertions(+), 12 deletions(-)


             reply	other threads:[~2021-09-29  9:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-29  9:16 Maxime Coquelin [this message]
2021-09-29  9:16 ` [dpdk-stable] [PATCH v3 1/5] net/virtio: add initial RSS support Maxime Coquelin
2021-09-29  9:16 ` [dpdk-stable] [PATCH v3 2/5] app/testpmd: fix RSS key length Maxime Coquelin
2021-09-29  9:16 ` [dpdk-stable] [PATCH v3 3/5] app/testpmd: fix RSS type display Maxime Coquelin
2021-09-29  9:17 ` [dpdk-stable] [PATCH v3 4/5] net/mlx5: fix RSS RETA update Maxime Coquelin
2021-09-29  9:17 ` [dpdk-stable] [PATCH v3 5/5] app/testpmd: add missing flow types in port info Maxime Coquelin
2021-09-30  1:05   ` Li, Xiaoyun
2021-10-01  7:51     ` Maxime Coquelin
2021-10-08  1:53       ` Li, Xiaoyun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).