patches for DPDK stable branches
 help / color / mirror / Atom feed
* [PATCH] app/compress-perf: fix cyclecount enqueue ops allocation
@ 2022-02-23 13:32 Raja Zidane
  2022-03-04  9:27 ` [EXT] " Akhil Goyal
  0 siblings, 1 reply; 2+ messages in thread
From: Raja Zidane @ 2022-02-23 13:32 UTC (permalink / raw)
  To: dev; +Cc: matan, stable

In cyclecount main_loop function, each iteration it tries to enqueue X ops,
in case Y<X ops were enqueued, the rest of the X-Y ops are moved to the
beginning of the ops array, to preserve ops order, and next Y ops are
allocated for the next enqueue action, the allocation of the ops occures on
the first Y entries in the array, when it should have skipped the first X-Y
array entries and allocate the following Y entries.

Fix the allocation by adding the correct offset.

Fixes: 2695db95a147 ("test/compress: add cycle-count mode to perf tool")
Cc: stable@dpdk.org

Signed-off-by: Raja Zidane <rzidane@nvidia.com>
---
Acked-by: Matan Azrad matan@nvidia.com
 app/test-compress-perf/comp_perf_test_cyclecount.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-compress-perf/comp_perf_test_cyclecount.c b/app/test-compress-perf/comp_perf_test_cyclecount.c
index 1d8e5fe6c2..c215547291 100644
--- a/app/test-compress-perf/comp_perf_test_cyclecount.c
+++ b/app/test-compress-perf/comp_perf_test_cyclecount.c
@@ -273,7 +273,7 @@ main_loop(struct cperf_cyclecount_ctx *ctx, enum rte_comp_xform_type type)
 			/* Allocate compression operations */
 			if (ops_needed && rte_mempool_get_bulk(
 						mem->op_pool,
-						(void **)ops,
+						(void **)&ops[ops_unused],
 						ops_needed) != 0) {
 				RTE_LOG(ERR, USER1,
 				      "Could not allocate enough operations\n");
-- 
2.21.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [EXT] [PATCH] app/compress-perf: fix cyclecount enqueue ops allocation
  2022-02-23 13:32 [PATCH] app/compress-perf: fix cyclecount enqueue ops allocation Raja Zidane
@ 2022-03-04  9:27 ` Akhil Goyal
  0 siblings, 0 replies; 2+ messages in thread
From: Akhil Goyal @ 2022-03-04  9:27 UTC (permalink / raw)
  To: Raja Zidane, dev; +Cc: matan, stable

> In cyclecount main_loop function, each iteration it tries to enqueue X ops,
> in case Y<X ops were enqueued, the rest of the X-Y ops are moved to the
> beginning of the ops array, to preserve ops order, and next Y ops are
> allocated for the next enqueue action, the allocation of the ops occures on
> the first Y entries in the array, when it should have skipped the first X-Y
> array entries and allocate the following Y entries.
> 
> Fix the allocation by adding the correct offset.
> 
> Fixes: 2695db95a147 ("test/compress: add cycle-count mode to perf tool")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Raja Zidane <rzidane@nvidia.com>
> ---
> Acked-by: Matan Azrad matan@nvidia.com

Please use proper syntax for acks.

Applied to dpdk-next-crypto

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-03-04  9:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-23 13:32 [PATCH] app/compress-perf: fix cyclecount enqueue ops allocation Raja Zidane
2022-03-04  9:27 ` [EXT] " Akhil Goyal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).