From: Dongdong Liu <liudongdong3@huawei.com>
To: <dev@dpdk.org>
Cc: <yux.jiang@intel.com>, <zhiminx.huang@intel.com>,
<qingx.sun@intel.com>, <ferruh.yigit@xilinx.com>,
<songx.jiale@intel.com>, <stable@dpdk.org>,
Huisong Li <lihuisong@huawei.com>,
Dongdong Liu <liudongdong3@huawei.com>,
Chas Williams <chas3@att.com>,
"Min Hu (Connor)" <humin29@huawei.com>,
Declan Doherty <declan.doherty@intel.com>,
Tomasz Kulasek <tomaszx.kulasek@intel.com>
Subject: [PATCH 1/2] net/bonding: fix RSS inconsistent between bonded and slaves
Date: Wed, 8 Jun 2022 19:45:47 +0800 [thread overview]
Message-ID: <20220608114548.25837-2-liudongdong3@huawei.com> (raw)
In-Reply-To: <20220608114548.25837-1-liudongdong3@huawei.com>
From: Huisong Li <lihuisong@huawei.com>
Currently, RSS configuration of slave is set only when RSS is enabled for
bonded port. If RSS is enabled for the slaves port before adding to the
bonded port with disabling RSS, it will run into that the RSS enabled state
of bonded and slaves port is inconsistent after starting bonded port.
So the RSS configuration of slave should also be set when RSS is disabled
for bonded port.
Fixes: 734ce47f71e0 ("bonding: support RSS dynamic configuration")
Cc: stable@dpdk.org
Signed-off-by: Huisong Li <lihuisong@huawei.com>
Signed-off-by: Dongdong Liu <liudongdong3@huawei.com>
---
drivers/net/bonding/rte_eth_bond_pmd.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index ace8f8b45e..73e6972035 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -1707,6 +1707,12 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,
bonded_eth_dev->data->dev_conf.rx_adv_conf.rss_conf.rss_hf;
slave_eth_dev->data->dev_conf.rxmode.mq_mode =
bonded_eth_dev->data->dev_conf.rxmode.mq_mode;
+ } else {
+ slave_eth_dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key_len = 0;
+ slave_eth_dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key = NULL;
+ slave_eth_dev->data->dev_conf.rx_adv_conf.rss_conf.rss_hf = 0;
+ slave_eth_dev->data->dev_conf.rxmode.mq_mode =
+ bonded_eth_dev->data->dev_conf.rxmode.mq_mode;
}
slave_eth_dev->data->dev_conf.rxmode.mtu =
--
2.33.0
next prev parent reply other threads:[~2022-06-08 11:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 11:45 [PATCH 0/2] app/test: fix bonding RSS test when disable RSS Dongdong Liu
2022-06-08 11:45 ` Dongdong Liu [this message]
2022-06-09 8:52 ` [PATCH 1/2] net/bonding: fix RSS inconsistent between bonded and slaves Andrew Rybchenko
2022-06-08 11:45 ` [PATCH 2/2] app/test: fix bonding RSS test when disable RSS Dongdong Liu
2022-06-09 8:53 ` [PATCH 0/2] " Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220608114548.25837-2-liudongdong3@huawei.com \
--to=liudongdong3@huawei.com \
--cc=chas3@att.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=humin29@huawei.com \
--cc=lihuisong@huawei.com \
--cc=qingx.sun@intel.com \
--cc=songx.jiale@intel.com \
--cc=stable@dpdk.org \
--cc=tomaszx.kulasek@intel.com \
--cc=yux.jiang@intel.com \
--cc=zhiminx.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).