patches for DPDK stable branches
 help / color / mirror / Atom feed
* [PATCH v8 2/3] test/crypto: fix IV in some vectors
       [not found] ` <20230914152229.2650901-1-brian.dooley@intel.com>
@ 2023-09-14 15:22   ` Brian Dooley
  2023-09-14 15:22   ` [PATCH v8 3/3] test/crypto: fix failing synchronous tests Brian Dooley
  1 sibling, 0 replies; 2+ messages in thread
From: Brian Dooley @ 2023-09-14 15:22 UTC (permalink / raw)
  To: Akhil Goyal, Fan Zhang
  Cc: dev, Brian Dooley, adamx.dybkowski, stable, Ciara Power

SNOW3G and ZUC algorithms require non-zero length IVs.

Fixes: c6c267a00a92 ("test/crypto: add mixed encypted-digest")
Cc: adamx.dybkowski@intel.com
Cc: stable@dpdk.org

Acked-by: Ciara Power <ciara.power@intel.com>
Signed-off-by: Brian Dooley <brian.dooley@intel.com>
--
v8:
Add cc stable
---
 app/test/test_cryptodev_mixed_test_vectors.h | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/app/test/test_cryptodev_mixed_test_vectors.h b/app/test/test_cryptodev_mixed_test_vectors.h
index 161e2d905f..9c4313185e 100644
--- a/app/test/test_cryptodev_mixed_test_vectors.h
+++ b/app/test/test_cryptodev_mixed_test_vectors.h
@@ -478,8 +478,10 @@ struct mixed_cipher_auth_test_data auth_aes_cmac_cipher_snow_test_case_1 = {
 	},
 	.cipher_iv = {
 		.data = {
+			0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+			0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
 		},
-		.len = 0,
+		.len = 16,
 	},
 	.cipher = {
 		.len_bits = 516 << 3,
@@ -917,8 +919,10 @@ struct mixed_cipher_auth_test_data auth_aes_cmac_cipher_zuc_test_case_1 = {
 	},
 	.cipher_iv = {
 		.data = {
+			0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+			0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
 		},
-		.len = 0,
+		.len = 16,
 	},
 	.cipher = {
 		.len_bits = 516 << 3,
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH v8 3/3] test/crypto: fix failing synchronous tests
       [not found] ` <20230914152229.2650901-1-brian.dooley@intel.com>
  2023-09-14 15:22   ` [PATCH v8 2/3] test/crypto: fix IV in some vectors Brian Dooley
@ 2023-09-14 15:22   ` Brian Dooley
  1 sibling, 0 replies; 2+ messages in thread
From: Brian Dooley @ 2023-09-14 15:22 UTC (permalink / raw)
  To: Akhil Goyal, Fan Zhang
  Cc: dev, Brian Dooley, pablo.de.lara.guarch, stable, Ciara Power

Some synchronous tests are not supported for cpu crypto and need to be
skipped. This commit adds in extra skips for these tests.

Fixes: 55ab4a8c4fb5 ("test/crypto: disable wireless cases for CPU crypto API")
Cc: pablo.de.lara.guarch@intel.com
Cc: stable@dpdk.org

Acked-by: Ciara Power <ciara.power@intel.com>
Signed-off-by: Brian Dooley <brian.dooley@intel.com>
---
v8:
Reword commit and add cc stable
---
 app/test/test_cryptodev.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 956268bfcd..70f6b7ece1 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -6394,6 +6394,9 @@ test_zuc_auth_cipher(const struct wireless_test_data *tdata,
 			tdata->digest.len) < 0)
 		return TEST_SKIPPED;
 
+	if (gbl_action_type == RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO)
+		return TEST_SKIPPED;
+
 	rte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info);
 
 	uint64_t feat_flags = dev_info.feature_flags;
@@ -7829,6 +7832,9 @@ test_mixed_auth_cipher(const struct mixed_cipher_auth_test_data *tdata,
 	if (global_api_test_type == CRYPTODEV_RAW_API_TEST)
 		return TEST_SKIPPED;
 
+	if (gbl_action_type == RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO)
+		return TEST_SKIPPED;
+
 	rte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info);
 
 	uint64_t feat_flags = dev_info.feature_flags;
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-09-14 15:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20230907161258.2288031-1-brian.dooley@intel.com>
     [not found] ` <20230914152229.2650901-1-brian.dooley@intel.com>
2023-09-14 15:22   ` [PATCH v8 2/3] test/crypto: fix IV in some vectors Brian Dooley
2023-09-14 15:22   ` [PATCH v8 3/3] test/crypto: fix failing synchronous tests Brian Dooley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).