patches for DPDK stable branches
 help / color / mirror / Atom feed
From: luca.boccassi@gmail.com
To: Fengjiang Liu <liufengjiang.0426@bytedance.com>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>,
	dpdk stable <stable@dpdk.org>
Subject: patch 'net/virtio: fix missing next flag in Tx packed ring' has been queued to stable release 20.11.10
Date: Wed,  8 Nov 2023 19:25:02 +0000	[thread overview]
Message-ID: <20231108192535.922238-4-luca.boccassi@gmail.com> (raw)
In-Reply-To: <20231108192535.922238-1-luca.boccassi@gmail.com>

Hi,

FYI, your patch has been queued to stable release 20.11.10

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/10/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/3c0ce46c7013e5c4aa86ceda81827241db7f7bbe

Thanks.

Luca Boccassi

---
From 3c0ce46c7013e5c4aa86ceda81827241db7f7bbe Mon Sep 17 00:00:00 2001
From: Fengjiang Liu <liufengjiang.0426@bytedance.com>
Date: Tue, 17 Oct 2023 15:26:23 +0800
Subject: [PATCH] net/virtio: fix missing next flag in Tx packed ring

[ upstream commit f923636411c557782f4718de8bee856d60afa74c ]

When the packets is sent in packed mode, and the packets data and
virtio-header are divided into two desc, set the next flag of
virtio-header desc

Bugzilla ID: 1295
Fixes: 892dc798fa9c ("net/virtio: implement Tx path for packed queues")

Signed-off-by: Fengjiang Liu <liufengjiang.0426@bytedance.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
 drivers/net/virtio/virtqueue.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
index 70121eb340..6811ab55d6 100644
--- a/drivers/net/virtio/virtqueue.h
+++ b/drivers/net/virtio/virtqueue.h
@@ -756,6 +756,7 @@ virtqueue_enqueue_xmit_packed(struct virtnet_tx *txvq, struct rte_mbuf *cookie,
 		start_dp[idx].addr  = txvq->virtio_net_hdr_mem +
 			RTE_PTR_DIFF(&txr[idx].tx_hdr, txr);
 		start_dp[idx].len   = vq->hw->vtnet_hdr_size;
+		head_flags |= VRING_DESC_F_NEXT;
 		hdr = (struct virtio_net_hdr *)&txr[idx].tx_hdr;
 		idx++;
 		if (idx >= vq->vq_nentries) {
-- 
2.39.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-11-08 19:23:52.116226569 +0000
+++ 0004-net-virtio-fix-missing-next-flag-in-Tx-packed-ring.patch	2023-11-08 19:23:51.725395299 +0000
@@ -1 +1 @@
-From f923636411c557782f4718de8bee856d60afa74c Mon Sep 17 00:00:00 2001
+From 3c0ce46c7013e5c4aa86ceda81827241db7f7bbe Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit f923636411c557782f4718de8bee856d60afa74c ]
+
@@ -12 +13,0 @@
-Cc: stable@dpdk.org
@@ -17 +17,0 @@
- .mailmap                       | 1 +
@@ -19 +19 @@
- 2 files changed, 2 insertions(+)
+ 1 file changed, 1 insertion(+)
@@ -21,12 +20,0 @@
-diff --git a/.mailmap b/.mailmap
-index 3f5bab26a8..5273df74cb 100644
---- a/.mailmap
-+++ b/.mailmap
-@@ -394,6 +394,7 @@ Farah Smith <farah.smith@broadcom.com>
- Fei Chen <chenwei.0515@bytedance.com>
- Feifei Wang <feifei.wang2@arm.com> <feifei.wang@arm.com>
- Fei Qin <fei.qin@corigine.com>
-+Fengjiang Liu <liufengjiang.0426@bytedance.com>
- Fengnan Chang <changfengnan@bytedance.com>
- Fengtian Guo <fengtian.guo@6wind.com>
- Ferdinand Thiessen <rpm@fthiessen.de>
@@ -34 +22 @@
-index c1cb941c43..5d0c0399a8 100644
+index 70121eb340..6811ab55d6 100644
@@ -37,4 +25,4 @@
-@@ -682,6 +682,7 @@ virtqueue_enqueue_xmit_packed(struct virtnet_tx *txvq, struct rte_mbuf *cookie,
- 		 */
- 		start_dp[idx].addr = txvq->hdr_mem + RTE_PTR_DIFF(&txr[idx].tx_hdr, txr);
- 		start_dp[idx].len = vq->hw->vtnet_hdr_size;
+@@ -756,6 +756,7 @@ virtqueue_enqueue_xmit_packed(struct virtnet_tx *txvq, struct rte_mbuf *cookie,
+ 		start_dp[idx].addr  = txvq->virtio_net_hdr_mem +
+ 			RTE_PTR_DIFF(&txr[idx].tx_hdr, txr);
+ 		start_dp[idx].len   = vq->hw->vtnet_hdr_size;

  parent reply	other threads:[~2023-11-08 19:25 UTC|newest]

Thread overview: 111+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-18 23:58 patch 'mempool: fix default ops for an empty mempool' " luca.boccassi
2023-10-18 23:58 ` patch 'rawdev: fix device class in log message' " luca.boccassi
2023-10-18 23:58 ` patch 'net/bonding: fix header for C++' " luca.boccassi
2023-10-18 23:58 ` patch 'net/hns3: fix VF default MAC modified when set failed' " luca.boccassi
2023-10-18 23:58 ` patch 'net/hns3: fix error code for multicast resource' " luca.boccassi
2023-10-18 23:58 ` patch 'net/hns3: fix flushing multicast MAC address' " luca.boccassi
2023-10-18 23:58 ` patch 'app/test: fix reference to master in bonding test' " luca.boccassi
2023-10-18 23:58 ` patch 'net/hns3: fix order in NEON Rx' " luca.boccassi
2023-10-18 23:58 ` patch 'random: initialize state for unregistered non-EAL threads' " luca.boccassi
2023-10-18 23:58 ` patch 'bus/dpaa: fix build with asserts for GCC 13' " luca.boccassi
2023-10-18 23:59 ` patch 'hash: align SSE lookup to scalar implementation' " luca.boccassi
2023-10-18 23:59 ` patch 'net/netvsc: increase VSP response timeout to 60 seconds' " luca.boccassi
2023-10-18 23:59 ` patch 'net/txgbe: add Tx queue maximum limit' " luca.boccassi
2023-10-18 23:59 ` patch 'net/txgbe: reconfigure MAC Rx when link update' " luca.boccassi
2023-10-18 23:59 ` patch 'net/txgbe: keep link down after device close' " luca.boccassi
2023-10-18 23:59 ` patch 'net/txgbe: check process type in close operation' " luca.boccassi
2023-10-18 23:59 ` patch 'net/tap: use MAC address parse API instead of local parser' " luca.boccassi
2023-10-18 23:59 ` patch 'app/testpmd: fix help string' " luca.boccassi
2023-10-18 23:59 ` patch 'cryptodev: add missing doc for security context' " luca.boccassi
2023-10-18 23:59 ` patch 'doc: replace code blocks with includes in security guide' " luca.boccassi
2023-10-18 23:59 ` patch 'test/crypto: fix IV in some vectors' " luca.boccassi
2023-10-18 23:59 ` patch 'test/crypto: skip some synchronous tests with CPU crypto' " luca.boccassi
2023-10-19 10:22   ` Power, Ciara
2023-10-19 10:28   ` Power, Ciara
2023-10-18 23:59 ` patch 'test/crypto: fix typo in asym tests' " luca.boccassi
2023-10-18 23:59 ` patch 'bus/pci: fix device ID log' " luca.boccassi
2023-10-18 23:59 ` patch 'test/event: fix crypto null device creation' " luca.boccassi
2023-10-18 23:59 ` patch 'event/sw: remove obsolete comment' " luca.boccassi
2023-10-18 23:59 ` patch 'event/sw: fix ordering corruption with op release' " luca.boccassi
2023-10-18 23:59 ` patch 'net/i40e: fix FDIR queue receives broadcast packets' " luca.boccassi
2023-10-18 23:59 ` patch 'net/iavf: fix VLAN offload strip flag' " luca.boccassi
2023-10-18 23:59 ` patch 'net/i40e: fix buffer leak on Rx reconfiguration' " luca.boccassi
2023-10-18 23:59 ` patch 'net/iavf: fix port stats clearing' " luca.boccassi
2023-10-18 23:59 ` patch 'net/ice: fix initial link status' " luca.boccassi
2023-10-18 23:59 ` patch 'net/iavf: remove log from Tx prepare function' " luca.boccassi
2023-10-18 23:59 ` patch 'net/iavf: fix TSO with big segments' " luca.boccassi
2023-10-18 23:59 ` patch 'net/ice: remove log from Tx prepare function' " luca.boccassi
2023-10-18 23:59 ` patch 'net/ice: fix TSO with big segments' " luca.boccassi
2023-10-18 23:59 ` patch 'net/mlx5: fix leak in sysfs port name translation' " luca.boccassi
2023-10-18 23:59 ` patch 'fib: fix adding default route overwriting entire table' " luca.boccassi
2023-10-18 23:59 ` patch 'fib6: fix adding default route as first route' " luca.boccassi
2023-10-18 23:59 ` patch 'net/bonding: fix link status callback stop' " luca.boccassi
2023-10-18 23:59 ` patch 'app/procinfo: remove unnecessary rte_malloc' " luca.boccassi
2023-11-08 19:24   ` patch 'malloc: remove return from void functions' " luca.boccassi
2023-11-08 19:25     ` patch 'eventdev: fix device pointer for vdev-based devices' " luca.boccassi
2023-11-08 19:25     ` patch 'eventdev: fix missing driver names in info struct' " luca.boccassi
2023-11-08 19:25     ` luca.boccassi [this message]
2023-11-08 19:25     ` patch 'net/virtio: fix link state interrupt vector setting' " luca.boccassi
2023-11-08 19:25     ` patch 'vhost: fix missing vring call check on virtqueue access' " luca.boccassi
2023-11-08 19:25     ` patch 'vhost: fix missing " luca.boccassi
2023-11-08 19:25     ` patch 'ethdev: fix function name in comment' " luca.boccassi
2023-11-08 19:25     ` patch 'app/testpmd: fix early exit from signal' " luca.boccassi
2023-11-08 19:25     ` patch 'net/hns3: fix unchecked Rx free threshold' " luca.boccassi
2023-11-08 19:25     ` patch 'net/hns3: fix crash for NEON and SVE' " luca.boccassi
2023-11-08 19:25     ` patch 'net/hns3: fix double stats for IMP and global reset' " luca.boccassi
2023-11-08 19:25     ` patch 'net/hns3: remove reset log in secondary' " luca.boccassi
2023-11-08 19:25     ` patch 'test/bonding: remove unreachable statement' " luca.boccassi
2023-11-08 19:25     ` patch 'test/bonding: add missing check' " luca.boccassi
2023-11-08 19:25     ` patch 'net/bonding: fix possible overrun' " luca.boccassi
2023-11-08 19:25     ` patch 'net/txgbe: add proper memory barriers in Rx' " luca.boccassi
2023-11-08 19:25     ` patch 'ethdev: fix 32-bit build with GCC 13' " luca.boccassi
2023-11-08 19:25     ` patch 'net/enic: avoid extra unlock in MTU set' " luca.boccassi
2023-11-08 19:25     ` patch 'net/hns3: fix setting DCB capability' " luca.boccassi
2023-11-08 19:25     ` patch 'net/hns3: fix some return values' " luca.boccassi
2023-11-08 19:25     ` patch 'net/hns3: fix some error logs' " luca.boccassi
2023-11-08 19:25     ` patch 'net/hns3: keep set/get algo key functions local' " luca.boccassi
2023-11-08 19:25     ` patch 'net/hns3: fix uninitialized hash algo value' " luca.boccassi
2023-11-08 19:25     ` patch 'net/tap: fix L4 checksum offloading' " luca.boccassi
2023-11-08 19:25     ` patch 'net/tap: fix IPv4 " luca.boccassi
2023-11-08 19:25     ` patch 'app/procinfo: fix RSS info' " luca.boccassi
2023-11-08 19:25     ` patch 'app/procinfo: adjust format of " luca.boccassi
2023-11-08 19:25     ` patch 'net/nfp: fix link status interrupt' " luca.boccassi
2023-11-08 19:25     ` patch 'net/nfp: fix DMA error after abnormal exit' " luca.boccassi
2023-11-08 19:25     ` patch 'net/tap: fix RSS for fragmented packets' " luca.boccassi
2023-11-08 19:25     ` patch 'common/mlx5: fix controller index parsing' " luca.boccassi
2023-11-08 19:25     ` patch 'net/ice: fix L1 check interval' " luca.boccassi
2023-11-08 19:25     ` patch 'net/ice: fix DCF port statistics' " luca.boccassi
2023-11-08 19:25     ` patch 'crypto/nitrox: fix panic with high number of segments' " luca.boccassi
2023-11-08 19:25     ` patch 'net/iavf: fix Tx preparation' " luca.boccassi
2023-11-08 19:25     ` patch 'net/ice: " luca.boccassi
2023-11-15 11:45       ` patch 'event/dlb2: fix name check in self-test' " luca.boccassi
2023-11-15 11:45         ` patch 'test/bbdev: fix Python script subprocess' " luca.boccassi
2023-11-15 11:45         ` patch 'test/bbdev: assert failed test for queue configure' " luca.boccassi
2023-11-15 11:45         ` patch 'event/dlb2: fix missing queue ordering capability flag' " luca.boccassi
2023-11-15 11:45         ` patch 'meter: fix RFC4115 trTCM API Doxygen' " luca.boccassi
2023-11-15 11:45         ` patch 'app/testpmd: remove useless check in TSO command' " luca.boccassi
2023-11-15 11:45         ` patch 'test/bonding: fix uninitialized RSS configuration' " luca.boccassi
2023-11-15 11:45         ` patch 'net/hns3: fix mailbox sync' " luca.boccassi
2023-11-15 11:45         ` patch 'app/testpmd: fix tunnel TSO capability check' " luca.boccassi
2023-11-15 11:45         ` patch 'app/testpmd: add explicit check for tunnel TSO' " luca.boccassi
2023-11-15 11:45         ` patch 'app/testpmd: fix tunnel TSO configuration' " luca.boccassi
2023-11-15 11:45         ` patch 'net/mlx5: fix hairpin queue unbind' " luca.boccassi
2023-11-15 11:45         ` patch 'net/mlx5: fix hairpin queue states' " luca.boccassi
2023-11-15 11:45         ` patch 'net/mlx5: fix multi-segment Tx inline data length' " luca.boccassi
2023-11-15 11:45         ` patch 'net/mlx5: zero UDP checksum over IPv4 in encapsulation' " luca.boccassi
2023-11-15 11:45         ` patch 'net/mlx5: fix MPRQ stride size check' " luca.boccassi
2023-11-23 16:17           ` patch 'net/txgbe: fix out of bound access' " luca.boccassi
2023-11-23 16:17             ` patch 'doc: update features in hns3 guide' " luca.boccassi
2023-11-23 16:17             ` patch 'doc: update versions recommendations for i40e and ice' " luca.boccassi
2023-11-23 16:17             ` patch 'examples/ipsec-secgw: fix partial overflow' " luca.boccassi
2023-11-23 16:17             ` patch 'eal/windows: fix build with recent MinGW' " luca.boccassi
2023-11-23 16:17             ` patch 'pdump: fix error number on IPC response' " luca.boccassi
2023-11-23 16:17             ` patch 'examples/ethtool: fix pause configuration' " luca.boccassi
2023-11-23 16:17             ` patch 'test/hash: fix creation error log' " luca.boccassi
2023-11-23 16:17             ` patch 'app/pipeline: add sigint handler' " luca.boccassi
2023-11-29  2:32               ` patch 'doc: remove restriction on ixgbe vector support' " luca.boccassi
2023-11-29  2:32                 ` patch 'doc: fix some ordered lists' " luca.boccassi
2023-11-29  2:32                 ` patch 'doc: remove number of commands in vDPA guide' " luca.boccassi
2023-11-29  2:32                 ` patch 'mempool: fix get function documentation' " luca.boccassi
2023-11-29  2:32                 ` patch 'mempool: clarify enqueue/dequeue ops " luca.boccassi
2023-11-29  2:32                 ` patch 'ethdev: fix ESP packet type description' " luca.boccassi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231108192535.922238-4-luca.boccassi@gmail.com \
    --to=luca.boccassi@gmail.com \
    --cc=liufengjiang.0426@bytedance.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).