RE: patch 'test/crypto: skip some synchronous tests with CPU crypto' has been queued to stable release 20.11.10

["Power, Ciara" <ciara.power@intel.com>]

> -----Original Message-----
> From: Power, Ciara
> Sent: Thursday, October 19, 2023 11:22 AM
> To: luca.boccassi@gmail.com; Dooley, Brian <brian.dooley@intel.com>
> Cc: stable@dpdk.org
> Subject: RE: patch 'test/crypto: skip some synchronous tests with CPU crypto'
> has been queued to stable release 20.11.10
> 
> Hi Luca,
> 
> 
> > -----Original Message-----
> > From: luca.boccassi@gmail.com <luca.boccassi@gmail.com>
> > Sent: Thursday, October 19, 2023 12:59 AM
> > To: Dooley, Brian <brian.dooley@intel.com>
> > Cc: Power, Ciara <ciara.power@intel.com>; dpdk stable
> > <stable@dpdk.org>
> > Subject: patch 'test/crypto: skip some synchronous tests with CPU
> > crypto' has been queued to stable release 20.11.10
> >
> > Hi,
> >
> > FYI, your patch has been queued to stable release 20.11.10
> >
> > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
> > It will be pushed if I get no objections before 10/21/23. So please
> > shout if anyone has objections.
> 
> This upstream patch is not applicable to 16.11 (the functions do not exist yet).
> The changes below are redundant, as those Kasumi test functions already
> have the required checks.

Apologies Luca, I misread the DPDK version number somehow..

The fixes are needed for 20.11, but the fixes shown in diff before are for the wrong functions.
I will send a patch for 20.11 directly for this.

Thanks,
Ciara



> 
> Thanks,
> Ciara
> 
> 
> 
> >
> > Also note that after the patch there's a diff of the upstream commit
> > vs the patch applied to the branch. This will indicate if there was
> > any rebasing needed to apply to the stable branch. If there were code
> > changes for rebasing
> > (ie: not only metadata diffs), please double check that the rebase was
> > correctly done.
> >
> > Queued patches are on a temporary branch at:
> > https://github.com/bluca/dpdk-stable
> >
> > This queued commit can be viewed at:
> > https://github.com/bluca/dpdk-
> > stable/commit/d513b356f406691db94c8e141dd3c594c991d0b6
> >
> > Thanks.
> >
> > Luca Boccassi
> >
> > ---
> > From d513b356f406691db94c8e141dd3c594c991d0b6 Mon Sep 17
> > 00:00:00 2001
> > From: Brian Dooley <brian.dooley@intel.com>
> > Date: Tue, 19 Sep 2023 10:42:17 +0000
> > Subject: [PATCH] test/crypto: skip some synchronous tests with CPU
> > crypto
> >
> > [ upstream commit 38318ce05459391344acb53a73c9a99537a0bd0f ]
> >
> > Some synchronous tests are not supported for CPU crypto and need to be
> > skipped. This commit adds in extra skips for these tests.
> >
> > Fixes: 55ab4a8c4fb5 ("test/crypto: disable wireless cases for CPU
> > crypto API")
> >
> > Signed-off-by: Brian Dooley <brian.dooley@intel.com>
> > Acked-by: Ciara Power <ciara.power@intel.com>
> > ---
> >  app/test/test_cryptodev.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
> > index
> > 2e76763e09..694ba45e85 100644
> > --- a/app/test/test_cryptodev.c
> > +++ b/app/test/test_cryptodev.c
> > @@ -3673,6 +3673,9 @@ test_kasumi_decryption(const struct
> > kasumi_test_data *tdata)
> >  	unsigned ciphertext_len;
> >  	struct rte_cryptodev_info dev_info;
> >
> > +	if (gbl_action_type == RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO)
> > +		return TEST_SKIPPED;
> > +
> >  	rte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info);
> >  	uint64_t feat_flags = dev_info.feature_flags;
> >
> > @@ -4997,6 +5000,9 @@ test_kasumi_auth_cipher(const struct
> > kasumi_test_data *tdata,
> >  			&cap_idx) == NULL)
> >  		return -ENOTSUP;
> >
> > +	if (gbl_action_type == RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO)
> > +		return TEST_SKIPPED;
> > +
> >  	rte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info);
> >
> >  	uint64_t feat_flags = dev_info.feature_flags;
> > --
> > 2.39.2
> >
> > ---
> >   Diff of the applied patch vs upstream commit (please double-check if
> > non-
> > empty:
> > ---
> > --- -	2023-10-19 00:28:57.347017140 +0100
> > +++ 0022-test-crypto-skip-some-synchronous-tests-with-CPU-cry.patch
> > 	2023-10-19 00:28:56.261805684 +0100
> > @@ -1 +1 @@
> > -From 38318ce05459391344acb53a73c9a99537a0bd0f Mon Sep 17
> > 00:00:00 2001
> > +From d513b356f406691db94c8e141dd3c594c991d0b6 Mon Sep 17
> > 00:00:00 2001
> > @@ -5,0 +6,2 @@
> > +[ upstream commit 38318ce05459391344acb53a73c9a99537a0bd0f ]
> > +
> > @@ -10 +11,0 @@
> > -Cc: stable@dpdk.org
> > @@ -19 +20 @@
> > -index 8fc90342de..aff1c8e55b 100644
> > +index 2e76763e09..694ba45e85 100644
> > @@ -22,3 +23,3 @@
> > -@@ -6394,6 +6394,9 @@ test_zuc_auth_cipher(const struct
> > wireless_test_data *tdata,
> > - 			tdata->digest.len) < 0)
> > - 		return TEST_SKIPPED;
> > +@@ -3673,6 +3673,9 @@ test_kasumi_decryption(const struct
> > kasumi_test_data *tdata)
> > + 	unsigned ciphertext_len;
> > + 	struct rte_cryptodev_info dev_info;
> > @@ -30 +30,0 @@
> > -
> > @@ -32,3 +32,4 @@
> > -@@ -7829,6 +7832,9 @@ test_mixed_auth_cipher(const struct
> > mixed_cipher_auth_test_data *tdata,
> > - 	if (global_api_test_type == CRYPTODEV_RAW_API_TEST)
> > - 		return TEST_SKIPPED;
> > +
> > +@@ -4997,6 +5000,9 @@ test_kasumi_auth_cipher(const struct
> > kasumi_test_data *tdata,
> > + 			&cap_idx) == NULL)
> > + 		return -ENOTSUP;