patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Varghese, Vipin" <vipin.varghese@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] examples/bpf: fix compilation issue
Date: Wed, 31 Jul 2019 07:04:31 +0000	[thread overview]
Message-ID: <2601191342CEEE43887BDE71AB9772580168A5FD47@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D399F1E@BGSMSX101.gar.corp.intel.com>


> 
> > Example BPF programs t1.c, t2.c, t3.c in folder examples/bpf are failing to
> > compile with latest dpdk.org master.
> 
> As a note, the file t3.c is one which fails to get compiled.

t2.c also uses rte_mbuf, so same story  for both. 

> 
> > The reason is changes in some core DPDK header files, that causes now inclusion
> > of x86 specific headers.
> 
> snipped
> 
> 
> >
> >  #include <stdint.h>
> >  #include <rte_common.h>
> > -#include <rte_memory.h>
> >
> >  #ifdef __cplusplus
> >  extern "C" {
> > @@ -364,6 +363,23 @@ typedef struct {
> >  	volatile int16_t cnt; /**< An internal counter value. */  } rte_atomic16_t;
> >
> > +#define RTE_CACHE_LINE_MIN_SIZE 64      /**< Minimum Cache line size. */
> 
> The definition for RTE_CACHE_LINE_MIN_SIZE is present in ` rte_config.h`.

I believe it is not:
$ find lib config -type f | xargs grep CACHE_LINE_MIN_SIZE
lib/librte_eal/linux/eal/include/rte_kni_common.h:#define RTE_CACHE_LINE_MIN_SIZE 64
lib/librte_eal/linux/eal/include/rte_kni_common.h:      char pad3[8] __attribute__((__aligned__(RTE_CACHE_LINE_MIN_SIZE)));
lib/librte_eal/common/include/rte_memory.h:#define RTE_CACHE_LINE_MIN_SIZE 64  /**< Minimum Cache line size. */
lib/librte_eal/common/include/rte_memory.h:#define __rte_cache_min_aligned __rte_aligned(RTE_CACHE_LINE_MIN_SIZE)

Konstantin

  reply	other threads:[~2019-07-31  7:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30 10:19 [dpdk-stable] " Konstantin Ananyev
2019-07-31  3:16 ` [dpdk-stable] [dpdk-dev] " Varghese, Vipin
2019-07-31  7:04   ` Ananyev, Konstantin [this message]
2019-07-31  8:20     ` Varghese, Vipin
2019-07-31  8:22       ` Ananyev, Konstantin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2601191342CEEE43887BDE71AB9772580168A5FD47@irsmsx105.ger.corp.intel.com \
    --to=konstantin.ananyev@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=vipin.varghese@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).