patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Varghese, Vipin" <vipin.varghese@intel.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] examples/bpf: fix compilation issue
Date: Wed, 31 Jul 2019 03:16:41 +0000	[thread overview]
Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D399F1E@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <20190730101927.1665-1-konstantin.ananyev@intel.com>

snipped

> Example BPF programs t1.c, t2.c, t3.c in folder examples/bpf are failing to
> compile with latest dpdk.org master.

As a note, the file t3.c is one which fails to get compiled.

> The reason is changes in some core DPDK header files, that causes now inclusion
> of x86 specific headers.

snipped


> 
>  #include <stdint.h>
>  #include <rte_common.h>
> -#include <rte_memory.h>
> 
>  #ifdef __cplusplus
>  extern "C" {
> @@ -364,6 +363,23 @@ typedef struct {
>  	volatile int16_t cnt; /**< An internal counter value. */  } rte_atomic16_t;
> 
> +#define RTE_CACHE_LINE_MIN_SIZE 64      /**< Minimum Cache line size. */

The definition for RTE_CACHE_LINE_MIN_SIZE is present in ` rte_config.h`. Using the same did not cause compilation issues. Is there specific reason not to use the same?

Snipped

The code is tested and verified with clang6.0 and clang8.0 on Ubuntu 18.04.2 LTS.

Tested-by: Vipin Varghese <vipin.varghese@intel.com>


  reply	other threads:[~2019-07-31  3:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30 10:19 [dpdk-stable] " Konstantin Ananyev
2019-07-31  3:16 ` Varghese, Vipin [this message]
2019-07-31  7:04   ` [dpdk-stable] [dpdk-dev] " Ananyev, Konstantin
2019-07-31  8:20     ` Varghese, Vipin
2019-07-31  8:22       ` Ananyev, Konstantin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C9E0AB70F954A408CC4ADDBF0F8FA7D4D399F1E@BGSMSX101.gar.corp.intel.com \
    --to=vipin.varghese@intel.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).