patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Chaoyong He <chaoyong.he@corigine.com>, dev@dpdk.org
Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, stable@dpdk.org
Subject: Re: [PATCH] net/nfp: fix teardown of flows sharing a mask ID
Date: Thu, 26 Jan 2023 09:14:06 +0000	[thread overview]
Message-ID: <2985c90e-3d71-cd99-e1d6-2353ba97574a@amd.com> (raw)
In-Reply-To: <20230124071631.38272-1-chaoyong.he@corigine.com>

On 1/24/2023 7:16 AM, Chaoyong He wrote:
> The same data in mask section of different flow add/delete control
> messages will share the same mask ID of mask table.  The first flow
> add control message and the last flow delete control message for a
> specific mask ID should have the NFP_FL_META_FLAG_MANAGE_MASK flag set,
> this will indicate to the flower firmware to allocate/deallocate the
> mask table entry.
> 
> The original logic wrongly process the flow delete control message,
> and caused the first flow delete control message to have the
> NFP_FL_META_FLAG_MANAGE_MASK flagset, thus the flower firmware
> deallocate the mask table entry on the first delete. This in turn
> prevented all the other flows sharing the same mask ID from offloading.
> 
> Fixes: ac09376096d8 ("net/nfp: add structures and functions for flow offload")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>

Applied to dpdk-next-net/main, thanks.

      reply	other threads:[~2023-01-26  9:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-24  7:16 Chaoyong He
2023-01-26  9:14 ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2985c90e-3d71-cd99-e1d6-2353ba97574a@amd.com \
    --to=ferruh.yigit@amd.com \
    --cc=chaoyong.he@corigine.com \
    --cc=dev@dpdk.org \
    --cc=niklas.soderlund@corigine.com \
    --cc=oss-drivers@corigine.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).