patches for DPDK stable branches
 help / color / Atom feed
* [dpdk-stable] [PATCH v1] net/tap: fix blocked rx packets error
@ 2019-09-02 11:43 Marcin Smoczynski
  2019-09-03 13:15 ` Ananyev, Konstantin
  2019-09-05  5:43 ` [dpdk-stable] [dpdk-dev] " Gavin Hu (Arm Technology China)
  0 siblings, 2 replies; 4+ messages in thread
From: Marcin Smoczynski @ 2019-09-02 11:43 UTC (permalink / raw)
  To: konstantin.ananyev, keith.wiles, adrien.mazarguil
  Cc: dev, stable, Marcin Smoczynski, Mariusz Drost

When OS sends more packets than are beaing read with a single
'rte_eth_rx_burst' call, rx packets are getting stucked in the tap pmd
and are unable to receive, because trigger_seen is getting updated
and consecutive calls are not getting any packets.

Do not update trigger_seen unless less than a max number of packets were
received allowing next call to receive the rest.

Fixes: a0d8e807d9 ("net/tap: add Rx trigger")
Cc: stable@dpdk.org

Tested-by: Mariusz Drost <mariuszx.drost@intel.com>
Signed-off-by: Marcin Smoczynski <marcinx.smoczynski@intel.com>
---
 drivers/net/tap/rte_eth_tap.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 64bd04911..60121ae56 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -353,8 +353,7 @@ pmd_rx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
 
 	if (trigger == rxq->trigger_seen)
 		return 0;
-	if (trigger)
-		rxq->trigger_seen = trigger;
+
 	process_private = rte_eth_devices[rxq->in_port].process_private;
 	rte_compiler_barrier();
 	for (num_rx = 0; num_rx < nb_pkts; ) {
@@ -433,6 +432,9 @@ pmd_rx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
 	rxq->stats.ipackets += num_rx;
 	rxq->stats.ibytes += num_rx_bytes;
 
+	if (trigger && num_rx < nb_pkts)
+		rxq->trigger_seen = trigger;
+
 	return num_rx;
 }
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [PATCH v1] net/tap: fix blocked rx packets error
  2019-09-02 11:43 [dpdk-stable] [PATCH v1] net/tap: fix blocked rx packets error Marcin Smoczynski
@ 2019-09-03 13:15 ` Ananyev, Konstantin
  2019-09-05  5:43 ` [dpdk-stable] [dpdk-dev] " Gavin Hu (Arm Technology China)
  1 sibling, 0 replies; 4+ messages in thread
From: Ananyev, Konstantin @ 2019-09-03 13:15 UTC (permalink / raw)
  To: Smoczynski, MarcinX, Wiles, Keith, adrien.mazarguil
  Cc: dev, stable, Drost, MariuszX



> -----Original Message-----
> From: Smoczynski, MarcinX
> Sent: Monday, September 2, 2019 12:43 PM
> To: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Wiles, Keith <keith.wiles@intel.com>; adrien.mazarguil@6wind.com
> Cc: dev@dpdk.org; stable@dpdk.org; Smoczynski, MarcinX <marcinx.smoczynski@intel.com>; Drost, MariuszX <mariuszx.drost@intel.com>
> Subject: [PATCH v1] net/tap: fix blocked rx packets error
> 
> When OS sends more packets than are beaing read with a single
> 'rte_eth_rx_burst' call, rx packets are getting stucked in the tap pmd
> and are unable to receive, because trigger_seen is getting updated
> and consecutive calls are not getting any packets.
> 
> Do not update trigger_seen unless less than a max number of packets were
> received allowing next call to receive the rest.
> 
> Fixes: a0d8e807d9 ("net/tap: add Rx trigger")
> Cc: stable@dpdk.org
> 
> Tested-by: Mariusz Drost <mariuszx.drost@intel.com>
> Signed-off-by: Marcin Smoczynski <marcinx.smoczynski@intel.com>
> ---
>  drivers/net/tap/rte_eth_tap.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 64bd04911..60121ae56 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -353,8 +353,7 @@ pmd_rx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
> 
>  	if (trigger == rxq->trigger_seen)
>  		return 0;
> -	if (trigger)
> -		rxq->trigger_seen = trigger;
> +
>  	process_private = rte_eth_devices[rxq->in_port].process_private;
>  	rte_compiler_barrier();
>  	for (num_rx = 0; num_rx < nb_pkts; ) {
> @@ -433,6 +432,9 @@ pmd_rx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
>  	rxq->stats.ipackets += num_rx;
>  	rxq->stats.ibytes += num_rx_bytes;
> 
> +	if (trigger && num_rx < nb_pkts)
> +		rxq->trigger_seen = trigger;
> +
>  	return num_rx;
>  }
> 
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Tested-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

> 2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v1] net/tap: fix blocked rx packets error
  2019-09-02 11:43 [dpdk-stable] [PATCH v1] net/tap: fix blocked rx packets error Marcin Smoczynski
  2019-09-03 13:15 ` Ananyev, Konstantin
@ 2019-09-05  5:43 ` " Gavin Hu (Arm Technology China)
  2019-09-06  8:48   ` Smoczynski, MarcinX
  1 sibling, 1 reply; 4+ messages in thread
From: Gavin Hu (Arm Technology China) @ 2019-09-05  5:43 UTC (permalink / raw)
  To: Marcin Smoczynski, konstantin.ananyev, keith.wiles, adrien.mazarguil
  Cc: dev, stable, Mariusz Drost

HI Marcin,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Marcin Smoczynski
> Sent: Monday, September 2, 2019 7:43 PM
> To: konstantin.ananyev@intel.com; keith.wiles@intel.com;
> adrien.mazarguil@6wind.com
> Cc: dev@dpdk.org; stable@dpdk.org; Marcin Smoczynski
> <marcinx.smoczynski@intel.com>; Mariusz Drost
> <mariuszx.drost@intel.com>
> Subject: [dpdk-dev] [PATCH v1] net/tap: fix blocked rx packets error
>
> When OS sends more packets than are beaing read with a single
s/ beaing/being

> 'rte_eth_rx_burst' call, rx packets are getting stucked in the tap pmd
> and are unable to receive, because trigger_seen is getting updated
> and consecutive calls are not getting any packets.
>
> Do not update trigger_seen unless less than a max number of packets were
> received allowing next call to receive the rest.
>
> Fixes: a0d8e807d9 ("net/tap: add Rx trigger")
> Cc: stable@dpdk.org
>
> Tested-by: Mariusz Drost <mariuszx.drost@intel.com>
> Signed-off-by: Marcin Smoczynski <marcinx.smoczynski@intel.com>
> ---
>  drivers/net/tap/rte_eth_tap.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 64bd04911..60121ae56 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -353,8 +353,7 @@ pmd_rx_burst(void *queue, struct rte_mbuf **bufs,
> uint16_t nb_pkts)
>
>       if (trigger == rxq->trigger_seen)
>               return 0;
> -     if (trigger)
> -             rxq->trigger_seen = trigger;
> +
>       process_private = rte_eth_devices[rxq->in_port].process_private;
>       rte_compiler_barrier();
I see this compiler barrier was added together with the above "rxq->trigger_seen = trigger", should it be removed or moved together downwards?

>       for (num_rx = 0; num_rx < nb_pkts; ) {
> @@ -433,6 +432,9 @@ pmd_rx_burst(void *queue, struct rte_mbuf **bufs,
> uint16_t nb_pkts)
>       rxq->stats.ipackets += num_rx;
>       rxq->stats.ibytes += num_rx_bytes;
>
> +     if (trigger && num_rx < nb_pkts)
> +             rxq->trigger_seen = trigger;
> +
>       return num_rx;
>  }
>
> --
> 2.17.1

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v1] net/tap: fix blocked rx packets error
  2019-09-05  5:43 ` [dpdk-stable] [dpdk-dev] " Gavin Hu (Arm Technology China)
@ 2019-09-06  8:48   ` Smoczynski, MarcinX
  0 siblings, 0 replies; 4+ messages in thread
From: Smoczynski, MarcinX @ 2019-09-06  8:48 UTC (permalink / raw)
  To: Gavin Hu (Arm Technology China),
	Ananyev, Konstantin, Wiles, Keith, adrien.mazarguil
  Cc: dev, stable, Drost, MariuszX



> -----Original Message-----
> From: Gavin Hu (Arm Technology China) [mailto:Gavin.Hu@arm.com]
> Sent: Thursday, September 5, 2019 7:44 AM
> To: Smoczynski, MarcinX <marcinx.smoczynski@intel.com>; Ananyev,
> Konstantin <konstantin.ananyev@intel.com>; Wiles, Keith
> <keith.wiles@intel.com>; adrien.mazarguil@6wind.com
> Cc: dev@dpdk.org; stable@dpdk.org; Drost, MariuszX
> <mariuszx.drost@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v1] net/tap: fix blocked rx packets error
> 
> HI Marcin,
> 
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Marcin Smoczynski
> > Sent: Monday, September 2, 2019 7:43 PM
> > To: konstantin.ananyev@intel.com; keith.wiles@intel.com;
> > adrien.mazarguil@6wind.com
> > Cc: dev@dpdk.org; stable@dpdk.org; Marcin Smoczynski
> > <marcinx.smoczynski@intel.com>; Mariusz Drost
> > <mariuszx.drost@intel.com>
> > Subject: [dpdk-dev] [PATCH v1] net/tap: fix blocked rx packets error
> >
> > When OS sends more packets than are beaing read with a single
> s/ beaing/being

Thanks for that, will be corrected in the v2.

> 
> > 'rte_eth_rx_burst' call, rx packets are getting stucked in the tap pmd
> > and are unable to receive, because trigger_seen is getting updated and
> > consecutive calls are not getting any packets.
> >
> > Do not update trigger_seen unless less than a max number of packets
> > were received allowing next call to receive the rest.
> >
> > Fixes: a0d8e807d9 ("net/tap: add Rx trigger")
> > Cc: stable@dpdk.org
> >
> > Tested-by: Mariusz Drost <mariuszx.drost@intel.com>
> > Signed-off-by: Marcin Smoczynski <marcinx.smoczynski@intel.com>
> > ---
> >  drivers/net/tap/rte_eth_tap.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/tap/rte_eth_tap.c
> > b/drivers/net/tap/rte_eth_tap.c index 64bd04911..60121ae56 100644
> > --- a/drivers/net/tap/rte_eth_tap.c
> > +++ b/drivers/net/tap/rte_eth_tap.c
> > @@ -353,8 +353,7 @@ pmd_rx_burst(void *queue, struct rte_mbuf
> **bufs,
> > uint16_t nb_pkts)
> >
> >       if (trigger == rxq->trigger_seen)
> >               return 0;
> > -     if (trigger)
> > -             rxq->trigger_seen = trigger;
> > +
> >       process_private = rte_eth_devices[rxq->in_port].process_private;
> >       rte_compiler_barrier();
> I see this compiler barrier was added together with the above "rxq-
> >trigger_seen = trigger", should it be removed or moved together
> downwards?

I think it could be removed, but it is best to ask author of the original code.
Adrien, what do you think about removing this barrier?
 

> 
> >       for (num_rx = 0; num_rx < nb_pkts; ) { @@ -433,6 +432,9 @@
> > pmd_rx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
> >       rxq->stats.ipackets += num_rx;
> >       rxq->stats.ibytes += num_rx_bytes;
> >
> > +     if (trigger && num_rx < nb_pkts)
> > +             rxq->trigger_seen = trigger;
> > +
> >       return num_rx;
> >  }
> >
> > --
> > 2.17.1
> 
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended recipient,
> please notify the sender immediately and do not disclose the contents to any
> other person, use it for any purpose, or store or copy the information in any
> medium. Thank you.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-02 11:43 [dpdk-stable] [PATCH v1] net/tap: fix blocked rx packets error Marcin Smoczynski
2019-09-03 13:15 ` Ananyev, Konstantin
2019-09-05  5:43 ` [dpdk-stable] [dpdk-dev] " Gavin Hu (Arm Technology China)
2019-09-06  8:48   ` Smoczynski, MarcinX

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox