patches for DPDK stable branches
 help / color / Atom feed
* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix wrong value of tc ov weight
       [not found] ` <20190806114951.62131-1-jasvinder.singh@intel.com>
@ 2019-08-06 13:26   ` Thomas Monjalon
  2019-09-04 17:26     ` Kevin Traynor
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Monjalon @ 2019-08-06 13:26 UTC (permalink / raw)
  To: Jasvinder Singh; +Cc: dev, cristian.dumitrescu, stable

06/08/2019 13:49, Jasvinder Singh:
> The sched library checks the subport tc ov weight value regardless
> of whether RTE_SCHED_SUBPORT_TC_OV flag is enabled or not.
> 
> This fix allows application to always set valid tc ov weight value.
> 
> Fixes: 25961ff3bcb9 ("examples/ip_pipeline: add traffic manager object")
> 
> error log
> SCHED: pipe_profile_check: Incorrect value for tc ov weight
> SCHED: rte_sched_port_check_params: Pipe profile check failed(-22)
> Command "tmgr" failed.
> 
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> ---
> v2:
> - add fix line
> - change title

"tc ov" is not that obvious.
I changed the title to "examples/ip_pipeline: fix TC oversubscription weight"

+Add Cc stable

Applied, thanks



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix wrong value of tc ov weight
  2019-08-06 13:26   ` [dpdk-stable] [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix wrong value of tc ov weight Thomas Monjalon
@ 2019-09-04 17:26     ` Kevin Traynor
  0 siblings, 0 replies; 2+ messages in thread
From: Kevin Traynor @ 2019-09-04 17:26 UTC (permalink / raw)
  To: Jasvinder Singh; +Cc: Thomas Monjalon, dev, cristian.dumitrescu, stable

On 06/08/2019 14:26, Thomas Monjalon wrote:
> 06/08/2019 13:49, Jasvinder Singh:
>> The sched library checks the subport tc ov weight value regardless
>> of whether RTE_SCHED_SUBPORT_TC_OV flag is enabled or not.
>>
>> This fix allows application to always set valid tc ov weight value.
>>
>> Fixes: 25961ff3bcb9 ("examples/ip_pipeline: add traffic manager object")
>>

FYI, tc_ov_weight is not visible without the RTE_SCHED_SUBPORT_TC_OV until

Fixes: ca4d5915b877 ("sched: add config flexibility to TC queue sizes")

so this will not build on 18.11 stable.

>> error log
>> SCHED: pipe_profile_check: Incorrect value for tc ov weight
>> SCHED: rte_sched_port_check_params: Pipe profile check failed(-22)
>> Command "tmgr" failed.
>>
>> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
>> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>> ---
>> v2:
>> - add fix line
>> - change title
> 
> "tc ov" is not that obvious.
> I changed the title to "examples/ip_pipeline: fix TC oversubscription weight"
> 
> +Add Cc stable
> 
> Applied, thanks
> 
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20190731113322.135053-1-jasvinder.singh@intel.com>
     [not found] ` <20190806114951.62131-1-jasvinder.singh@intel.com>
2019-08-06 13:26   ` [dpdk-stable] [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix wrong value of tc ov weight Thomas Monjalon
2019-09-04 17:26     ` Kevin Traynor

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox