Re: [PATCH 20.11 1/2] crypto/ipsec_mb: fix length and offset settings

[Kevin Traynor <ktraynor@redhat.com>]

Hi Pablo,

On 14/03/2022 11:05, Pablo de Lara wrote:
> [ upstream commit a501609ea6466ed8526c0dfadedee332a4d4a451 ]
> 
> KASUMI, SNOW3G and ZUC require lengths and offsets to
> be set in bits or bytes depending on the algorithm.
> There were some algorithms that were mixing these two,
> so this commit is fixing this issue.
> 
> Fixes: ae8e085c608d ("crypto/aesni_mb: support KASUMI F8/F9")
> Fixes: 6c42e0cf4d12 ("crypto/aesni_mb: support SNOW3G-UEA2/UIA2")
> Fixes: fd8df85487c4 ("crypto/aesni_mb: support ZUC-EEA3/EIA3")
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---

For 21.11. I backported and applied a501609ea6466 from dpdk main branch 
to 21.11 branch [0]. The version sent here directly to 20.11 is quite 
different as it adds the 'switch (job->cipher_mode)'. (It feels like 
some other patch adding 'switch (job->cipher_mode)' was missed for 
backported)

As this switch is not in [0], the following GMAC patch [1] won't apply 
for 21.11.

One option is that you send a patch to just add the missing parts, and 
then I apply the GMAC patch.

But the simplest option is that I revert [0], apply updated 20.11 
version + GMAC patch.

I'll go with the latter option (assuming they apply cleanly), but please 
let me know if that sounds ok.

thanks,
Kevin

[0] 
http://git.dpdk.org/dpdk-stable/commit/?h=21.11&id=daf06c45e8576d8a2a86455e33e2bc4574f8f8b4

[1] 837269c2e5c5 ("crypto/ipsec_mb: fix GMAC parameters setting")