patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH 18.11] net/mlx5: remove unused variable in Tx queue creation
@ 2020-12-08 14:22 Michael Baum
  2020-12-10 10:14 ` Kevin Traynor
  0 siblings, 1 reply; 2+ messages in thread
From: Michael Baum @ 2020-12-08 14:22 UTC (permalink / raw)
  To: stable; +Cc: ktraynor, viacheslavo

[ upstream commit fa2dd3d4d6e24bf2956828bf05de86e6e6d88c3e ]

When a CQ is not created by DevX, it be allocated by either DV function
or by regular Verbs function.

The CQ DV attributes variable was wrongly defined and initialized in Tx
queue creation while the CQ is created by the regular Verbs function
what remained the attributes variable unused.

Remove the unused variable.

Fixes: faf2667fe8d5 ("net/mlx5: separate DPDK from verbs Tx queue objects")

Signed-off-by: Michael Baum <michaelba@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
 drivers/net/mlx5/mlx5_txq.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c
index 42ab34a..89580dd 100644
--- a/drivers/net/mlx5/mlx5_txq.c
+++ b/drivers/net/mlx5/mlx5_txq.c
@@ -405,7 +405,6 @@ struct mlx5_txq_ibv *
 	struct mlx5_txq_ibv *txq_ibv = NULL;
 	union {
 		struct ibv_qp_init_attr_ex init;
-		struct ibv_cq_init_attr_ex cq;
 		struct ibv_qp_attr mod;
 	} attr;
 	unsigned int cqe_n;
@@ -427,9 +426,6 @@ struct mlx5_txq_ibv *
 		return NULL;
 	}
 	memset(&tmpl, 0, sizeof(struct mlx5_txq_ibv));
-	attr.cq = (struct ibv_cq_init_attr_ex){
-		.comp_mask = 0,
-	};
 	cqe_n = ((desc / MLX5_TX_COMP_THRESH) - 1) ?
 		((desc / MLX5_TX_COMP_THRESH) - 1) : 1;
 	if (is_empw_burst_func(tx_pkt_burst))
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-stable] [PATCH 18.11] net/mlx5: remove unused variable in Tx queue creation
  2020-12-08 14:22 [dpdk-stable] [PATCH 18.11] net/mlx5: remove unused variable in Tx queue creation Michael Baum
@ 2020-12-10 10:14 ` Kevin Traynor
  0 siblings, 0 replies; 2+ messages in thread
From: Kevin Traynor @ 2020-12-10 10:14 UTC (permalink / raw)
  To: Michael Baum, stable; +Cc: viacheslavo

On 08/12/2020 14:22, Michael Baum wrote:
> [ upstream commit fa2dd3d4d6e24bf2956828bf05de86e6e6d88c3e ]
> 
> When a CQ is not created by DevX, it be allocated by either DV function
> or by regular Verbs function.
> 
> The CQ DV attributes variable was wrongly defined and initialized in Tx
> queue creation while the CQ is created by the regular Verbs function
> what remained the attributes variable unused.
> 
> Remove the unused variable.
> 
> Fixes: faf2667fe8d5 ("net/mlx5: separate DPDK from verbs Tx queue objects")
> 
> Signed-off-by: Michael Baum <michaelba@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
>  drivers/net/mlx5/mlx5_txq.c | 4 ----
>  1 file changed, 4 deletions(-)

Applied, thanks.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-12-10 10:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-08 14:22 [dpdk-stable] [PATCH 18.11] net/mlx5: remove unused variable in Tx queue creation Michael Baum
2020-12-10 10:14 ` Kevin Traynor

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git