From: Igor Russkikh <Igor.Russkikh@aquantia.com>
To: "stable@dpdk.org" <stable@dpdk.org>,
"ktraynor@redhat.com" <ktraynor@redhat.com>
Cc: Pavel Belous <Pavel.Belous@aquantia.com>,
Igor Russkikh <Igor.Russkikh@aquantia.com>,
Pavel Belous <Pavel.Belous@aquantia.com>
Subject: [dpdk-stable] [PATCH v2 18.11 05/10] net/atlantic: fix max eeprom size
Date: Tue, 21 May 2019 08:55:30 +0000 [thread overview]
Message-ID: <4c15c35b9f575647160136c95499a62b6402780b.1558426315.git.igor.russkikh@aquantia.com> (raw)
In-Reply-To: <cover.1558426315.git.igor.russkikh@aquantia.com>
Maximum size should be 256 bytes.
Move declaration to the top of the file
Fixes: ce4e8d418097 ("net/atlantic: implement EEPROM get/set")
Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
Signed-off-by: Pavel Belous <pavel.belous@aquantia.com>
cc: stable@dpdk.org
Signed-off-by: Pavel Belous <Pavel.Belous@aquantia.com>
---
drivers/net/atlantic/atl_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/atlantic/atl_ethdev.c b/drivers/net/atlantic/atl_ethdev.c
index 11208cd92855..ca477a435c8b 100644
--- a/drivers/net/atlantic/atl_ethdev.c
+++ b/drivers/net/atlantic/atl_ethdev.c
@@ -175,6 +175,8 @@ static struct rte_pci_driver rte_atl_pmd = {
| DEV_TX_OFFLOAD_TCP_TSO \
| DEV_TX_OFFLOAD_MULTI_SEGS)
+#define SFP_EEPROM_SIZE 0x100
+
static const struct rte_eth_desc_lim rx_desc_lim = {
.nb_max = ATL_MAX_RING_DESC,
.nb_min = ATL_MIN_RING_DESC,
@@ -1091,8 +1093,6 @@ atl_dev_interrupt_handler(void *param)
atl_dev_interrupt_action(dev, dev->intr_handle);
}
-#define SFP_EEPROM_SIZE 0xff
-
static int
atl_dev_get_eeprom_length(struct rte_eth_dev *dev __rte_unused)
{
--
2.17.1
next prev parent reply other threads:[~2019-05-21 8:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 8:55 [dpdk-stable] [PATCH v2 18.11 00/10] Aquantia atlantic bugfixes Igor Russkikh
2019-05-21 8:55 ` [dpdk-stable] [PATCH v2 18.11 01/10] net/atlantic: enable broadcast traffic Igor Russkikh
2019-05-21 8:55 ` [dpdk-stable] [PATCH v2 18.11 02/10] net/atlantic: extra line at eof Igor Russkikh
2019-05-21 8:55 ` [dpdk-stable] [PATCH v2 18.11 03/10] net/atlantic: error handling for mailbox access Igor Russkikh
2019-05-21 8:55 ` [dpdk-stable] [PATCH v2 18.11 04/10] net/atlantic: eeprom get/set should consider offset Igor Russkikh
2019-05-21 8:55 ` Igor Russkikh [this message]
2019-05-21 8:55 ` [dpdk-stable] [PATCH v2 18.11 06/10] net/atlantic: validity check for eeprom dev address Igor Russkikh
2019-05-21 8:55 ` [dpdk-stable] [PATCH v2 18.11 07/10] net/atlantic: bad logic with offsets talking with firmware Igor Russkikh
2019-05-21 8:55 ` [dpdk-stable] [PATCH v2 18.11 08/10] net/atlantic: flow control settings synchronization on rx Igor Russkikh
2019-05-21 8:55 ` [dpdk-stable] [PATCH v2 18.11 09/10] net/atlantic: use capability bits to detect eeprom access Igor Russkikh
2019-05-21 8:55 ` [dpdk-stable] [PATCH v2 18.11 10/10] net/atlantic: eliminate excessive log levels on Rx/Tx Igor Russkikh
2019-05-21 12:55 ` [dpdk-stable] [PATCH v2 18.11 00/10] Aquantia atlantic bugfixes Kevin Traynor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c15c35b9f575647160136c95499a62b6402780b.1558426315.git.igor.russkikh@aquantia.com \
--to=igor.russkikh@aquantia.com \
--cc=Pavel.Belous@aquantia.com \
--cc=ktraynor@redhat.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).