* [dpdk-stable] [PATCH v2] net/netvsc: initialize link state
[not found] <20200206105541.1186-1-mgamal@redhat.com>
@ 2020-02-07 18:08 ` Stephen Hemminger
2020-02-10 13:10 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2020-02-07 18:08 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger, stable, Mohammed Gamal
If application is using link state interrupt, the correct link state
needs to be filled in when device is started. This is similar to
how virtio updates link information.
Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device")
Cc: stable@dpdk.org
Reported-by: Mohammed Gamal <mgamal@redhat.com>
Tested-by: Mohammed Gamal <mgamal@redhat.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
Putting on same email thread as original submission
v2 - new patch that does initialization at start
added tested-by and fixes tag
drivers/net/netvsc/hn_ethdev.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
index c79f924379fe..564620748daf 100644
--- a/drivers/net/netvsc/hn_ethdev.c
+++ b/drivers/net/netvsc/hn_ethdev.c
@@ -823,6 +823,10 @@ hn_dev_start(struct rte_eth_dev *dev)
if (error)
hn_rndis_set_rxfilter(hv, 0);
+ /* Initialize Link state */
+ if (error == 0)
+ hn_dev_link_update(dev, 0);
+
return error;
}
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [PATCH v2] net/netvsc: initialize link state
2020-02-07 18:08 ` [dpdk-stable] [PATCH v2] net/netvsc: initialize link state Stephen Hemminger
@ 2020-02-10 13:10 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2020-02-10 13:10 UTC (permalink / raw)
To: Stephen Hemminger, dev; +Cc: stable, Mohammed Gamal
On 2/7/2020 6:08 PM, Stephen Hemminger wrote:
> If application is using link state interrupt, the correct link state
> needs to be filled in when device is started. This is similar to
> how virtio updates link information.
>
> Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device")
> Cc: stable@dpdk.org
> Reported-by: Mohammed Gamal <mgamal@redhat.com>
> Tested-by: Mohammed Gamal <mgamal@redhat.com>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-10 13:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200206105541.1186-1-mgamal@redhat.com>
2020-02-07 18:08 ` [dpdk-stable] [PATCH v2] net/netvsc: initialize link state Stephen Hemminger
2020-02-10 13:10 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).