From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Wang, Haiyue" <haiyue.wang@intel.com>,
"Rong, Leyi" <leyi.rong@intel.com>,
Bin Zheng <zhengbin.89740@bytedance.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "liangma@liangbit.com" <liangma@liangbit.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"jia.guo@intel.com" <jia.guo@intel.com>
Subject: RE: [PATCH v3] net/ixgbe: add vector Rx parameter check
Date: Tue, 11 Jan 2022 00:31:53 +0000 [thread overview]
Message-ID: <65a377590faa4d3abf0edb6eda78bebe@intel.com> (raw)
In-Reply-To: <DM4PR11MB551888636D3725E668A65AE8F7759@DM4PR11MB5518.namprd11.prod.outlook.com>
> -----Original Message-----
> From: Wang, Haiyue <haiyue.wang@intel.com>
> Sent: Tuesday, December 14, 2021 3:29 PM
> To: Rong, Leyi <leyi.rong@intel.com>; Bin Zheng
> <zhengbin.89740@bytedance.com>; dev@dpdk.org
> Cc: liangma@liangbit.com; stable@dpdk.org; jia.guo@intel.com
> Subject: RE: [PATCH v3] net/ixgbe: add vector Rx parameter check
>
> > -----Original Message-----
> > From: Rong, Leyi <leyi.rong@intel.com>
> > Sent: Monday, December 13, 2021 11:03
> > To: Bin Zheng <zhengbin.89740@bytedance.com>; dev@dpdk.org
> > Cc: Wang, Haiyue <haiyue.wang@intel.com>; liangma@liangbit.com;
> > stable@dpdk.org; jia.guo@intel.com
> > Subject: RE: [PATCH v3] net/ixgbe: add vector Rx parameter check
> >
> >
> > > -----Original Message-----
> > > From: Bin Zheng <zhengbin.89740@bytedance.com>
> > > Sent: Friday, December 10, 2021 4:22 PM
> > > To: dev@dpdk.org
> > > Cc: Wang, Haiyue <haiyue.wang@intel.com>; liangma@liangbit.com;
> > > stable@dpdk.org; Rong, Leyi <leyi.rong@intel.com>; Bin Zheng
> > > <zhengbin.89740@bytedance.com>; jia.guo@intel.com
> > > Subject: [PATCH v3] net/ixgbe: add vector Rx parameter check
> > >
> > > Under the circumstance that `rx_tail` wrap back to zero and the
> > > advance speed of `rx_tail` is greater than `rxrearm_start`,
> > > `rx_tail` will catch up with `rxrearm_start` and surpass it.
> > > This may cause some mbufs be reused by application.
> > >
> > > So we need to make some restrictions to ensure that `rx_tail` will
> > > not exceed `rxrearm_start`.
> > >
> > > e.g.
> > >
> > > RDH: 972 RDT: 991 rxrearm_nb: 991 rxrearm_start: 992 rx_tail: 959
> > > RDH: 1004 RDT: 1023 rxrearm_nb: 991 rxrearm_start: 0 rx_tail: 991
> > > RDH: 12 RDT: 31 rxrearm_nb: 991 rxrearm_start: 32 rx_tail: 1023
> > > RDH: 31 RDT: 63 rxrearm_nb: 960 rxrearm_start: 64 rx_tail: 0
> > > RDH: 95 RDT: 95 rxrearm_nb: 1016 rxrearm_start: 96 rx_tail: 88
> > > RDH: 95 RDT: 127 rxrearm_nb: 991 rxrearm_start: 128 rx_tail: 95 ...
> > > RDH: 908 RDT: 927 rxrearm_nb: 991 rxrearm_start: 928 rx_tail: 895
> > > RDH: 940 RDT: 959 rxrearm_nb: 991 rxrearm_start: 960 rx_tail: 927
> > > RDH: 980 RDT: 991 rxrearm_nb: 991 rxrearm_start: 992 rx_tail: 959
> > > RDH: 991 RDT: 991 rxrearm_nb: 1026 rxrearm_start: 992 rx_tail: 994
> > >
> > > when `rx_tail` catches up with `rxrearm_start`,
> > > 2(994 - 992) mbufs be reused by application !
> > >
> > > Bugzilla ID: 882
> > > Fixes: 5a3cca342417 ("net/ixgbe: fix vector Rx")
> > > Cc: jia.guo@intel.com
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Bin Zheng <zhengbin.89740@bytedance.com>
> > > ---
> > > drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 11 +++++++++++
> > > 1 file changed, 11 insertions(+)
> > >
>
>
> >
> > Acked-by: Leyi Rong <leyi.rong@intel.com>
>
> Reviewed-by: Haiyue Wang <haiyue.wang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
next prev parent reply other threads:[~2022-01-11 0:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211202092001.1830481-2-zhengbin.89740@bytedance.com>
2021-12-10 8:22 ` Bin Zheng
2021-12-13 3:02 ` Rong, Leyi
2021-12-14 7:29 ` Wang, Haiyue
2022-01-11 0:31 ` Zhang, Qi Z [this message]
2021-12-15 8:07 ` Liang Ma
2021-12-10 7:58 Bin Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65a377590faa4d3abf0edb6eda78bebe@intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=jia.guo@intel.com \
--cc=leyi.rong@intel.com \
--cc=liangma@liangbit.com \
--cc=stable@dpdk.org \
--cc=zhengbin.89740@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).