patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@xilinx.com>
To: Ke Zhang <ke1x.zhang@intel.com>
Cc: <stable@dpdk.org>, <xiaoyun.li@intel.com>,
	<aman.deep.singh@intel.com>, <yuying.zhang@intel.com>,
	<dev@dpdk.org>
Subject: Re: [PATCH v2] app/testpmd: fix quit testpmd with vfs and pf
Date: Tue, 21 Jun 2022 10:20:00 +0100	[thread overview]
Message-ID: <6a8160b1-1b52-095e-f293-88290f489972@xilinx.com> (raw)
In-Reply-To: <20220621090325.184668-1-ke1x.zhang@intel.com>

On 6/21/2022 10:03 AM, Ke Zhang wrote:
> When testpmd startups with pf and vfs,this error occurs when quitting,
> results in pf is released before vfs ,so the vf would access an
> freed heap memory.
> 
> The solution is two steps:
> 1. Fetch the valid port value from RTE_ETH_FOREACH_DEV.
> 2. free the port in reverse order.
> 
> Fixes: 08fd782b8454 ("app/testpmd: fix quit to stop all ports before close")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ke Zhang <ke1x.zhang@intel.com>
> ---
>   app/test-pmd/testpmd.c | 27 ++++++++++++++++++++++-----
>   1 file changed, 22 insertions(+), 5 deletions(-)
> 
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index 04c39adc21..67b4941942 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -3491,17 +3491,34 @@ pmd_test_exit(void)
>   		}
>   	}
>   #endif
> +	portid_t ethports[RTE_MAX_ETHPORTS];
> +	int count;
> +	int index;

Hi Ke,

These variables only used in the 'if' block, to reduce the scope of them 
can you please move them at the very top of the block:

if (ports != NULL) {
	portid_t ethports[RTE_MAX_ETHPORTS];
	int count = 0;
	int index;

	no_link_check = 1;
...

>   	if (ports != NULL) {
>   		no_link_check = 1;
> +		count = 0;
> +
> +		/* Fetch the valid port id from port list*/
>   		RTE_ETH_FOREACH_DEV(pt_id) {
> -			printf("\nStopping port %d...\n", pt_id);
> +			ethports[count] = pt_id;
> +			count++;
> +		}
> +
> +		/*
> +		 * Free the port from Reverse order, as general,
> +		 * PF port < VF port, VF should be free before PF
> +		 * be free.
> +		 */
> +		for (index = count - 1 ; index >= 0 ; index--) {
> +			printf("\nStopping port %d...\n", ethports[index]);
>   			fflush(stdout);
> -			stop_port(pt_id);
> +			stop_port(ethports[index]);
>   		}
> -		RTE_ETH_FOREACH_DEV(pt_id) {
> -			printf("\nShutting down port %d...\n", pt_id);
> +
> +		for (index = count - 1 ; index >= 0 ; index--) {
> +			printf("\nShutting down port %d...\n", ethports[index]);
>   			fflush(stdout);
> -			close_port(pt_id);
> +			close_port(ethports[index]);
>   		}
>   	}
>   


  reply	other threads:[~2022-06-21  9:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220322071833.199619-1-ke1x.zhang@intel.com>
2022-06-21  9:03 ` Ke Zhang
2022-06-21  9:20   ` Ferruh Yigit [this message]
2022-06-21  9:24 ` Ke Zhang
2022-06-21 10:43   ` Ferruh Yigit
2022-06-22 21:31     ` Thomas Monjalon
2022-06-23  6:41       ` Thomas Monjalon
2022-07-13  7:11   ` [PATCH v3] " Ke Zhang
2022-07-13  9:15     ` Thomas Monjalon
2022-07-15  9:03     ` [PATCH v4] net/i40e: fix the issue caused by PF and VF release order Ke Zhang
2022-08-02  2:16       ` Zhang, Yuying
2022-08-08  0:06         ` Zhang, Qi Z
2022-08-08  0:30           ` Zhang, Qi Z
2022-08-04  9:50       ` [PATCH v5] " Ke Zhang
2022-08-08  0:30         ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a8160b1-1b52-095e-f293-88290f489972@xilinx.com \
    --to=ferruh.yigit@xilinx.com \
    --cc=aman.deep.singh@intel.com \
    --cc=dev@dpdk.org \
    --cc=ke1x.zhang@intel.com \
    --cc=stable@dpdk.org \
    --cc=xiaoyun.li@intel.com \
    --cc=yuying.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).