patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Zhang, Yuying" <yuying.zhang@intel.com>
To: "Zhang, Ke1X" <ke1x.zhang@intel.com>,
	"thomas@monjalon.net" <thomas@monjalon.net>,
	"Xing, Beilei" <beilei.xing@intel.com>,
	"ferruh.yigit@xilinx.com" <ferruh.yigit@xilinx.com>,
	"Zhou, YidingX" <yidingx.zhou@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v4] net/i40e: fix the issue caused by PF and VF release order
Date: Tue, 2 Aug 2022 02:16:24 +0000	[thread overview]
Message-ID: <DM6PR11MB3516F21EB26D6B39F196798E8E9D9@DM6PR11MB3516.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220715090359.76538-1-ke1x.zhang@intel.com>

Hi Ke,

Please update commit log.
LGTM.

> -----Original Message-----
> From: Zhang, Ke1X <ke1x.zhang@intel.com>
> Sent: Friday, July 15, 2022 5:04 PM
> To: thomas@monjalon.net; Zhang, Yuying <yuying.zhang@intel.com>; Xing,
> Beilei <beilei.xing@intel.com>; ferruh.yigit@xilinx.com; Zhou, YidingX
> <yidingx.zhou@intel.com>; dev@dpdk.org
> Cc: Zhang, Ke1X <ke1x.zhang@intel.com>; stable@dpdk.org
> Subject: [PATCH v4] net/i40e: fix the issue caused by PF and VF release order
> 
> A segmentation fault occurs when testpmd exit.
> 
> This is due to fetching the device name from PF, PF is freed firstly and then VF
> representor is called later.
> 
> This commit fixes the bug by fetching the device name from VF representor
> not PF.

instead of PF

> 
> Fixes: e391a7b7f815 ("net/i40e: fix multi-process shared data")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ke Zhang <ke1x.zhang@intel.com>
Acked-by: Yuying Zhang <yuying.zhang@intel.com>

> 
> ---
> v4: Update the commit log
> v3: Change the design and fix code in driver
> v2: Change the testpmd code to fix this issue
> ---
> ---
>  drivers/net/i40e/i40e_vf_representor.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/i40e/i40e_vf_representor.c
> b/drivers/net/i40e/i40e_vf_representor.c
> index 7f8e81858e..bcd445bcdd 100644
> --- a/drivers/net/i40e/i40e_vf_representor.c
> +++ b/drivers/net/i40e/i40e_vf_representor.c
> @@ -29,8 +29,6 @@ i40e_vf_representor_dev_infos_get(struct rte_eth_dev
> *ethdev,
>  	struct rte_eth_dev_info *dev_info)
>  {
>  	struct i40e_vf_representor *representor = ethdev->data-
> >dev_private;
> -	struct rte_eth_dev_data *pf_dev_data =
> -		representor->adapter->pf.dev_data;
> 
>  	/* get dev info for the vdev */
>  	dev_info->device = ethdev->device;
> @@ -104,7 +102,7 @@ i40e_vf_representor_dev_infos_get(struct
> rte_eth_dev *ethdev,
>  	};
> 
>  	dev_info->switch_info.name =
> -		rte_eth_devices[pf_dev_data->port_id].device->name;
> +		rte_eth_devices[ethdev->data->port_id].device->name;
>  	dev_info->switch_info.domain_id = representor->switch_domain_id;
>  	dev_info->switch_info.port_id = representor->vf_id;
> 
> --
> 2.25.1


  reply	other threads:[~2022-08-02  2:16 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220322071833.199619-1-ke1x.zhang@intel.com>
2022-06-21  9:03 ` [PATCH v2] app/testpmd: fix quit testpmd with vfs and pf Ke Zhang
2022-06-21  9:20   ` Ferruh Yigit
2022-06-21  9:24 ` Ke Zhang
2022-06-21 10:43   ` Ferruh Yigit
2022-06-22 21:31     ` Thomas Monjalon
2022-06-23  6:41       ` Thomas Monjalon
2022-07-13  7:11   ` [PATCH v3] " Ke Zhang
2022-07-13  9:15     ` Thomas Monjalon
2022-07-15  9:03     ` [PATCH v4] net/i40e: fix the issue caused by PF and VF release order Ke Zhang
2022-08-02  2:16       ` Zhang, Yuying [this message]
2022-08-08  0:06         ` Zhang, Qi Z
2022-08-08  0:30           ` Zhang, Qi Z
2022-08-04  9:50       ` [PATCH v5] " Ke Zhang
2022-08-08  0:30         ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB3516F21EB26D6B39F196798E8E9D9@DM6PR11MB3516.namprd11.prod.outlook.com \
    --to=yuying.zhang@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@xilinx.com \
    --cc=ke1x.zhang@intel.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=yidingx.zhou@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).