* [dpdk-stable] [PATCH] net/sfc/base: fix manual filter delete in EF10
@ 2020-05-20 13:59 Andrew Rybchenko
2020-05-21 15:48 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Rybchenko @ 2020-05-20 13:59 UTC (permalink / raw)
To: dev; +Cc: Igor Romanov, stable
From: Igor Romanov <igor.romanov@oktetlabs.ru>
When user requests a filter deletion only filter with
manual priority must be deleted. When an automatic filter has
the same specification, it must be skipped.
Fixes: 585c22edb29c ("net/sfc/base: handle manual and auto filter clashes in EF10")
Cc: stable@dpdk.org
Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/net/sfc/base/ef10_filter.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/sfc/base/ef10_filter.c b/drivers/net/sfc/base/ef10_filter.c
index 7a726ef977..12c84a5640 100644
--- a/drivers/net/sfc/base/ef10_filter.c
+++ b/drivers/net/sfc/base/ef10_filter.c
@@ -1161,7 +1161,8 @@ ef10_filter_delete(
i = (hash + depth) & (EFX_EF10_FILTER_TBL_ROWS - 1);
saved_spec = ef10_filter_entry_spec(table, i);
if (saved_spec && ef10_filter_equal(spec, saved_spec) &&
- ef10_filter_same_dest(spec, saved_spec)) {
+ ef10_filter_same_dest(spec, saved_spec) &&
+ saved_spec->efs_priority == EFX_FILTER_PRI_MANUAL) {
break;
}
if (depth == EF10_FILTER_SEARCH_LIMIT) {
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [PATCH] net/sfc/base: fix manual filter delete in EF10
2020-05-20 13:59 [dpdk-stable] [PATCH] net/sfc/base: fix manual filter delete in EF10 Andrew Rybchenko
@ 2020-05-21 15:48 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2020-05-21 15:48 UTC (permalink / raw)
To: Andrew Rybchenko, dev; +Cc: Igor Romanov, stable
On 5/20/2020 2:59 PM, Andrew Rybchenko wrote:
> From: Igor Romanov <igor.romanov@oktetlabs.ru>
>
> When user requests a filter deletion only filter with
> manual priority must be deleted. When an automatic filter has
> the same specification, it must be skipped.
>
> Fixes: 585c22edb29c ("net/sfc/base: handle manual and auto filter clashes in EF10")
> Cc: stable@dpdk.org
>
> Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-21 15:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-20 13:59 [dpdk-stable] [PATCH] net/sfc/base: fix manual filter delete in EF10 Andrew Rybchenko
2020-05-21 15:48 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).