From: "Zhang, Xiao" <xiao.zhang@intel.com>
To: Joyce Kong <joyce.kong@arm.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "nd@arm.com" <nd@arm.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"gavin.hu@arm.com" <gavin.hu@arm.com>,
"honnappa.nagarahalli@arm.com" <honnappa.nagarahalli@arm.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH 1/2] net/i40e: fix address of first segment
Date: Tue, 24 Sep 2019 06:47:57 +0000 [thread overview]
Message-ID: <AF0377F445CB2540BB46FF359C1C1BBE011BD466@SHSMSX105.ccr.corp.intel.com> (raw)
In-Reply-To: <1569304125-5365-2-git-send-email-joyce.kong@arm.com>
> -----Original Message-----
> From: Joyce Kong [mailto:joyce.kong@arm.com]
> Sent: Tuesday, September 24, 2019 1:49 PM
> To: dev@dpdk.org
> Cc: nd@arm.com; thomas@monjalon.net; jerinj@marvell.com; Zhang, Xiao
> <xiao.zhang@intel.com>; gavin.hu@arm.com; honnappa.nagarahalli@arm.com;
> stable@dpdk.org
> Subject: [PATCH 1/2] net/i40e: fix address of first segment
>
> This patch fixes (dereference after null check) coverity issue.
> The address of first segmented packets was not set correctly during
> reassembling packets which led to this issue.
>
> Coverity issue: 343422, 343403
> Fixes: ca74903b75cf ("net/i40e: extract non-x86 specific code from vector
> driver")
> Cc: stable@dpdk.org
>
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> ---
> drivers/net/i40e/i40e_rxtx_vec_neon.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/i40e/i40e_rxtx_vec_neon.c
> b/drivers/net/i40e/i40e_rxtx_vec_neon.c
> index 864eb9a..deb185f 100644
> --- a/drivers/net/i40e/i40e_rxtx_vec_neon.c
> +++ b/drivers/net/i40e/i40e_rxtx_vec_neon.c
> @@ -474,6 +474,7 @@ i40e_recv_scattered_pkts_vec(void *rx_queue, struct
> rte_mbuf **rx_pkts,
> i++;
> if (i == nb_bufs)
> return nb_bufs;
> + rxq->pkt_first_seg = rx_pkts[i];
> }
> return i + reassemble_packets(rxq, &rx_pkts[i], nb_bufs - i,
> &split_flags[i]);
> --
> 2.7.4
Reviewed-by: Xiao Zhang <xiao.zhang@intel.com>
next prev parent reply other threads:[~2019-09-24 6:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1569304125-5365-1-git-send-email-joyce.kong@arm.com>
2019-09-24 5:48 ` Joyce Kong
2019-09-24 6:47 ` Zhang, Xiao [this message]
2019-09-24 5:48 ` [dpdk-stable] [PATCH 2/2] net/ixgbe: " Joyce Kong
2019-09-24 6:48 ` Zhang, Xiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AF0377F445CB2540BB46FF359C1C1BBE011BD466@SHSMSX105.ccr.corp.intel.com \
--to=xiao.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=jerinj@marvell.com \
--cc=joyce.kong@arm.com \
--cc=nd@arm.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).