patches for DPDK stable branches
 help / color / mirror / Atom feed
* [PATCH v1] net/mlx5: fix assertion on the flags set in pkt mbuf
@ 2021-12-23  8:15 Lior Margalit
  2022-01-09 11:54 ` Raslan Darawsheh
  0 siblings, 1 reply; 2+ messages in thread
From: Lior Margalit @ 2021-12-23  8:15 UTC (permalink / raw)
  To: Slava Ovsiienko; +Cc: Lior Margalit, dev, akozyrev, stable

Fixed the assertion on the flags set in pkt->ol_flags for vectorized MPRQ.
With vectorized MPRQ the CQs are processed before copying the MPRQ bufs
so the valid assertion is that the expected flag is set and not that
the pkt->ol_flags equlas this flag alone.

Fixes: 0f20acbf5eda ("net/mlx5: implement vectorized MPRQ burst")
Cc: akozyrev@nvidia.com
Cc: stable@dpdk.org

Signed-off-by: Lior Margalit <lmargalit@nvidia.com>
Acked-by: Slava Ovsiienko <viacheslavo@nvidia.com>
---
 drivers/net/mlx5/mlx5_rx.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5_rx.h b/drivers/net/mlx5/mlx5_rx.h
index adb759c235..c178f9a24b 100644
--- a/drivers/net/mlx5/mlx5_rx.h
+++ b/drivers/net/mlx5/mlx5_rx.h
@@ -543,7 +543,7 @@ mprq_buf_to_pkt(struct mlx5_rxq_data *rxq, struct rte_mbuf *pkt, uint32_t len,
 					  buf_len, shinfo);
 		/* Set mbuf head-room. */
 		SET_DATA_OFF(pkt, RTE_PKTMBUF_HEADROOM);
-		MLX5_ASSERT(pkt->ol_flags == RTE_MBUF_F_EXTERNAL);
+		MLX5_ASSERT(pkt->ol_flags & RTE_MBUF_F_EXTERNAL);
 		MLX5_ASSERT(rte_pktmbuf_tailroom(pkt) >=
 			len - (hdrm_overlap > 0 ? hdrm_overlap : 0));
 		DATA_LEN(pkt) = len;
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [PATCH v1] net/mlx5: fix assertion on the flags set in pkt mbuf
  2021-12-23  8:15 [PATCH v1] net/mlx5: fix assertion on the flags set in pkt mbuf Lior Margalit
@ 2022-01-09 11:54 ` Raslan Darawsheh
  0 siblings, 0 replies; 2+ messages in thread
From: Raslan Darawsheh @ 2022-01-09 11:54 UTC (permalink / raw)
  To: Lior Margalit, Slava Ovsiienko
  Cc: Lior Margalit, dev, Alexander Kozyrev, stable

Hi,

> -----Original Message-----
> From: Lior Margalit <lmargalit@nvidia.com>
> Sent: Thursday, December 23, 2021 10:16 AM
> To: Slava Ovsiienko <viacheslavo@nvidia.com>
> Cc: Lior Margalit <lmargalit@nvidia.com>; dev@dpdk.org; Alexander Kozyrev
> <akozyrev@nvidia.com>; stable@dpdk.org
> Subject: [PATCH v1] net/mlx5: fix assertion on the flags set in pkt mbuf
> 
> Fixed the assertion on the flags set in pkt->ol_flags for vectorized MPRQ.
> With vectorized MPRQ the CQs are processed before copying the MPRQ bufs
> so the valid assertion is that the expected flag is set and not that the pkt-
> >ol_flags equlas this flag alone.
> 
> Fixes: 0f20acbf5eda ("net/mlx5: implement vectorized MPRQ burst")
> Cc: akozyrev@nvidia.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Lior Margalit <lmargalit@nvidia.com>
> Acked-by: Slava Ovsiienko <viacheslavo@nvidia.com>

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-01-09 11:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-23  8:15 [PATCH v1] net/mlx5: fix assertion on the flags set in pkt mbuf Lior Margalit
2022-01-09 11:54 ` Raslan Darawsheh

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git