From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
To: Chengwen Feng <fengchengwen@huawei.com>
Cc: dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] "net/hns3: fix VF handling LSC event in secondary process" incompatible with 19.11.x
Date: Tue, 1 Jun 2021 11:05:39 +0200 [thread overview]
Message-ID: <CAATJJ0+MT+3Y+iA_Ac6V=fu=sARmEScqMybhyih+wy4rD3Yi9g@mail.gmail.com> (raw)
In-Reply-To: <CAATJJ0LuRTZineQzkmd4wL3ykLVdNuGHb+YQvxFudKLeZxM_kA@mail.gmail.com>
FYI this also implies a remove of the depending
commit 4a2f6ab6fbc4be504e155a48665cc0d854ef36b6
Author: Chengwen Feng <fengchengwen@huawei.com>
Date: Thu Apr 22 09:55:50 2021 +0800
net/hns3: fix processing link status message on PF
On Tue, Jun 1, 2021 at 11:03 AM Christian Ehrhardt
<christian.ehrhardt@canonical.com> wrote:
>
> Hi,
> this mostly is an FYI to document why a change was not applied to the
> stable series. This was targeted for stable releases:
>
> commit dbbbad23e380773b37872df2195c4529fd93ca6f
> Author: Chengwen Feng <fengchengwen@huawei.com>
> Date: Tue Apr 13 19:50:02 2021 +0800
>
> net/hns3: fix VF handling LSC event in secondary process
>
> But it triggers
>
> ../drivers/net/hns3/hns3_mbx.c: In function ‘hns3_handle_mbx_msg_out_intr’:
> ../drivers/net/hns3/hns3_mbx.c:355:4: warning: implicit declaration of
> function ‘hns3_handle_mbx_response’; did you mean
> ‘hns3_handle_msix_error’? [-Wimplicit-function-declaration]
> 355 | hns3_handle_mbx_response(hw, req);
> | ^~~~~~~~~~~~~~~~~~~~~~~~
> | hns3_handle_msix_error
>
>
> This is due to missing:
>
> commit c8dec72de00039f367c1a8cd1f40378d04cf3e8f
> Author: Chengwen Feng <fengchengwen@huawei.com>
> Date: Tue Apr 13 19:50:01 2021 +0800
>
> net/hns3: fix possible mismatched response of mailbox
>
> And this one I already called out as a "help for backport" 12 days ago.
>
> The same is true for:
>
> ../drivers/net/hns3/hns3_mbx.c:385:10: warning: implicit declaration
> of function ‘rte_thread_is_intr’; did you mean ‘rte_thread_setname’?
> [-Wimplicit-function-declaration]
> 385 | !rte_thread_is_intr()) && hns->is_vf;
> | ^~~~~~~~~~~~~~~~~~
> | rte_thread_setname
>
> Which needs
> commit 5c016fc0205a67123481dbe8f9784635beac8a09
> Author: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> Date: Sat Sep 26 02:32:42 2020 +0300
>
> eal/windows: add interrupt thread skeleton
>
> FYI for now I'll also drop dbbbad23e380773b37872df2195c4529fd93ca6f from 19.11.x
>
> --
> Christian Ehrhardt
> Staff Engineer, Ubuntu Server
> Canonical Ltd
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
prev parent reply other threads:[~2021-06-01 9:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 9:03 Christian Ehrhardt
2021-06-01 9:05 ` Christian Ehrhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAATJJ0+MT+3Y+iA_Ac6V=fu=sARmEScqMybhyih+wy4rD3Yi9g@mail.gmail.com' \
--to=christian.ehrhardt@canonical.com \
--cc=fengchengwen@huawei.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).