Re: [PATCH 19.11 20.11] pmdinfogen: fix compilation with Clang 3.4.2 on CentOS 7

[Christian Ehrhardt <christian.ehrhardt@canonical.com>]

On Wed, Mar 30, 2022 at 2:13 PM <luca.boccassi@gmail.com> wrote:
>
> From: Luca Boccassi <bluca@debian.org>
>
> $ meson --werror --buildtype=debugoptimized build && ninja-build -C build
> [..]
> [5/2516] Compiling C object buildtools/pmdinfogen/pmdinfogen.p/pmdinfogen.c.o
> FAILED: buildtools/pmdinfogen/pmdinfogen.p/pmdinfogen.c.o
> clang -Ibuildtools/pmdinfogen/pmdinfogen.p -Ibuildtools/pmdinfogen -I../../root/dpdk/buildtools/pmdinfogen -I. -I../../root/dpdk -Iconfig -I../../root/dpdk/config -Ilib/librte_eal/include -I../../root/dpdk/lib/librte_eal/include -Ilib/librte_eal/linux/include -I../../root/dpdk/lib/librte_eal/linux/include -Ilib/librte_eal/x86/include -I../../root/dpdk/lib/librte_eal/x86/include -Ilib/librte_pci -I../../root/dpdk/lib/librte_pci -Xclang -fcolor-diagnostics -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -O2 -g -MD -MQ buildtools/pmdinfogen/pmdinfogen.p/pmdinfogen.c.o -MF buildtools/pmdinfogen/pmdinfogen.p/pmdinfogen.c.o.d -o buildtools/pmdinfogen/pmdinfogen.p/pmdinfogen.c.o -c ../../root/dpdk/buildtools/pmdinfogen/pmdinfogen.c
> ../../root/dpdk/buildtools/pmdinfogen/pmdinfogen.c:431:27: error: missing field 'hdr' initializer [-Werror,-Wmissing-field-initializers]
>         struct elf_info info = {0};
>                                  ^
> 1 error generated.
> [..]

The change itself LGTM and works on my end for 19.11 (applied it).

Maybe adding a fixes: 0decf84217f1ef8af132948a0661559a96961495 ?

With or without it is fine,
Reviewed-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>

> Use structured initialization
>
> Bugzilla ID: 984
>
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> ---
>  buildtools/pmdinfogen/pmdinfogen.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/buildtools/pmdinfogen/pmdinfogen.c b/buildtools/pmdinfogen/pmdinfogen.c
> index a68d1ea999..534ed9f3c8 100644
> --- a/buildtools/pmdinfogen/pmdinfogen.c
> +++ b/buildtools/pmdinfogen/pmdinfogen.c
> @@ -428,7 +428,7 @@ static void output_pmd_info_string(struct elf_info *info, char *outfile)
>
>  int main(int argc, char **argv)
>  {
> -       struct elf_info info = {0};
> +       struct elf_info info = {};
>         int rc = 1;
>
>         if (argc < 3) {
> --
> 2.34.1
>


-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd