patches for DPDK stable branches
 help / color / mirror / Atom feed
* Re: [PATCH] net/bnxt: fix autoneg on PAM4 links
       [not found] <20211118040439.24583-1-somnath.kotur@broadcom.com>
@ 2021-11-18  4:55 ` Ajit Khaparde
  0 siblings, 0 replies; only message in thread
From: Ajit Khaparde @ 2021-11-18  4:55 UTC (permalink / raw)
  To: Somnath Kotur; +Cc: dpdk-dev, Ferruh Yigit, Charlie Brtee, dpdk stable

On Wed, Nov 17, 2021 at 8:11 PM Somnath Kotur
<somnath.kotur@broadcom.com> wrote:
>
> If autonegotiation was enabled, driver was not passing the
> 'auto_pam4_link_speeds' obtained during init and stored in bp->link_info
> to bnxt_hwrm_port_phy_cfg(). This would result in an incorrect setting
> being passed to the HW during PHY configuration. This in turn, would
> result in invalid settings being retrieved and configured in subsequent
> application loads resulting in launch failures.
>
> Fixes: c23f9ded0391 ("net/bnxt: support 200G PAM4 link")
>
> Reported-by: Charlie Brtee <cfb@hpe.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
Merged in dpdk-next-net-brcm.

Fixed up typo in Charle's name.
Added Bugzilla ID and stable@dpdk.org

Thanks
Ajit

> ---
>  drivers/net/bnxt/bnxt_hwrm.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
> index 67ed807dad..df75047e2d 100644
> --- a/drivers/net/bnxt/bnxt_hwrm.c
> +++ b/drivers/net/bnxt/bnxt_hwrm.c
> @@ -3247,6 +3247,8 @@ int bnxt_set_hwrm_link_config(struct bnxt *bp, bool link_up)
>                 link_req.auto_link_speed_mask =
>                         bnxt_parse_eth_link_speed_mask(bp,
>                                                        dev_conf->link_speeds);
> +               link_req.auto_pam4_link_speeds =
> +                       bp->link_info->auto_pam4_link_speeds;
>         } else {
>                 if (bp->link_info->phy_type ==
>                     HWRM_PORT_PHY_QCFG_OUTPUT_PHY_TYPE_BASET ||
> --
> 2.28.0.497.g54e85e7
>

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-11-18  4:55 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20211118040439.24583-1-somnath.kotur@broadcom.com>
2021-11-18  4:55 ` [PATCH] net/bnxt: fix autoneg on PAM4 links Ajit Khaparde

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git