From: Lance Richardson <lance.richardson@broadcom.com>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev <dev@dpdk.org>,
dpdk stable <stable@dpdk.org>,
Olivier Matz <olivier.matz@6wind.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net: fix checksum API documentation
Date: Tue, 21 Sep 2021 10:50:12 -0400 [thread overview]
Message-ID: <CADyeNEDR9rg31X+gW4Sf_A1VH=tFgM8_YiUCqaRdsZww8FHqbQ@mail.gmail.com> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35C61A9B@smartserver.smartshare.dk>
[-- Attachment #1: Type: text/plain, Size: 588 bytes --]
On Tue, Sep 21, 2021 at 6:11 AM Morten Brørup <mb@smartsharesystems.com> wrote:
> Ferruh, the description of the return value is technically correct; it mentions the IP packet, not the IP header.
> So this change is a clarification only.
>
> However, I agree that the same clarification would also benefit 'rte_ipv4_udptcp_cksum()'.
>
Sure, will fix in v2.
Also for rte_ipv4_udptcp_cksum(), a comment says "The IP and layer 4
checksum must be set to zero", but only the layer 4 checksum actually
needs to be set to zero. I'll fix that at the same time.
Thanks,
Lance
next prev parent reply other threads:[~2021-09-21 14:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 16:10 [dpdk-stable] " Lance Richardson
2021-09-17 10:57 ` Morten Brørup
2021-09-21 9:28 ` Ferruh Yigit
2021-09-21 10:11 ` [dpdk-stable] [dpdk-dev] " Morten Brørup
2021-09-21 14:50 ` Lance Richardson [this message]
2021-09-21 14:59 ` [dpdk-stable] [PATCH v2] " Lance Richardson
2021-09-22 9:16 ` Ferruh Yigit
2021-09-27 16:14 ` Olivier Matz
2021-10-07 12:43 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADyeNEDR9rg31X+gW4Sf_A1VH=tFgM8_YiUCqaRdsZww8FHqbQ@mail.gmail.com' \
--to=lance.richardson@broadcom.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=mb@smartsharesystems.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).