From: David Marchand <david.marchand@redhat.com>
To: Wenwu Ma <wenwux.ma@intel.com>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>,
"Xia, Chenbo" <chenbo.xia@intel.com>, dev <dev@dpdk.org>,
Jiayu Hu <jiayu.hu@intel.com>,
"Wang, Yinan" <yinan.wang@intel.com>,
xingguang.he@intel.com, dpdk stable <stable@dpdk.org>
Subject: Re: [PATCH v3] vhost: fix deadlock when message handling failed
Date: Tue, 17 May 2022 15:15:03 +0200 [thread overview]
Message-ID: <CAJFAV8yNC1WBpQGE82TOxTcn-X=-z-CW4kOe6H74fyTah=jz-Q@mail.gmail.com> (raw)
In-Reply-To: <20220507132753.11357-1-wenwux.ma@intel.com>
On Sat, May 7, 2022 at 7:30 AM Wenwu Ma <wenwux.ma@intel.com> wrote:
>
> In vhost_user_msg_handler(), if vhost message handling
> failed, we should check whether the queue is locked and
> release the lock before returning. Or, it will cause a
> deadlock later.
>
> Fixes: 7f31d4ea05ca ("vhost: fix lock on device readiness notification")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wenwu Ma <wenwux.ma@intel.com>
Thanks, lgtm.
Acked-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
next prev parent reply other threads:[~2022-05-17 13:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220505134008.2865-1-wenwux.ma@intel.com>
2022-05-05 16:17 ` [PATCH v2] vhost: fix deadlock when handling user messages Wenwu Ma
2022-05-06 8:19 ` Xia, Chenbo
2022-05-07 13:27 ` [PATCH v3] vhost: fix deadlock when message handling failed Wenwu Ma
2022-05-07 6:02 ` Xia, Chenbo
2022-05-09 3:13 ` Ling, WeiX
2022-05-17 13:15 ` David Marchand [this message]
2022-05-17 13:24 ` Maxime Coquelin
2022-07-11 8:42 ` Pei, Andy
2022-07-11 8:54 ` Xia, Chenbo
2022-07-11 9:02 ` Pei, Andy
2022-07-11 9:14 ` Xia, Chenbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yNC1WBpQGE82TOxTcn-X=-z-CW4kOe6H74fyTah=jz-Q@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=wenwux.ma@intel.com \
--cc=xingguang.he@intel.com \
--cc=yinan.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).