patches for DPDK stable branches
 help / color / mirror / Atom feed
* [PATCH] net/qede: fix RSS indirection table initialization
@ 2023-05-25 13:54 Devendra Singh Rawat
  2023-05-26  9:07 ` Jerin Jacob
  0 siblings, 1 reply; 5+ messages in thread
From: Devendra Singh Rawat @ 2023-05-25 13:54 UTC (permalink / raw)
  To: dev, palok, jerinj
  Cc: stable, GR-Everest-DPDK-Dev, manishc, Devendra Singh Rawat

RSS indirection table was not updated for VF ports during RSS hash
update, this resulted in device start failure.
This fix sets update rss indirection table in VFPF channel request,
sent for updating RSS hash for VF.

Fixes: 7ab35bf6b97b ("net/qede: fix RSS")
Cc: stable@dpdk.org

Signed-off-by: Devendra Singh Rawat <dsinghrawat@marvell.com>
Signed-off-by: Alok Prasad <palok@marvell.com>
---
 drivers/net/qede/qede_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index a4923670d6..22cd470646 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -2142,6 +2142,7 @@ int qede_rss_hash_update(struct rte_eth_dev *eth_dev,
 		rss_params.rss_enable = 1;
 	}
 
+	rss_params.update_rss_ind_table = 1;
 	rss_params.update_rss_config = 1;
 	/* tbl_size has to be set with capabilities */
 	rss_params.rss_table_size_log = 7;
-- 
2.18.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] net/qede: fix RSS indirection table initialization
  2023-05-25 13:54 [PATCH] net/qede: fix RSS indirection table initialization Devendra Singh Rawat
@ 2023-05-26  9:07 ` Jerin Jacob
  0 siblings, 0 replies; 5+ messages in thread
From: Jerin Jacob @ 2023-05-26  9:07 UTC (permalink / raw)
  To: Devendra Singh Rawat
  Cc: dev, palok, jerinj, stable, GR-Everest-DPDK-Dev, manishc

On Thu, May 25, 2023 at 7:24 PM Devendra Singh Rawat
<dsinghrawat@marvell.com> wrote:
>
> RSS indirection table was not updated for VF ports during RSS hash
> update, this resulted in device start failure.
> This fix sets update rss indirection table in VFPF channel request,
> sent for updating RSS hash for VF.
>
> Fixes: 7ab35bf6b97b ("net/qede: fix RSS")
> Cc: stable@dpdk.org
>
> Signed-off-by: Devendra Singh Rawat <dsinghrawat@marvell.com>
> Signed-off-by: Alok Prasad <palok@marvell.com>

Applied to dpdk-next-net-mrvl/for-next-net. Thanks


> ---
>  drivers/net/qede/qede_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
> index a4923670d6..22cd470646 100644
> --- a/drivers/net/qede/qede_ethdev.c
> +++ b/drivers/net/qede/qede_ethdev.c
> @@ -2142,6 +2142,7 @@ int qede_rss_hash_update(struct rte_eth_dev *eth_dev,
>                 rss_params.rss_enable = 1;
>         }
>
> +       rss_params.update_rss_ind_table = 1;
>         rss_params.update_rss_config = 1;
>         /* tbl_size has to be set with capabilities */
>         rss_params.rss_table_size_log = 7;
> --
> 2.18.2
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] net/qede: fix RSS indirection table initialization
  2023-05-25  5:30 Devendra Singh Rawat
@ 2023-05-25 12:22 ` Jerin Jacob
  0 siblings, 0 replies; 5+ messages in thread
From: Jerin Jacob @ 2023-05-25 12:22 UTC (permalink / raw)
  To: Devendra Singh Rawat
  Cc: dev, palok, jerinj, ferruh.yigit, stable, GR-Everest-DPDK-Dev, manishc

On Thu, May 25, 2023 at 2:59 PM Devendra Singh Rawat
<dsinghrawat@marvell.com> wrote:
>
> RSS indirection table was not updated for VF ports during RSS hash
> update, this resulted in device start failure.
> This fix updates RSS indirection table during RSS hash update.
>
> Fixes: 7ab35bf6b97b (net/qede: fix RSS)

[for-next-net]dell[dpdk-next-net-mrvl] $ ./devtools/check-git-log.sh -n 1
Wrong tag:
        Fixes: 7ab35bf6b97b (net/qede: fix RSS)
Wrong 'Fixes' reference:
        Fixes: 7ab35bf6b97b (net/qede: fix RSS)

Invalid patch(es) found - checked 1 patch

> Cc: stable@dpdk.org
>
> Signed-off-by: Devendra Singh Rawat <dsinghrawat@marvell.com>
> Signed-off-by: Alok Prasad <palok@marvell.com>
> ---
>  drivers/net/qede/qede_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
> index a4923670d6..22cd470646 100644
> --- a/drivers/net/qede/qede_ethdev.c
> +++ b/drivers/net/qede/qede_ethdev.c
> @@ -2142,6 +2142,7 @@ int qede_rss_hash_update(struct rte_eth_dev *eth_dev,
>                 rss_params.rss_enable = 1;
>         }
>
> +       rss_params.update_rss_ind_table = 1;
>         rss_params.update_rss_config = 1;
>         /* tbl_size has to be set with capabilities */
>         rss_params.rss_table_size_log = 7;
> --
> 2.18.2
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] net/qede: fix RSS indirection table initialization
@ 2023-05-25  5:45 Devendra Singh Rawat
  0 siblings, 0 replies; 5+ messages in thread
From: Devendra Singh Rawat @ 2023-05-25  5:45 UTC (permalink / raw)
  To: dev, palok, jerinj, ferruh.yigit
  Cc: stable, GR-Everest-DPDK-Dev, manishc, Devendra Singh Rawat

RSS indirection table was not updated for VF ports during RSS hash
update, this resulted in device start failure.
This fix updates RSS indirection table during RSS hash update.

Fixes: 7ab35bf6b97b (net/qede: fix RSS)
Cc: stable@dpdk.org

Signed-off-by: Devendra Singh Rawat <dsinghrawat@marvell.com>
Signed-off-by: Alok Prasad <palok@marvell.com>
---
 drivers/net/qede/qede_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index a4923670d6..22cd470646 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -2142,6 +2142,7 @@ int qede_rss_hash_update(struct rte_eth_dev *eth_dev,
 		rss_params.rss_enable = 1;
 	}
 
+	rss_params.update_rss_ind_table = 1;
 	rss_params.update_rss_config = 1;
 	/* tbl_size has to be set with capabilities */
 	rss_params.rss_table_size_log = 7;
-- 
2.18.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] net/qede: fix RSS indirection table initialization
@ 2023-05-25  5:30 Devendra Singh Rawat
  2023-05-25 12:22 ` Jerin Jacob
  0 siblings, 1 reply; 5+ messages in thread
From: Devendra Singh Rawat @ 2023-05-25  5:30 UTC (permalink / raw)
  To: dev, palok, jerinj, ferruh.yigit
  Cc: stable, GR-Everest-DPDK-Dev, manishc, Devendra Singh Rawat

RSS indirection table was not updated for VF ports during RSS hash
update, this resulted in device start failure.
This fix updates RSS indirection table during RSS hash update.

Fixes: 7ab35bf6b97b (net/qede: fix RSS)
Cc: stable@dpdk.org

Signed-off-by: Devendra Singh Rawat <dsinghrawat@marvell.com>
Signed-off-by: Alok Prasad <palok@marvell.com>
---
 drivers/net/qede/qede_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index a4923670d6..22cd470646 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -2142,6 +2142,7 @@ int qede_rss_hash_update(struct rte_eth_dev *eth_dev,
 		rss_params.rss_enable = 1;
 	}
 
+	rss_params.update_rss_ind_table = 1;
 	rss_params.update_rss_config = 1;
 	/* tbl_size has to be set with capabilities */
 	rss_params.rss_table_size_log = 7;
-- 
2.18.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-05-26  9:07 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-25 13:54 [PATCH] net/qede: fix RSS indirection table initialization Devendra Singh Rawat
2023-05-26  9:07 ` Jerin Jacob
  -- strict thread matches above, loose matches on Subject: below --
2023-05-25  5:45 Devendra Singh Rawat
2023-05-25  5:30 Devendra Singh Rawat
2023-05-25 12:22 ` Jerin Jacob

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).