patches for DPDK stable branches
 help / color / mirror / Atom feed
* [PATCH] test/crypto: add null check for ZUC authentication op
@ 2022-05-11 13:29 Ciara Power
  2022-05-11 14:25 ` De Lara Guarch, Pablo
  0 siblings, 1 reply; 3+ messages in thread
From: Ciara Power @ 2022-05-11 13:29 UTC (permalink / raw)
  To: dev
  Cc: roy.fan.zhang, kai.ji, Ciara Power, pablo.de.lara.guarch, stable,
	Akhil Goyal

Check if the returned op is NULL because of failure,
before using it and causing a segmentation fault.

Fixes: 4c99481 ("app/test: add ZUC")
Cc: pablo.de.lara.guarch@intel.com
Cc: stable@dpdk.org

Signed-off-by: Ciara Power <ciara.power@intel.com>
---
 app/test/test_cryptodev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index f444144cc6..4ffaadc008 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -6238,8 +6238,8 @@ test_zuc_authentication(const struct wireless_test_data *tdata)
 	else
 		ut_params->op = process_crypto_request(ts_params->valid_devs[0],
 				ut_params->op);
-	ut_params->obuf = ut_params->op->sym->m_src;
 	TEST_ASSERT_NOT_NULL(ut_params->op, "failed to retrieve obuf");
+	ut_params->obuf = ut_params->op->sym->m_src;
 	ut_params->digest = rte_pktmbuf_mtod(ut_params->obuf, uint8_t *)
 			+ plaintext_pad_len;
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] test/crypto: add null check for ZUC authentication op
  2022-05-11 13:29 [PATCH] test/crypto: add null check for ZUC authentication op Ciara Power
@ 2022-05-11 14:25 ` De Lara Guarch, Pablo
  2022-05-11 20:00   ` Akhil Goyal
  0 siblings, 1 reply; 3+ messages in thread
From: De Lara Guarch, Pablo @ 2022-05-11 14:25 UTC (permalink / raw)
  To: Power, Ciara, dev; +Cc: Zhang, Roy Fan, Ji, Kai, stable, Akhil Goyal



> -----Original Message-----
> From: Power, Ciara <ciara.power@intel.com>
> Sent: Wednesday, May 11, 2022 2:29 PM
> To: dev@dpdk.org
> Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>; Ji, Kai <kai.ji@intel.com>;
> Power, Ciara <ciara.power@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; stable@dpdk.org; Akhil Goyal
> <gakhil@marvell.com>
> Subject: [PATCH] test/crypto: add null check for ZUC authentication op
> 
> Check if the returned op is NULL because of failure, before using it and causing a
> segmentation fault.
> 
> Fixes: 4c99481 ("app/test: add ZUC")
> Cc: pablo.de.lara.guarch@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ciara Power <ciara.power@intel.com>

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] test/crypto: add null check for ZUC authentication op
  2022-05-11 14:25 ` De Lara Guarch, Pablo
@ 2022-05-11 20:00   ` Akhil Goyal
  0 siblings, 0 replies; 3+ messages in thread
From: Akhil Goyal @ 2022-05-11 20:00 UTC (permalink / raw)
  To: De Lara Guarch, Pablo, Power, Ciara, dev; +Cc: Zhang, Roy Fan, Ji, Kai, stable

> > Subject: [PATCH] test/crypto: add null check for ZUC authentication op
> >
> > Check if the returned op is NULL because of failure, before using it and causing
> a
> > segmentation fault.
> >
> > Fixes: 4c99481 ("app/test: add ZUC")
> > Cc: pablo.de.lara.guarch@intel.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ciara Power <ciara.power@intel.com>
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Applied to dpdk-next-crypto

Changed subject
test/crypto: fix null check for ZUC authentication op

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-05-11 20:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-11 13:29 [PATCH] test/crypto: add null check for ZUC authentication op Ciara Power
2022-05-11 14:25 ` De Lara Guarch, Pablo
2022-05-11 20:00   ` Akhil Goyal

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git