patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Ali Alnubani <alialnu@nvidia.com>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>,
	Ke Zhang <ke1x.zhang@intel.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH 19.11] net/iavf: fix Rx queue interrupt setting
Date: Wed, 3 Aug 2022 11:40:31 +0000	[thread overview]
Message-ID: <DM4PR12MB516746C979F0000ABA4E510CDA9C9@DM4PR12MB5167.namprd12.prod.outlook.com> (raw)
In-Reply-To: <CAATJJ0J+U7kaf_qFAFmjgUZz8yVGRDweM0fCkRh0wEevu4mnZg@mail.gmail.com>

> -----Original Message-----
> From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> Sent: Wednesday, August 3, 2022 12:58 PM
> To: Ke Zhang <ke1x.zhang@intel.com>
> Cc: stable@dpdk.org
> Subject: Re: [PATCH 19.11] net/iavf: fix Rx queue interrupt setting
> 
> On Wed, Jul 20, 2022 at 7:28 AM Ke Zhang <ke1x.zhang@intel.com> wrote:
> >
> > [ upstream commit a08f9cb698c3d4687765860e328dca727f7a516b ]
> 
> Thank you,
> your patch was too late in regard to my original deadline and I was
> then unavailable for a while.
> In the meantime more patches came in and I do not want to waste any of
> them just because they were late.
> 
> Your patch is applied to the WIP branch now, but currently testing of
> -rc1 is going on which I do not want to disrupt.
> 

Hello,

I believe this is causing the following build failure in 19.11.13-rc2:

"""
In file included from drivers/net/iavf/iavf_ethdev.c:13:
drivers/net/iavf/iavf_ethdev.c: In function 'iavf_dev_rx_queue_intr_disable':
drivers/net/iavf/iavf_ethdev.c:1212:9: error: 'IAVF_VFINT_DYN_CTLN1_WB_ON_ITR_MASK' undeclared (first use in this function); did you mean 'IAVFINT_DYN_CTLN1_WB_ON_ITR_MASK'?
 1212 |         IAVF_VFINT_DYN_CTLN1_WB_ON_ITR_MASK);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
lib/librte_eal/common/include/arch/x86/rte_byteorder.h:74:30: note: in definition of macro 'rte_cpu_to_le_32'
   74 | #define rte_cpu_to_le_32(x) (x)
      |                              ^
drivers/net/iavf/base/iavf_osdep.h:116:2: note: in expansion of macro 'IAVF_PCI_REG_WRITE'
  116 |  IAVF_PCI_REG_WRITE(IAVF_PCI_REG_ADDR((hw), (reg)), (value))
      |  ^~~~~~~~~~~~~~~~~~
drivers/net/iavf/iavf_ethdev.c:1210:2: note: in expansion of macro 'IAVF_WRITE_REG'
 1210 |  IAVF_WRITE_REG(hw,
      |  ^~~~~~~~~~~~~~
drivers/net/iavf/iavf_ethdev.c:1212:9: note: each undeclared identifier is reported only once for each function it appears in
 1212 |         IAVF_VFINT_DYN_CTLN1_WB_ON_ITR_MASK);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
lib/librte_eal/common/include/arch/x86/rte_byteorder.h:74:30: note: in definition of macro 'rte_cpu_to_le_32'
   74 | #define rte_cpu_to_le_32(x) (x)
      |                              ^
drivers/net/iavf/base/iavf_osdep.h:116:2: note: in expansion of macro 'IAVF_PCI_REG_WRITE'
  116 |  IAVF_PCI_REG_WRITE(IAVF_PCI_REG_ADDR((hw), (reg)), (value))
      |  ^~~~~~~~~~~~~~~~~~
drivers/net/iavf/iavf_ethdev.c:1210:2: note: in expansion of macro 'IAVF_WRITE_REG'
 1210 |  IAVF_WRITE_REG(hw,
      |  ^~~~~~~~~~~~~~
"""

I can reproduce on Ubuntu 20.04 with gcc 9.4.0.

- Ali

  reply	other threads:[~2022-08-03 11:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-20  5:19 Ke Zhang
2022-08-03  9:58 ` Christian Ehrhardt
2022-08-03 11:40   ` Ali Alnubani [this message]
2022-08-03 12:15     ` Christian Ehrhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM4PR12MB516746C979F0000ABA4E510CDA9C9@DM4PR12MB5167.namprd12.prod.outlook.com \
    --to=alialnu@nvidia.com \
    --cc=christian.ehrhardt@canonical.com \
    --cc=ke1x.zhang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).