Re: [dpdk-stable] [PATCH v1] gso: fix marking TCP checksum flag in TCP segments

[Ophir Munk <ophirmu@mellanox.com>]

Hi Jiayu,

> -----Original Message-----
> From: Hu, Jiayu [mailto:jiayu.hu@intel.com]
> Sent: Tuesday, April 24, 2018 3:56 PM
> To: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Ophir Munk
> <ophirmu@mellanox.com>; dev@dpdk.org
> Cc: Thomas Monjalon <thomas@monjalon.net>; Olga Shern
> <olgas@mellanox.com>; Pascal Mazon <pascal.mazon@6wind.com>;
> stable@dpdk.org
> Subject: RE: [PATCH v1] gso: fix marking TCP checksum flag in TCP segments
> 
> Hi Konstantin and Ophir,
> 
... 
> > Another possibility - might be make chages in librte_gso to allow user
> > to specify what flags to set for the output packets (probably via
> > rte_gso_ctx.flag)
> 
> It would be a solution. We can add flags to rte_gso_ctx.flag and the GSO
> library can do some extra work (like checksum) according to the flags.
> 

I think that calculating TCP checksums by GSO library should be optional (if at all). 
In my case I prefer TAP PMD to do the work which is TAP-specific.  
My original intention in this patch was only to mark PKT_TX_TCP_CKSUM flag.

> Thanks,
> Jiayu
> >
> > Konstantin
> >
...