* [PATCH] net/mlx5/hws: fix ESP matching validation
@ 2024-01-15 12:09 Michael Baum
2024-01-17 17:11 ` Raslan Darawsheh
0 siblings, 1 reply; 2+ messages in thread
From: Michael Baum @ 2024-01-15 12:09 UTC (permalink / raw)
To: dev
Cc: Matan Azrad, Dariusz Sosnowski, Raslan Darawsheh,
Viacheslav Ovsiienko, Ori Kam, Suanming Mou, hamdani, stable
The "mlx5dr_definer_conv_item_esp()" function validates first whether
"ipsec_offload" PRM flag is on, if the flag is off the function returns
error.
The "ipsec_offload" PRM flag indicates whether IPsec encrypt/decrypt is
supported, IPsec matching may be supported even when this flag is off.
This patch removes this validation.
Fixes: 81cf20a25abf ("net/mlx5/hws: support match on ESP item")
Cc: hamdani@nvidia.com
Cc: stable@dpdk.org
Signed-off-by: Michael Baum <michaelba@nvidia.com>
Acked-by: Hamdan Igbaria <hamdani@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
drivers/net/mlx5/hws/mlx5dr_definer.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.c b/drivers/net/mlx5/hws/mlx5dr_definer.c
index 0b60479406..7bd4ea560e 100644
--- a/drivers/net/mlx5/hws/mlx5dr_definer.c
+++ b/drivers/net/mlx5/hws/mlx5dr_definer.c
@@ -2240,11 +2240,6 @@ mlx5dr_definer_conv_item_esp(struct mlx5dr_definer_conv_data *cd,
const struct rte_flow_item_esp *m = item->mask;
struct mlx5dr_definer_fc *fc;
- if (!cd->ctx->caps->ipsec_offload) {
- rte_errno = ENOTSUP;
- return rte_errno;
- }
-
if (!m)
return 0;
if (m->hdr.spi) {
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [PATCH] net/mlx5/hws: fix ESP matching validation
2024-01-15 12:09 [PATCH] net/mlx5/hws: fix ESP matching validation Michael Baum
@ 2024-01-17 17:11 ` Raslan Darawsheh
0 siblings, 0 replies; 2+ messages in thread
From: Raslan Darawsheh @ 2024-01-17 17:11 UTC (permalink / raw)
To: Michael Baum, dev
Cc: Matan Azrad, Dariusz Sosnowski, Slava Ovsiienko, Ori Kam,
Suanming Mou, Hamdan Igbaria, stable
Hi,
> -----Original Message-----
> From: Michael Baum <michaelba@nvidia.com>
> Sent: Monday, January 15, 2024 2:10 PM
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@nvidia.com>; Dariusz Sosnowski
> <dsosnowski@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>; Slava
> Ovsiienko <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>;
> Suanming Mou <suanmingm@nvidia.com>; Hamdan Igbaria
> <hamdani@nvidia.com>; stable@dpdk.org
> Subject: [PATCH] net/mlx5/hws: fix ESP matching validation
>
> The "mlx5dr_definer_conv_item_esp()" function validates first whether
> "ipsec_offload" PRM flag is on, if the flag is off the function returns
> error.
>
> The "ipsec_offload" PRM flag indicates whether IPsec encrypt/decrypt is
> supported, IPsec matching may be supported even when this flag is off.
>
> This patch removes this validation.
>
> Fixes: 81cf20a25abf ("net/mlx5/hws: support match on ESP item")
> Cc: hamdani@nvidia.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Michael Baum <michaelba@nvidia.com>
> Acked-by: Hamdan Igbaria <hamdani@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
Patch applied to next-net-mlx,
Kindest regards
Raslan Darawsheh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-17 17:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-15 12:09 [PATCH] net/mlx5/hws: fix ESP matching validation Michael Baum
2024-01-17 17:11 ` Raslan Darawsheh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).