RE: [PATCH] crypto/scheduler: fix last element for valid args

["Ji, Kai" <kai.ji@intel.com>]

Acked-by: Kai Ji <kai.ji@intel.com>

> -----Original Message-----
> From: Power, Ciara <ciara.power@intel.com>
> Sent: Friday, April 14, 2023 1:33 PM
> To: Ji, Kai <kai.ji@intel.com>
> Cc: dev@dpdk.org; Power, Ciara <ciara.power@intel.com>;
> fanzhang.oss@gmail.com; stable@dpdk.org
> Subject: [PATCH] crypto/scheduler: fix last element for valid args
> 
> The list of valid arguments for Scheduler PMD should be terminated with a
> NULL entry, as expected by rte_kvargs_parse.
> 
> Without this, if an invalid key name was used, a global buffer overflow
> occurred resulting in a segmentation fault.
> 
> Fixes: 503e9c5afb38 ("crypto/scheduler: register as vdev driver")
> Cc: fanzhang.oss@gmail.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> ---
>  drivers/crypto/scheduler/scheduler_pmd.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/scheduler/scheduler_pmd.c
> b/drivers/crypto/scheduler/scheduler_pmd.c
> index 9d1ce46622..4e8bbf0e09 100644
> --- a/drivers/crypto/scheduler/scheduler_pmd.c
> +++ b/drivers/crypto/scheduler/scheduler_pmd.c
> @@ -50,7 +50,8 @@ static const char * const scheduler_valid_params[] = {
>  	RTE_CRYPTODEV_VDEV_MAX_NB_QP_ARG,
>  	RTE_CRYPTODEV_VDEV_SOCKET_ID,
>  	RTE_CRYPTODEV_VDEV_COREMASK,
> -	RTE_CRYPTODEV_VDEV_CORELIST
> +	RTE_CRYPTODEV_VDEV_CORELIST,
> +	NULL
>  };
> 
>  struct scheduler_parse_map {
> --
> 2.25.1